[LU-9243] GSS struct definition badness Created: 22/Mar/17 Updated: 10/Sep/22 Resolved: 11/Jun/22 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.15.0 |
| Fix Version/s: | Lustre 2.16.0, Lustre 2.15.2 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | Sebastien Buisson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
struct lgssd_ioctl_param is defined is two places, which is bad: C symbol: lgssd_ioctl_param
File Function Line
0 lustre/ptlrpc/gss/gss_cli_upcall.c <global> 214 struct lgssd_ioctl_param {
1 lustre/utils/gss/lsupport.h <global> 98 struct lgssd_ioctl_param {
2 lustre/ptlrpc/gss/gss_cli_upcall.c gss_do_ctx_init_rpc 233 struct lgssd_ioctl_param param;
3 lustre/utils/gss/gssd_proc.c do_negotiation 442 struct lgssd_ioctl_param param;
4 lustre/utils/gss/lgss_keyring.c do_nego_rpc 127 struct lgssd_ioctl_param param;
struct gss_header and others are going on the wire but are only defined in lustre/ptlrpc/gss/gss_internal.h and are not wirechecked. |
| Comments |
| Comment by Gerrit Updater [ 17/Feb/22 ] |
|
"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/46543 |
| Comment by Gerrit Updater [ 11/Jun/22 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46543/ |
| Comment by Peter Jones [ 11/Jun/22 ] |
|
Landed for 2.16 |
| Comment by Gerrit Updater [ 17/Jun/22 ] |
|
"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/47664 |