[LU-9318] sanity-lsnapshot should be skipped for all non-ZFS configs Created: 11/Apr/17 Updated: 19/Apr/17 Resolved: 19/Apr/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.10.0 |
| Fix Version/s: | Lustre 2.10.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | James Casper | Assignee: | Saurabh Tandan (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | test | ||
| Environment: |
Interop: |
||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
https://testing.hpdd.intel.com/test_sessions/1ef8dc97-8487-4c21-ad37-fe03e2430916 |
| Comments |
| Comment by Minh Diep [ 11/Apr/17 ] |
|
James, could you tell us the reason for skipping? and shouldn't this be in lustre tree, not auto test? |
| Comment by James Casper [ 11/Apr/17 ] |
|
sanity-lsnapshot should only be run on zfs configs. Of our 7 regression and interop configs, only 2 use ZFS. It was correctly skipped or |
| Comment by James Nunez (Inactive) [ 11/Apr/17 ] |
|
The problem here is that the check for a ZFS file system is after the script tries to add snapshot to the debug list. 00:27:14:CMD: onyx-47vm7 /usr/sbin/lctl set_param debug=+snapshot 00:27:14:onyx-47vm7: error: set_param: setting /proc/sys/lnet/debug=+snapshot: Invalid argument 00:27:14:sanity-lsnapshot returned 0 This is a script issue and I'll convert ticket to LU. |
| Comment by Andreas Dilger [ 11/Apr/17 ] |
|
This just needs a check at the start of the script to skip the whole thing if not running with ZFS, or if the version is too old: [ $(lustre_version_code mds1) -lt $(version_code 2.9.55) ||
$(lustre_version_code ost1) -lt $(version_code 2.9.55) ] &&
skip "Need server version at least 2.9.55" && exit 0
[ $(facet_fstype mds1) = "ldiskfs" ] || $(facet_fstype ost1) = "ldiskfs" ] &&
skip "can't test snapshots with ldiskfs" && exit 0
|
| Comment by Gerrit Updater [ 13/Apr/17 ] |
|
Saurabh Tandan (saurabh.tandan@intel.com) uploaded a new patch: https://review.whamcloud.com/26600 |
| Comment by Gerrit Updater [ 19/Apr/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/26600/ |
| Comment by Peter Jones [ 19/Apr/17 ] |
|
Landed for 2.10 |