[LU-9325] Improve lustre kernel string handling

• Status: In Progress
• Project: Lustre
• Affects Version/s: Lustre 2.10.0
• Fix Version/s: Upstream
• Type: Improvement
• Priority: Minor
• Reporter: James A Simmons
• Assignee: James A Simmons
• Resolution: Unresolved
• Labels: patch
• Epic/Theme: upstream

Description

While pushing work upstream some of the feedback was related to how Lustre does its own direct parsing of string which is frowned on. Secondly we are still not using newer kernel string interfaces like kstrtoul instead of simple_string() and other examples exist as well that have been merged upstream.

Issue Links

• is related to: LU-4423 Tracking of patches from upstream ker...
• is related to: LU-12861 Add and use scnprintf() where using s...
• is related to: LU-12511 Prepare lustre for adoption into the ...

Comments

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/26558
Subject: LU-9325 obdclass: handle strings correctly in lmd_find_delimiter
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 26c43bcffb6a06d791813bf634341c1a29be3a89

[Peter Jones]

James is working on this

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30539/
Subject: LU-9325 obd: replace lprocfs_str_to_s64
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 860e20e42ddc45bf5521cbd5f53d35a310b34ded

[Peter Jones]

Landed for 2.11

[Peter Jones]

Whoops still another patch to come

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32217
Subject: LU-9325 libcfs: replace simple_strtoul with kstrtouint
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 200e60f1f76a24d75513d102866c8b6c4839bef1

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32322
Subject: LU-9325 libcfs: Convert cfs_trace_daemon_command to use kstrtoul
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cfd07f26a52b6d72f7a6320fede3966905d9f5b1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/26558/
Subject: LU-9325 obdclass: handle strings correctly in lmd_find_delimiter
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 25aed16fe4d33c3ce09a4135774173e7adba3943

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32217/
Subject: LU-9325 libcfs: handle complex strings in cfs_str2num_check
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5728fb3009f5f797d1ff68e5ad6de341850c35d4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32322/
Subject: LU-9325 libcfs: Convert cfs_trace_daemon_command to use kstrtoul
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cfd07f26a52b6d72f7a6320fede3966905d9f5b1

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32594
Subject: LU-9325 ptlrpc: replace simple_strtol with kstrtol
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ec619b812ea13f6f0ffe763a2363634be235c8fe

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32598
Subject: LU-9325 llog: replace simple_strtol with kstrtol
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c99eda99d72103f5f012e9c8744dba651f34b77d

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32785
Subject: LU-9325 ptlrpc: replace simple_strtol with kstrtol
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 800d04bd0ec6cd82be7cc8edbd9df7b45e4a7de5

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32598/
Subject: LU-9325 llog: replace simple_strtol with kstrtol
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 62a19d61419453048dc595b8ba2cf77c06a9755f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32785/
Subject: LU-9325 ptlrpc: replace simple_strtol with kstrtol
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8f37d64b6bc9111ff20ffb0bd22daf8fb9c8c159

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33385
Subject: LU-9325 libcfs: don't stomp on module string for cfs_str2num_check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d9f60a170dd8f7786b52b8f09bfe04218c374cbe

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33617
Subject: LU-9325 obdclass: make niduuid for lustre_stop_mgc() static
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fdf3062c711fa27504be9029e03a4c84c9014ed5

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33959
Subject: LU-9325 msg: replace obsolete simple_strtoul use
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f7ebdb6c5aa4a42e4a7ce4e1ec3daecdb1f86107

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33959/
Subject: LU-9325 msg: replace obsolete simple_strtoul use
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 30239b4aecbe80e14f65316defd9fe162426147a

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36551
Subject: LU-9325 mds: replace simple_strtol use with target_name2index()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8625814aecc72beb592d6620b4382c007c119a04

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36551/
Subject: LU-9325 mds: replace simple_strtol use with target_name2index()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7d37148e36854a293fdc40d7d771769f0a6b64e0

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38846
Subject: LU-9325 mdt: replace simple_strtol() with kstrtol()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 201128895c982522dc78b9f6c98329e56a7cb5a1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38846/
Subject: LU-9325 mdt: replace simple_strtol() with kstrtol()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4115148e4ac5ccb3620a9f8d3e48da0a712943c5

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39498
Subject: LU-9325 fld: replace simple_strto* with kstr* functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3feaa7d148d9b64e9d1fb9c4afef7f13f59f52d5

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39498/
Subject: LU-9325 fld: replace simple_strto* with kstr* functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f875fa73f215c3e1f71656dd8aa0cd30d931fa09

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40119
Subject: LU-9325 osd-ldisk: replace simple_strto* with kstr* functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8ddd1d616f35a9b9937631fa5e6d653d8e855886

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/40119/
Subject: LU-9325 osd-ldisk: replace simple_strto* with kstr* functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e520b6a7fa6b6dd3f703dc8c6918a3699b3d9517

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/33617/
Subject: LU-9325 obdclass: make niduuid for lustre_stop_mgc() static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 85b400b67b0d8d49315f80252025c98303d242bb

[Gerrit Updater]

"jsimmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49910
Subject: LU-9325 obd: replace simple_strtoul()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6da5463b9e39c149c3c6717398dc93eb3cc57d0d

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49910/
Subject: LU-9325 obd: replace simple_strtoul()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 79b34a83f811f5f1dc40a077bd6d5f65194c9bbe

[James A Simmons]

Down to two patches.

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51209
Subject: LU-9325 obdclass: use match_table for server mount options
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 234816c141dcb499b50963f33ac6c05b9d5f79e8