[LU-937] CLIENTONLY testing no longer works

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: Brian Murrell (Inactive)
• Assignee: WC Triage
• Resolution: Fixed

Environment

CLIENTONLY=true PDSH="pdsh -R ssh -S -w" mds_HOST=mds1 mgs_HOST=mds2 ost1_HOST=oss1 ost2_HOST=oss2 OSTDEV1="/dev/vdb" OSTDEV2="/dev/vdb" bash /usr/lib64/lustre/tests/sanity.sh

• Severity: 3

Description

I'm trying to run "CLIENTONLY" testing on 2.1. CLIENTONLY testing is basically a test mode where test-framework.sh is not allowed to muck with the servers, and therefore has to skip much of the server configuration portion of the testing. IIRC it assumes that lustre is already mounted on the client doing the testing.

This seems to have gotten broken with 165400bbb8161b36764bd51056293375101329a6 back at the end of 2009.

I have (naïvely) applied the following patch to at least get past the blocking nature of this bug:

--- a/lustre/tests/test-framework.sh
+++ b/lustre/tests/test-framework.sh
@@ -2436,7 +2436,9 @@ check_and_setup_lustre() {
     fi
 
     init_gss
-    set_flavor_all $SEC
+    if [ -z "$CLIENTONLY" ]; then
+        set_flavor_all $SEC
+    fi
 
     if [ "$ONLY" == "setup" ]; then
         exit 0

I don't know if this really is an acceptable solution but I can't imagine why it would be acceptable to try to set/test the GSS flavour when the particular (CLIENTONLY) testing mode is supposed to keep it's hands off of the servers and just use the client mount as it is anyway.

Probably before landing such a patch, somebody would need to investigate the entire nature of set_flavor_all() to be sure this is the correct fix.

Issue Links

• is related to: LU-9205 sanity.sh fails in CLIENTONLY mode

Comments

[Andreas Dilger]

Brian,
it makes sense to push this to Gerrit and land it. Since we don't test GSS at all (hopefully that will change next year when IU makes a "simple shared key" GSS plugin that we can test all of the time), I'm expecting that there is no harm to land your fix now and leave it to others to catch any problems with it.

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/20312
Subject: LU-937 tests: fix CLIENTONLY mode for KNL testing
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d99b5936b44ca6d6b12c33442eae2e035ab47432

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/20312/
Subject: LU-937 tests: fix CLIENTONLY mode for KNL testing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7b5f76efce503cdca836e138332fdbaae4b4bbf4

[Peter Jones]

Landed for 2.9