[LU-9405] mount.lustre parses device paths dumbly

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.11.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: WC Triage
• Resolution: Fixed
• Labels: utils
• Severity: 3

Description

mount.lustre parses does some device path parsing to get find the paths of the block device tunables. From my comment on https://review.whamcloud.com/#/c/26399/ from LU-9292:

1. I've never though that mount.lustre should be tuning the block devices. That's the responsibility of admins and/or integrators.
2. Assuming we do want to do it, this is not a good way to go from partition to the blockdev tunables directory. sysfs is already setup for this and we can avoid easily breakable device path parsing:

 
major=0x$(stat --format=%t /dev/sdc1)
minor=0x$(stat --format=%T /dev/sdc1)
 
~$ readlink -f /sys/dev/block/$((major)):$((minor))/../queue
/sys/devices/pci0000:00/0000:00:1f.2/ata3/host3/target3:0:0/3:0:0:0/block/sdc/queue

if [[ -f /sys/dev/block/$((major)):$((minor))/partition ]]; then
  # Use /sys/dev/block/$((major)):$((minor))/../queue
else
  # Use /sys/dev/block/$((major)):$((minor))/queue
fi

Issue Links

• is related to: LU-9292 mount.lustre doesn't handle partition...

Comments

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: https://review.whamcloud.com/26909
Subject: LU-9405 utils: remove device path parsing from mount.lustre
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6df93848c32eaa48e8b524515e201edc06f945bc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/26909/
Subject: LU-9405 utils: remove device path parsing from mount.lustre
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 97671436c5284d955241b5bb9c79d415aec5792d

[Peter Jones]

Landed for 2.11