[LU-9422] sanity test 234 is skipped incorrectly for attr rpm version number Created: 01/May/17 Updated: 25/Jan/18 Resolved: 25/Jan/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.10.0 |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | test | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
sanity test_234 is being skipped with the message SKIP: sanity test_234 LU-3703: attr version getfattr 2.4.46 too old Looking at the test code, the test is skipped due to the check 13747 # output of the form: attr 2 4 44 3 fc13 x86_64 13748 V=($(IFS=".-" rpm -q attr)) 13749 if [[ ${V[1]} > 2 || ${V[2]} > 4 || ${V[3]} > 44 || 13750 ${V[1]} = 2 && ${V[2]} = 4 && ${V[3]} = 44 && ${V[4]} > 6 ]]; then 13751 # attr pre-2.4.44-7 had a bug with rc 13752 # LU-3703 - SLES 11 and FC13 clients have older attr 13753 getfattr -n user.attr $DIR/$tdir/$tfile && 13754 error "getfattr should have failed with ENOMEM" 13755 else 13756 skip "LU-3703: attr version $(getfattr --version) too old" 13757 fi From this description, this test should not be skipped with attr version 2.4.46. The problem is setting the Internal Field Separator (IFS) this way isn’t actually setting the correct values to split the string on. This is easily fixed by setting the IFS outside the assignment/call to rpm, but is this check necessary any more? |
| Comments |
| Comment by Gerrit Updater [ 01/May/17 ] |
|
James Nunez (james.a.nunez@intel.com) uploaded a new patch: https://review.whamcloud.com/26906 |
| Comment by Gerrit Updater [ 25/Jan/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/26906/ |
| Comment by Peter Jones [ 25/Jan/18 ] |
|
Landed for 2.11 |