[LU-9446] sanity-quota test_39: test passes without really getting run

• Status: Open
• Project: Lustre
• Affects Version/s: Lustre 2.10.0
• Type: Bug
• Priority: Minor
• Reporter: Maloo
• Assignee: WC Triage
• Resolution: Unresolved
• Severity: 3

Description

This issue was created by maloo for sarah_lw <[e-mail]>

This issue relates to the following test suite run: https://testing.hpdd.intel.com/test_sets/087a3e7a-2fe3-11e7-8847-5254006e85c2.

There are some errors in the test_39 code.
1. When checking the version, the version_code should be 3 digital parts, not "2.10"

test_39 code

test_39() {
        [ "$(facet_fstype $singlemds)" != "ldiskfs" ] &&
                skip "only for ldiskfs mdt" && return 0

        [ $(lustre_version_code $SINGLEMDS) -lt $(version_code 2.10) ] &&
                skip "Old server doesn't support project quota." && return

test log

== sanity-quota test 39: Project ID interface works correctly ======================================== 22:00:58 (1493762458)
CMD: trevis-48vm7 /usr/sbin/lctl get_param -n version 2>/dev/null ||
				/usr/sbin/lctl lustre_build_version 2>/dev/null ||
				/usr/sbin/lctl --version 2>/dev/null | cut -d' ' -f2
/usr/lib64/lustre/tests/test-framework.sh: line 387: (2 << 16) | (10 << 8) | : syntax error: operand expected (error token is "| ")
/usr/lib64/lustre/tests/sanity-quota.sh: line 2425: [: 133432: unary operator expected
       -p     List the file's project number.

2. When checking if e2fsprogs supports project quota with "man lsattr", the following "enable_project_quota" doesn't really get run when the support is available. There should be

{...}

to around the "skip; return" part

code

man lsattr | grep -i project ||
                skip "old e2fsprogs dosen't support project quota" &&
                return 0

        enable_project_quota

test log

/usr/lib64/lustre/tests/sanity-quota.sh: line 2425: [: 133432: unary operator expected
       -p     List the file's project number.
Resetting fail_loc on all nodes...CMD: trevis-48vm1.trevis.hpdd.intel.com,trevis-48vm2,trevis-48vm7,trevis-48vm8 lctl set_param -n fail_loc=0 	    fail_val=0 2>/dev/null
done.
22:01:00 (1493762460) waiting for trevis-48vm1.trevis.hpdd.intel.com network 5 secs ...
22:01:00 (1493762460) network interface is UP