[LU-9448] Assert on an empty NUMA node

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.10.0
• Type: Bug
• Priority: Critical
• Reporter: Amir Shehata (Inactive)
• Assignee: Amir Shehata (Inactive)
• Resolution: Fixed
• Severity: 3

Description

Testing on a system that has 4 numa nodes, but 1 of the nodes has no CPUs assigned triggered an assert in o2iblnd:

LASSERT(sched->ibs_nthreads > 0);

LU-6325 libcfs: shortcut to create CPT from NUMA topology
introduced a method where if the module parameter cpu_pattern was set to "N" or "n", it would create the CPTs from the NUMA topology. This has the potential of exposing the assert where a schedule's ibs_nthreads could be 0 because there are no CPUs assigned to that CPT to which the scheduler is bound (IE cfs_cpt_weight() for the CPT in question returns 0).

LU-8703 libcfs: use int type for CPT identification.
In fact exposed this bug when the default value for the module parameter cpu_pattern was set to "N".

We should be able to handle this case in the LND, by only creating schedulers for non empty CPTs.

Or by not creating an empty CPT in the first place in the libcfs code.

Issue Links

• is related to: LU-8703 rework CPU partition code

Comments

[Dmitry Eremin (Inactive)]

The fix is still under review https://review.whamcloud.com/23222/

[Gerrit Updater]

Amir Shehata ([e-mail]) uploaded a new patch: https://review.whamcloud.com/27145
Subject: LU-9448 lnet: handle empty CPTs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 94307f8eb7791d8d56e55b5db184b2006a59f9fa

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/27145/
Subject: LU-9448 lnet: handle empty CPTs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e711370e13dcbe059e2551aa575c41d62cbcfca9

[Peter Jones]

Landed for 2.10