[LU-9494] Improve message for skipping tests

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.10.1, Lustre 2.11.0
• Type: Improvement
• Priority: Minor
• Reporter: James Nunez (Inactive)
• Assignee: Ruth Klundt (Inactive)
• Resolution: Fixed
• Labels: easy, hackathon2017, test

Description

During Lustre testing, a test can be skipped for a variety of legitimate reasons like the test needs more than one MDT or the test needs more than three clients or the test needs separate MDS and MGS. When a test is skipped, a message is printed to explain why the test is being skipped. These messages should be short, but should be informative. There are many skipped test messages that are not informative. For example, con-sanity test 50i is skipped because “1 < 2; skipping”.

We should make the messages for skipped tests be informative and, where possible, when tests are skipped for the same reason, make the messages the same. For example, when a test requires three or more MDTs, we should use “needs >= 3 MDTs”

Here are a few messages that should be changed:
conf-sanity test_50i, has message is “1 < 2”
should be “needs >= 2 MDTs”

sanity-quota test 7e: “Required more MDTs”
should be “needs >= 2 MDTs”

sanity-quota test 12b: “skipping rebalancing test”
should be “needs >= 2 MDTs”

sanity-lfsck tests 2e, 12a, 15c, 22a, 22b, 23a, 24, 26b, 27b, 28, 31a-h
“We need at least 2 MDSes for this test”
“The test needs at least 2 MDTs”
should be
“needs >= 2 MDTs”

conf-sanity test 5f
message is “combined mgs and mds”. From the message it’s not clear if the test is being skipped because there is a combined MGS/MDS or because the servers are separate.
This message should be changed to something like “needs separate mgs and mds” . If the test really only needs separate targets and not servers, then this should be specified.

Similarly, for recovery-small test 103, the message is “mgs and mds on the same target” could be clarified.

The messages stating that a certain server file system is required could be standardized. Right now we have “only for ldiskfs”, “only for ldiskfs mdt”, and “only for ldiskfs MDT”

Comments

[Gerrit Updater]

Ruth Klundt ([e-mail]) uploaded a new patch: https://review.whamcloud.com/27350
Subject: LU-9494 test: Improve message for skipping tests
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a39fade45dde7f8e2b8b305eb964b727e6b4be50

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/27350/
Subject: LU-9494 test: Improve message for skipping tests
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 75b426f9f9d3f21e08cd1e62b7fa4962a2b8c679

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28522
Subject: LU-9494 test: Improve message for skipping tests
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: e8b4dd83455cb9778828e1394d8593074e3dfd74

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/28522/
Subject: LU-9494 test: Improve message for skipping tests
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 5afcef6bde7cf1d09dc8556099ee49dfa1a1855e