[LU-9505] lfs changelog fails for MDT index containing numerals [A-F] Created: 15/May/17 Updated: 03/Aug/17 Resolved: 19/Jul/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.8.0 |
| Fix Version/s: | Lustre 2.10.1, Lustre 2.11.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Olaf Faaland | Assignee: | Emoly Liu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | llnl | ||
| Environment: |
lustre-2.8.0_8.chaos |
||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
lfs changelog <mdtname> parses the index of mdtname incorrectly, causing it to fetch the wrong changelog entries if the index contains letters [A-F] (e.g. lquake-MDT000A). The error appears to be here: diff --git a/lustre/utils/liblustreapi.c b/lustre/utils/liblustreapi.c
index 9301383..38e2085 100644
--- a/lustre/utils/liblustreapi.c
+++ b/lustre/utils/liblustreapi.c
@@ -3985,7 +3985,7 @@ int root_ioctl(const char *mdtname, int opc, void *data, int *mdtidxp,
return -EINVAL;
ptr = fsname + strlen(fsname) - 8;
*ptr = '\0';
- index = strtol(ptr + 4, NULL, 10);
+ index = strtol(ptr + 4, NULL, 16);
rc = get_root_path(WANT_FD | want_error, fsname, &fd, NULL, -1);
}
if (rc < 0) {
It looks like this error is present in Lustre 2.9 as well. Master exposes changelogs using the MDT name itself, not just the index, and may not have this issue. |
| Comments |
| Comment by Peter Jones [ 16/May/17 ] |
|
Emoly Could you please assist with this issue. Even though this function is not called in master it would be a good idea to either correct or remove the function there to prevent someone getting hit by this problem again (as well as providing a suitable fix for LLNL on 2.8 FE) Peter |
| Comment by Gerrit Updater [ 17/May/17 ] |
|
Emoly Liu (emoly.liu@intel.com) uploaded a new patch: https://review.whamcloud.com/27156 |
| Comment by Gerrit Updater [ 19/Jul/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/27156/ |
| Comment by Peter Jones [ 19/Jul/17 ] |
|
Landed for 2.11 |
| Comment by Gerrit Updater [ 26/Jul/17 ] |
|
Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/28225 |
| Comment by Gerrit Updater [ 03/Aug/17 ] |
|
John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/28225/ |