[LU-9520] Variable buffer size in llapi changelog reader Created: 17/May/17 Updated: 06/Apr/22 Resolved: 06/Apr/22 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Henri Doreau (Inactive) | Assignee: | Quentin Bouget |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
LLAPI uses a fixed-sized (4096 bytes) buffer to read changelog records. It should be possible for users to set a different value. |
| Comments |
| Comment by Gerrit Updater [ 17/May/17 ] |
|
Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: https://review.whamcloud.com/27159 |
| Comment by Peter Jones [ 17/May/17 ] |
|
Thanks for the patch Henri |
| Comment by Andreas Dilger [ 19/May/17 ] |
|
In addition to adding an API to change the buffe size, it is worthwhile to ask if the current size is too small for best performance. Should the size be increased by default to something larger (16KB, 64KB, 1MB, ...)? It doesn't make sense to leave the current default value performing poorly for most users. |
| Comment by Peter Jones [ 12/Jan/19 ] |
|
Quentin Is this still a patch CEA are interested in? Peter |
| Comment by Quentin Bouget [ 14/Jan/19 ] |
|
No, thank you. But I agree with Andreas, the buffer is probably too small for most use cases: a changelog record is at least 64 bytes long, so 4K bytes only hold 64 changelog records at best. I will start working on changelog processing in a few weeks, if this becomes an issue I will reopen the ticket (assuming it is closed by then). |
| Comment by Peter Jones [ 14/Jan/19 ] |
|
ok thanks! If you intend to work on a different approach eventually then I think that it is ok to reuse this ticket |
| Comment by Quentin Bouget [ 14/Jan/19 ] |
|
Ok, thank you. |