[LU-9682] Nodemap ip range missing if delete another nodemap the same range

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.11.0, Lustre 2.10.2
• Type: Bug
• Priority: Minor
• Reporter: sebg-crd-pm (Inactive)
• Assignee: Emoly Liu
• Resolution: Fixed
• Severity: 3

Description

I create nodemap1 and add range then delete the range in anthoer nodemap2.
Then nodemap1 ip range disappeared.

[Test steps:]
lctl nodemap_add nodemap1
lctl nodemap_add nodemap2
lctl nodemap_add_range --name nodemap1 --range 192.168.19.[0-255]@o2ib20
lctl get_param nodemap.nodemap1.* | grep start_nid
lctl nodemap_del_range --name nodemap2 --range 192.168.19.[0-255]@o2ib20
lctl get_param nodemap.nodemap1.* | grep start_nid

[Test result:]
[root@mdsb1 ~]# lctl nodemap_add nodemap1
[root@mdsb1 ~]# lctl nodemap_add nodemap2
[root@mdsb1 ~]# lctl nodemap_add_range --name nodemap1 --range 192.168.19.[0-255]@o2ib20
[root@mdsb1 ~]# lctl get_param nodemap.nodemap1.* | grep start_nid

{ id: 20, start_nid: 192.168.19.0@o2ib20, end_nid: 192.168.19.255@o2ib20 }

[root@mdsb1 ~]# lctl nodemap_del_range --name nodemap2 --range 192.168.19.[0-255]@o2ib20
[root@mdsb1 ~]# lctl get_param nodemap.nodemap1.* | grep start_nid
[root@mdsb1 ~]#

Comments

[Peter Jones]

Emoly

Can you please assist with this issue?

Thanks

Peter

[Emoly Liu]

This issue was caused by function nodemap_del_range(), where we should check if the current nodemap has the specified range before we delete it from global range tree.
I will push a patch later.

[Gerrit Updater]

Emoly Liu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28922
Subject: LU-9682 nodemap: delete nids range from nodemap correctly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bb2a6d276fc927f7ba7a690808fa9845a8e4f954

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28922/
Subject: LU-9682 nodemap: delete nids range from nodemap correctly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 62ca9b823524ca44d3344b2555754890abc55a3b

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/29138
Subject: LU-9682 nodemap: delete nids range from nodemap correctly
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 506f3a01c0fc2b601b879cde0d5a4d7d14ef75d0

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/29138/
Subject: LU-9682 nodemap: delete nids range from nodemap correctly
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 783b470f800c85e9ca5c9453fdb3c13062f67e41