[LU-9814] prealloc table change don't work after 2.10 upgrade

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.10.0
• Fix Version/s: Lustre 2.11.0, Lustre 2.10.2
• Type: Bug
• Priority: Major
• Reporter: Alexey Lyashkov
• Assignee: Zhenyu Xu
• Resolution: Fixed

Environment

RHEL 7.2

• Severity: 3

Description

1. cat /proc/fs/ldiskfs/md0p1/prealloc_table
   256 512 1024
2. echo "256 512 1024” > /proc/fs/ldiskfs/md0p1/prealloc_table
   -bash: echo: write error: Invalid argument

Issue Links

• is related to: LU-3719 divide error in ldiskfs_mb_normalize_...

Comments

[James Nunez (Inactive)]

What version of Lustre are you upgrading from?

[Alexey Lyashkov]

It test system upgrade from IEEL 3.
bug introduced by commit
git describe b9ecf2671cba08530cc49d47713a360f2c6c25ca
v2_10_50_0-19-gb9ecf2671c

if one chunk was reverted

--- ldiskfs/mballoc.c	2017-08-01 05:41:12.711164350 -0700
+++ /usr/src/lustre/2.10.0/ldiskfs/mballoc.c	2017-08-01 05:44:25.782155391 -0700
@@ -2357,20 +2357,16 @@
 	num = 0;
 	cur = str;
 	end = str + cnt;
-	while (cur < end) {
-		int rc;
-		while ((cur < end) && (*cur == ' '))
-			cur++;
-		rc = kstrtol(cur, 0, &value);
-		if (rc != 0)
-			return -EINVAL;
-		if (value == 0)
-			break;
-		if (value <= prev)
-			return -EINVAL;
-		prev = value;
-		num++;
-	}
+        while ((cur < end) && (*cur == ' ')) cur++;
+	    value = simple_strtol(cur, &cur, 0);
+               if (value == 0)
+                      break;
+               if (value <= prev)
+                       return -EINVAL;
+               prev = value;
+               num++;
+       }
+
 
 	new_table = kmalloc(num * sizeof(*new_table), GFP_KERNEL);
 	if (new_table == NULL)

it will be work again.

[Peter Jones]

Bobijam

Could you please advise?

Thanks

Peter

[Alexey Lyashkov]

btw. patch in LU-3719 isn't real solution for a own bug. We hit similar bug with patch applied. LU-3917 root cause is unprotected access to the table while update. prealloc_table modified by ext4_mb_prealloc_table_add while accessed. Andriy Skylush should fill a ticket and provide a more details in near time.

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28553
Subject: LU-9814 ldiskfs: restore simple_strtol in prealloc
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: add8915bb4083d29aec27fb81ac49b7ed9ecb9a7

[Peter Jones]

Alexey

Does this patch work from your point of view?

Peter

[Brad Hoagland (Inactive)]

Hi shadow,

Do you have any updates on the patch?

Thanks,

Brad

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28553/
Subject: LU-9814 ldiskfs: restore simple_strtol in prealloc
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 685ef61f0fb9849e3f7a32c4ebf2980d3300afb0

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/29733
Subject: LU-9814 ldiskfs: restore simple_strtol in prealloc
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: d42fb752b4b03e03e88c42bcc45ce324dba2e6a5

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/29733/
Subject: LU-9814 ldiskfs: restore simple_strtol in prealloc
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 3e8f17ccfe0a2358b93dbda9bba05c8dfd95aa61