[LU-9855] Clean up obdclass preprocessor code

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.15.0
• Type: Task
• Priority: Minor
• Reporter: Ben Evans (Inactive)
• Assignee: Neil Brown
• Resolution: Fixed

Description

obdclass abuses the preprocessor, and the code needs to be trimmed, cleaned up, or turned into normal functions so that it is easier to read and understand.

Issue Links

• is related to: LU-14145 protect cli->cl_import with with_imp_...
• is related to: LU-12511 Prepare lustre for adoption into the ...

Comments

[Gerrit Updater]

Ben Evans ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28458
Subject: LU-9855 obdclass: Code cleanup
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 55f973a582be7aac5a61de9e2127cf400a08b813

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28458/
Subject: LU-9855 obdclass: Code cleanup
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8c3c81fb787ab0a0152ebf497d1b4aef480bb82f

[Peter Jones]

Landed for 2.11

[Ben Evans (Inactive)]

There's a few more patches to really clean this up. I'm trying to break it into digestible chunks.

[Gerrit Updater]

Ben Evans ([e-mail]) uploaded a new patch: https://review.whamcloud.com/29286
Subject: LU-9855 obdclass: cleanup obd_class.h defines
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f7c05bb2b21854d8c837d7064f0875cda54ceef3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/29286/
Subject: LU-9855 obdclass: cleanup obd_class.h defines
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 49d8a7ccd7389586bd1c5eb98bf988f68ad2630f

[Gerrit Updater]

Ben Evans ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30437
Subject: LU-9855 obd: remove OBP and MBP macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 186d0f24e1f6a964d3d046e9d47d513e8653f323

[Peter Jones]

These patches can still land for 2.11 but this work does not have to be tracked for that release

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32822
Subject: LU-9855 obdclass: simplify md_stats code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ee669b336570e41fd54df9ec658a11af49da533e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32822/
Subject: LU-9855 obdclass: simplify md_stats code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7739c8d351e89a82280420b44241b82c220af8f2

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33101
Subject: LU-9855 include: replace OBD_CHECK_DEV by obd_check_dev
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bbd55d14a946163767f1d60141d33f4b49cc0aff

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33101/
Subject: LU-9855 include: replace OBD_CHECK_DEV by obd_check_dev
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 32dbb80b0dcf6774fcab1f4d79bfc119d27a25a2

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34106
Subject: LU-9855 obd: use ldo_process_config for mdc and osc layer
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 54191c4139c4ef67ba910e5e9ef103be601a175f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34106/
Subject: LU-9855 obd: use ldo_process_config for mdc and osc layer
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d12959c69fd486054619d52dbb32d7ea91327f94

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36096
Subject: LU-9855 obd: Replace LPROCFS_CLIMP_CHECK with lprocfs_climp_check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3f6ace5eee1ff831dfda1ddc2cf51da7da92bab5

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36956
Subject: LU-9855 lustre: replace LPROCFS_CLIMP_CHECK()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 80f142a5ab8640631d3a86993d0828904c33b265

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36969
Subject: LU-9855 lustre: rename obd_device variables to obd
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 32a51a6d4e50114d844d346a6ac1070d634aec87

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36956/
Subject: LU-9855 lustre: replace LPROCFS_CLIMP_CHECK()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f4ce6b568b523060e71b17cf679c2b99d0038dbc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36969/
Subject: LU-9855 lustre: rename obd_device variables to obd
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cd5d04b3722e2edca02671ab5b8729070de20275

[Peter Jones]

It looks like all this work has landed - is it ok to close out the ticket?

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39595
Subject: LU-9855 lustre: use with_imp_locked() more broadly.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 550dd18c578c29bc95d6cb7edc18cb5aaa71355b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39595/
Subject: LU-9855 lustre: use with_imp_locked() more broadly.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 168ec247779f3ab743985bdbad605f8eacd8fc81

[Peter Jones]

Looks like all patches have landed