[LU-9859] libcfs simplification

• Status: Open
• Project: Lustre
• Affects Version/s: Lustre 2.11.0
• Fix Version/s: Upstream
• Type: Improvement
• Priority: Minor
• Reporter: James A Simmons
• Assignee: James A Simmons
• Resolution: Unresolved
• Labels: patch

Sub-Tasks

Key	Summary	Type	Status	Assignee
LU-12923	replace CLASSERT() with BUILD_BUG_ON()	Technical task	Resolved	Arshad Hussain

• Key: Summary
• Summary: Type
• Type: Status
• Status: Assignee

Description

Now that libcfs has been sorted out with user land we can look to simplify the code and use kernel function that already exist. Good example are prng.c or the cfs_alloc_array_* functions. Also only place in the linux directory only code that is needed to support various distros.

Issue Links

• is related to: LU-8703 rework CPU partition code
• is related to: LU-12838 ptlrpc watchdog ratelimiting is broken
• is related to: LU-14463 stack traces not being printed to con...
• is related to: LU-8304 libcfs_debug_dumplog calls potentiall...
• is related to: LU-12952 oops in cfs_trace_copyin_string
• is related to: LU-12923 replace CLASSERT() with BUILD_BUG_ON()
• is related to: LU-12511 Prepare lustre for adoption into the ...
• is related to: LU-4922 Fix cfs_str2mask to better deal with ...
• is related to: LU-8130 Migrate from libcfs hash to rhashtable
• is related to: LU-14290 Convert fault-injection framework to ...
• is related to: LU-14428 Convert tracefile to use ring_buffer ...
• is related to: LU-16796 Replace LASSERT_ATOMIC_* (atomic_t) w...
• is related to: LU-9019 Migrate lustre to standard 64 bit tim...
• is related to: LU-13258 Bind linux workqueues to specific core
• is related to: LU-14289 Restrict libcfs to compatibility code...

Comments

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30379
Subject: LU-9859 libcfs: replace cfs_size_* macros with linux kernel ALIGN
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 57c73dadd655a91618e474a543cbf8e93012d857

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30706
Subject: LU-9859 libcfs: delete libcfs/linux/libcfs.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f208cc3813eee86a1ac46228bdfa9ab2d7d593fe

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30706/
Subject: LU-9859 libcfs: delete libcfs/linux/libcfs.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cda0a8abf5bbfe0f3fc12454c1d3d8efdcbda17c

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30873
Subject: LU-9859 libcfs: merge UMP and SMP libcfs cpu header code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c3295ba9593418a08b939ef32ca81960ca33a464

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30873/
Subject: LU-9859 libcfs: merge UMP and SMP libcfs cpu header code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bd3023bf147a661e00394ddee0efc2b2ac2f7887

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32219
Subject: LU-9859 mdt: replace CLASSERT with BUILD_BUG_ON
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4ff56573ab2718f73b3604803e5c6b44e8904581

[John Hammond]

BUG_ON() and BUILD_BUG_ON() are just terrible. Positive statements are much easier to read than negative ones. Especially so for latent dyslexics liek myself. Some times the kernel folks are just wrong. This is even worse than replacing ptr == NULL with !ptr.

[James A Simmons]

Please see https://patchwork.kernel.org/patch/9551609 for why it was removed. CLASSERT is actually broken with clang. It might be horrible but sadly we have to deal with it at some point. We have a choice when to deal with it, now or later.

[John Hammond]

#define CLASSERT(cond) BUILD_BUG_ON(!(cond))

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32359
Subject: LU-9859 libcfs: rearrange placement of CPU partition management code.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8799a0ebd9b09c72c7d8204770b6de553f2f5259

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32359/
Subject: LU-9859 libcfs: rearrange placement of CPU partition management code.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 454a5f5c5496bdea667223a1608d885024f658af

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33018
Subject: LU-9859 libcfs: add watchdog for ptlrpc service threads.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7e4348edd614dba070a9dea332cb20a301505e6b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33018/
Subject: LU-9859 libcfs: add watchdog for ptlrpc service threads.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fc9de679a4c2294e0cd3b084c8f0dd473342a6b9

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34168
Subject: LU-9859 libcfs: use strim instead of cfs_trimwhite.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 166932b9da9e79e2543462c4b9397579c0425c9a

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34169
Subject: LU-9859 libcfs: use a workqueue for rehash work.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 44d8ed98de462295ff6952ac812cb59faff34461

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34170
Subject: LU-9859 libcfs: replace cfs_srand() calls with add_device_randomness().
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ec5a93a6f69cf678bb52f95b7301cd7ededac37d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34170/
Subject: LU-9859 libcfs: replace cfs_srand() calls with add_device_randomness().
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ed5acd09263b0bfbac1bc6b26bb6e366d14a8408

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34168/
Subject: LU-9859 libcfs: use strim instead of cfs_trimwhite.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ca91c215b00e405b9dad5b3fd3664bc131e168c9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34169/
Subject: LU-9859 libcfs: use a workqueue for rehash work.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5ce10d8850a3d104193a634ca6ee796299fd6270

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34466
Subject: LU-9859 libcfs: remove wi_data from cfs_workitem
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b72fb40b274ce6a2f140e2dbcc4372275bc3372b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34466/
Subject: LU-9859 libcfs: remove wi_data from cfs_workitem
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7eb7f852ba4cb642ef0d45842a0dc8cbd6f2024d

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35224
Subject: LU-9859 libcfs: deprecate libcfs_debug_vmsg2
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 930c2c001e5841428374e8c8c318bea2d96bbc38

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35225
Subject: LU-9859 libcfs: remove libcfs_debug_vmsg2
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d7e74fb7f782f2739e2b3cad169d1d7c1af4c1ca

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35234
Subject: LU-9859 libcfs: replace cfs_get_random_bytes calls with get_random_byte()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: db79519c146eb084f49dd83ddf995ba83f4904cc

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35272
Subject: LU-9859 libcfs: replace cfs_rand() with prandom_u32_max()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8f913fa7b686a3178ac905c3c1b08ac99fabff99

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35281
Subject: LU-9859 libcfs: fixed buffer overflow in IOC_LIBCFS_MARK_DEBUG
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 152b5aa716b7d55790be2347e4f0f388ee71ee4c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35224/
Subject: LU-9859 libcfs: deprecate libcfs_debug_vmsg2
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4b0c3835568b292c53f558af6c46c08508d6cde2

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35234/
Subject: LU-9859 libcfs: replace cfs_get_random_bytes calls with get_random_byte()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d05fee1919911e56f6ef7eb018c90ae19fa415aa

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35272/
Subject: LU-9859 libcfs: replace cfs_rand() with prandom_u32_max()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7a707d4828807b45aeca368e707c243ba68fa51f

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35350
Subject: LU-9859 libcfs: remove unnecessary cfs_block_allsigs() calls
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 63a5ce4fcdfb96f2e6df4513b2e1bb25cfde269a

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35351
Subject: LU-9859 libcfs: remove prng
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 85bdeb9f67e1a488a54298c2c56ecf5393d60186

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35410
Subject: LU-9859 libcfs: simplify linux-prim.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2d0b40e21a602f41929ab815bd4acc0def67ec47

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35411
Subject: LU-9859 libcfs: improve API and implementation of blocking signals.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d1121f988403f1a7d5f591829172493ab52c19b3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35225/
Subject: LU-9859 libcfs: remove libcfs_debug_vmsg2
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3ec13d260bf6b18dd741d38f16eaf5cf567b8aef

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35351/
Subject: LU-9859 libcfs: remove prng
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 406b1720df422cf0a020b7a0e529683e9f262672

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35567
Subject: LU-9859 libcfs: initialize bit_wait_table
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bb7b27e109068b9ec9fa7b34457283573b57ea54

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35574
Subject: LU-9859 libcfs: double copy bug
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 72260c4c411d735680e23d20dfb16aca3d795cdc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35567/
Subject: LU-9859 libcfs: initialize bit_wait_table
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 916643c4b8d136c9c96afa5cd21d1eb6030d148c

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35809
Subject: LU-9859 libcfs: switch to cpumask_var_t
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b8e4a397e9b4bbcfb6884d3627be3abbe87ebf25

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35847
Subject: LU-9859 libcfs: fix cfs_print_to_console()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b511136b8c949901ec5671bbe205692160197ee7

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35847/
Subject: LU-9859 libcfs: fix cfs_print_to_console()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 08ec9c8b6f5a1334fa7de822a50fd480b844884c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35809/
Subject: LU-9859 libcfs: switch to cpumask_var_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ebd79df9afd2411826dbd3fc354f95c2d745d4e7

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32219/
Subject: LU-9859 mdt: replace CLASSERT with BUILD_BUG_ON
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8f65b07e90be21242cb49493421dcd3081f6fbac

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35574/
Subject: LU-9859 libcfs: double copy bug
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2129145d96c85b05b300d450a788f2d7688dc23b

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36118
Subject: LU-9859 libcfs: move misc-device registration closer to related code.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 58393e1b33a974efb38a021bba9732809685ad97

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36304
Subject: LU-9859 libcfs: opencode cfs_cap_

{raise, lower, raised}

Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 05912e238f022faa8bf04d2b5cf0096d0770babf

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36118/
Subject: LU-9859 libcfs: move misc-device registration closer to related code.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 84ebd81d4295bc42fd78539aa1bca63a2b3a9295

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36510
Subject: LU-9859 libcfs: move remaining code from linux-module.c to module.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 87c7892974d22af16ef7522b38238f7fb25ad0f9

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36567
Subject: LU-9859 libcfs: Prevent harmless read underflow
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3340727ce97ae9c49e590dd92b4ae6da07e4585c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36304/
Subject: LU-9859 libcfs: opencode cfs_cap_

{raise,lower,raised}

Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b88ba023ca23992a4fb98f337534d2997fabaf44

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36510/
Subject: LU-9859 libcfs: move remaining code from linux-module.c to module.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4f18daa42192090b135606816bcb3a6dd8777f0a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36567/
Subject: LU-9859 libcfs: Prevent harmless read underflow
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 834341ee0de597c3004e6a11c696e3d7e337b1bc

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36991
Subject: LU-9859 lnet: convert selftest to use workqueues
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 368e17b26e5d664000b92e9ecb02a2f46e127fcc

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37191
Subject: LU-9859 libcfs: move files out of libcfs/linux
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8c8028dae330c8815aa6b7f85dddad6cd0e2b074

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37191/
Subject: LU-9859 libcfs: move files out of libcfs/linux
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 09a53f30e40e4897318698742f87cfe4f03d2e20

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37391
Subject: LU-9859 libcfs: support missing kernel functionality
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e7b9bc3960e5faabf30a8801b3c6ce9a8d790cd8

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37408
Subject: LU-9859 libcfs: move tracefile locking from linux-tracefile.c to tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5d92d7387a76e09e8d25cbf6699064b34ec3a746

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37519
Subject: LU-9859 libcfs: rename cfs_cpt_table to cfs_cpt_tab
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0dd926693d2a9101e55858ed03b8a0aa5cdbed2d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37408/
Subject: LU-9859 libcfs: move tracefile locking from linux-tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 649a76711efd1dc3d30d7069fac1afcb141b8239

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35350/
Subject: LU-9859 libcfs: remove unnecessary cfs_block_allsigs() calls
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8e877a6f5cc894d0c0ec283d63faff05f8d97fea

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37519/
Subject: LU-9859 libcfs: rename cfs_cpt_table to cfs_cpt_tab
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cc3643908d6c902db3d6c95647fff007bad0ff53

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37733
Subject: LU-9859 ptlrpc: change imp_refcount to refcount_t
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d500e841246718f63edf72d88a2cec7ad695a42c

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37736
Subject: LU-9859 libcfs: prepare for switch to container_of_safe()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 318f7f563f28d0a58b507da1dc828533ba84ac96

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35410/
Subject: LU-9859 libcfs: simplify linux-prim.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4bc21cc3dca028907d3dd2629a455c80b89c9130

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37776
Subject: LU-9859 lustre: remove current_pid() and current_comm()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e4fea928303440571cb669c7e1b7be5a4ee734f6

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37828
Subject: LU-9859 libcfs: always range-check libcfs_debug_mb setting.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4c57b58a2bbe79341c116d0be26d299b0e02bc34

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37829
Subject: LU-9859 libcfs: open code cfs_trace_max_debug_mb() into cfs_trace_set_debug_mb()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: dee93634d3c08fe90d1db04212d1b1731e52e3ce

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37776/
Subject: LU-9859 lustre: remove current_pid() and current_comm()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ee7ca785615f2da71932512d8545763836ef8197

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37733/
Subject: LU-9859 ptlrpc: change imp_refcount to refcount_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b1d50020c97cc66db5a6a506f20de1e1d733dacb

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37881
Subject: LU-9859 libcfs: remove conditional compilation from libcfs_cpu.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5df6abd75528bd4bcd1d3152b13cd27bd63f2527

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37736/
Subject: LU-9859 libcfs: prepare for switch to container_of_safe()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: da63a46c51e86953dc62db76b8fa4d1a0f1aef4d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35411/
Subject: LU-9859 libcfs: improve API and implementation of blocking signals.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ec1b20e72282d6a9407c350f0328bd4ce74b2352

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37828/
Subject: LU-9859 libcfs: always range-check libcfs_debug_mb setting.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8b78a3ffb5220330f41b4fa8576a05c4e017cfb1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37829/
Subject: LU-9859 libcfs: open code cfs_trace_max_debug_mb() into cfs_trace_set_debug_mb()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 721ae5993285a2ac30a20e89079c38df88c134f0

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38081
Subject: LU-9859 libcfs: make signal-blocking functions inline
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1b4be047c0b374eaf5b77b9a005f1322478f1395

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38211
Subject: LU-9859 libcfs: replace memory_presure funcitons by standard interfaces.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 93582a1efd9a76ae7fc7cf0aee8307d61b847da7

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38081/
Subject: LU-9859 libcfs: make signal-blocking functions inline
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c1e427e30eff515d1f7fd65e7d27ce747f1ffb9d

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38389
Subject: LU-9859 libcfs: hide struct cfs_cpt_table internals
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3fe2584bac0dcd41952c2ca46eb6ed2b13cb3884

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38390
Subject: LU-9859 libcfs: handle missing refcount.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bbc33e776f0eedd98b56316b3a7ec68269d6eaf4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38390/
Subject: LU-9859 libcfs: handle missing refcount.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6e1c48c4b7224f28b2aebcb372dc1156f09268f6

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37881/
Subject: LU-9859 libcfs: remove conditional compilation from libcfs_cpu.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 83a2dbe9e50d3a60312fa40f41052b23a3edb3ca

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38389/
Subject: LU-9859 libcfs: hide struct cfs_cpt_table internals
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e56b6a340d9ddfb3ee5cf4bd2b947fd63bcb9947

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38530
Subject: LU-9859 libcfs: discard cfs_block_sigsinv()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 10dc54f94b029625afea8618fbb36edc5bc0f881

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37391/
Subject: LU-9859 libcfs: add support for Xarray
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 84e12028be9a13a5f702ce04adfd55d94d8a96ef

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38574
Subject: LU-9859 libcfs: initialize bit_wait_table
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: f80d996f49858371f62665156032e7caf19a33cb

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38211/
Subject: LU-9859 libcfs: replace memory_presure functions by standard interfaces
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a35d4814f8444ec71c97377e1c276945fa31fc1b

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38601
Subject: LU-9859 libcfs: move tcd locking across to tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 25927e6d646cb8d3720c04c18b42d15cb28b364c

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38602
Subject: LU-9859 libcfs: merge linux-debug.c into debug.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d4dc8f791b09c68452f39981b2a8c0027a51da0b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38530/
Subject: LU-9859 libcfs: discard cfs_block_sigsinv()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e82516955fdfbcad390f2fc36a84f24ec3b42a69

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38601/
Subject: LU-9859 libcfs: move tcd locking across to tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b0d950a8e42f9458829ce5746619e7fc48c345a7

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38673
Subject: LU-9859 libcfs: discard libcfs_prim.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 85b21393429c5bfd53119d7b4b1769d2d3548da0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38574/
Subject: LU-9859 libcfs: initialize bit_wait_table
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: d2cbe62fd1b51dabb65486a2e535203591d5a165

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38602/
Subject: LU-9859 libcfs: merge linux-debug.c into debug.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ae0704381efcebbbe35f56e1815f34476154905e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38673/
Subject: LU-9859 libcfs: discard libcfs_prim.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e8347675d0649252f74156362a8bd32330dfed45

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38804
Subject: LU-9859 libcfs: merge linux-tracefile.c into tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 35bf4f8855350cc01c1f01cb36a4653f601155d3

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38810
Subject: LU-9859 libcfs: Fix using smp_processor_id() in preemptible context
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9590f58a5c40f33f436f4e8d81d6097c7f6753e0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38804/
Subject: LU-9859 libcfs: merge linux-tracefile.c into tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b2397996ec0784dd361da60de1826e61c7f631b7

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38913
Subject: LU-9859 libcfs: remove cfs_trace_refill_stack()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fe0a0133ce910922dee6e09546e4268e52534bd0

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38914
Subject: LU-9859 libcfs: move cfs_trace_data data to tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a1ba54cf934a73b95da052fc8c317e7422f06188

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38981
Subject: LU-9859 libcfs: move tgt_descs to standard Linux bitmaps.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 866d3963f10facd8ad1b89863f6fe9ddd6b62966

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38810/
Subject: LU-9859 libcfs: Fix using smp_processor_id() in preemptible context
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0aeab4deb5c6deb93eb38af281e1bb696fcd239b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38913/
Subject: LU-9859 libcfs: remove cfs_trace_refill_stack()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9dfbed6fa33dfcd69afa3383f20c3973215e8000

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38914/
Subject: LU-9859 libcfs: move cfs_trace_data data to tracefile.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9e83e05ebc20356d9b2c429b95ee003fb460760c

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39116
Subject: LU-9859 libcfs: cleanup tracefile.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 63111eae4452591f316539467d0683e45853e03d

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39117
Subject: LU-9859 libcfs: fold cfs_tracefile_*_arch into their only callers.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 533c0275cc57249545885bdc0d1b79a2dfe422f4

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39118
Subject: LU-9859 libcfs: resolve debug.c checkpatch issues
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f101c5cdcac76ff217f815d3982b73fecfe3e475

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39132
Subject: LU-9859 libcfs: don't call unshare_fs_struct()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: af964df292096cb053e31256db438bfbab84d7e8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38981/
Subject: LU-9859 libcfs: move tgt_descs to standard Linux bitmaps.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2d2dac3ae77a3cbdc505328b6cbf648323a0795c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39117/
Subject: LU-9859 libcfs: fold cfs_tracefile_*_arch into their only callers.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 068cf5c7cd29cc1c27effb71ff9b511d14207147

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39116/
Subject: LU-9859 libcfs: cleanup tracefile.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 03d1cdb06371a6d6e1adaacaa6c3f7d854b4b608

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39132/
Subject: LU-9859 libcfs: don't call unshare_fs_struct()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9013eb2bb5492b1e8321d0ed534bee566f19627b

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39276
Subject: LU-9859 libcfs: rename CFS_TCD_TYPE_MAX to CFS_TCD_TYPE_CNT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fd6c630704cce50ccfc28d60de224cf6b011efd0

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39293
Subject: LU-9859 libcfs: use wait_event_timeout() in tracefiled().
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6833305a24f878d4760511f205fe6c8d24d78248

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39294
Subject: LU-9859 libcfs: don't save journal_info in dumplog thread.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 06328f4e58305265d03da2187f7b04569c1024ae

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39276/
Subject: LU-9859 libcfs: rename CFS_TCD_TYPE_MAX to CFS_TCD_TYPE_CNT
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1ccf112bd2a06db4d98255fd02b07d9edfcf4376

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39294/
Subject: LU-9859 libcfs: don't save journal_info in dumplog thread.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2eba3f9c3de506d0802d401dda5f45033b96587e

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39668
Subject: LU-9859 libcfs: discard TCD_MAX_TYPES
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cddc8ee2cce91d66d44f98b6558af81a91995dba

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39875
Subject: LU-9859 libcfs: replace all CFS_CAP_* macros with CAP_*
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9dfca67329f698bed6306c9eee1125aa0b26e969

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/39876
Subject: LU-9859 lod: use linux kernel bitmap API
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 26fe36f8d29c7031b17c390aaf337d4f923f2a78

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40334
Subject: LU-9859 libcfs: remove wi_data from cfs_workitem
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 8620217630aa374147b6f721c7ae46fd6c0a4494

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40339
Subject: LU-9859 libcfs: use a workqueue for rehash work.
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 7f25baf59f49bfe60852c9923e7907249b1e06c9

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41670
Subject: LU-9859 tracefile: convert list_for_each_entry_safe() to while(!list_empty())
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9740f03c81c409f6c7b7b6c8f4e33a81862abc21

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41671
Subject: LU-9859 libcfs: give different tcd_lock types different classes.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c08ab73c2b940a97d6052b7e121c394bb203b1c9

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41672
Subject: LU-9859 libcfs: use wait_event_timeout() in tracefiled().
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a6203705dcfe02efefe6bcc39af3a69a1fbded78

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41673
Subject: LU-9859 libcfs: discard cfs_trace_allocate_string_buffer()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 28b36967a8ee1cd81cbc56de059f8dac0d26863c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39875/
Subject: LU-9859 libcfs: replace all CFS_CAP_* macros with CAP_*
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a076975f9fed44e2b3a8b516aa7fe2ee6fbdb2bb

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39876/
Subject: LU-9859 lod: use linux kernel bitmap API
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: dd15646cc557357af7f8751dd136293b12588ce4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39668/
Subject: LU-9859 libcfs: discard TCD_MAX_TYPES
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bf7f08479fa28fc4c1a0513d4eb75f91c7577227

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/39293/
Subject: LU-9859 libcfs: use wait_event_timeout() in tracefiled().
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0269ac4a0069b0e4bd5b8a3bd028d4804bb2c128

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41783
Subject: LU-9859 libcfs: remove cfs_capable
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c35c22818608b4729f376c5f03ac277db45c627b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41670/
Subject: LU-9859 tracefile: convert list_for_each_entry_safe() to while(!list_empty())
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4ba20d4c211525fbc800eefea0b8f53b64bc48bf

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41938
Subject: LU-9859 libcfs: remove linux-curproc.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 752fc8ea0c0252456472842544fb40e80533385a

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41957
Subject: LU-9859 libcfs: simplify capability dropping.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7a75e0d4aa4702719f9d8bef87e30065ceb13f74

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41783/
Subject: LU-9859 libcfs: remove cfs_capable
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e34fdc5479037bf7b6efed3239362585a1c1ff3b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41938/
Subject: LU-9859 libcfs: remove linux-curproc.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f6cd6a880cd03fd1d3fd3d8e03133f0835ad275d

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43171
Subject: LU-9859 libcfs: discard cfs_cap_t, use kernel_cap_t
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f41129523693bc3a8812d19b24e61131a17c4d0b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41957/
Subject: LU-9859 libcfs: simplify capability dropping.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ee06281d89871c46310ee4b0585ee4489d2c2f3f

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/44309
Subject: LU-9859 lnet: fold lprocfs_call_handler functionality into lnet_debugfs_*
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6600683c3632136f1eecb431cad522f0977d380c

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/44332
Subject: LU-9859 libcfs: make lnet_debugfs_symlink_def local to libcfs/modules.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 83f1776d816b60991330467f3151edd651630a0f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/44332/
Subject: LU-9859 libcfs: make lnet_debugfs_symlink_def local to libcfs/modules.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 592d9a737bc19fbf0d3419ede32068cf8bf7677e

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/44529
Subject: LU-9859 libcfs: Prevent harmless read underflow
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 99baf09030abe547445dcc106fceed5efa926041

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/43171/
Subject: LU-9859 libcfs: discard cfs_cap_t, use kernel_cap_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0a6beb2a50f7a4f953a258b63c2ea1fbfd373092

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/44580
Subject: LU-9859 mdd: unwind md_capable()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a9dd6757b05d909f0d455fec2c6216158f3cf21b

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/44581
Subject: LU-9859 libcfs: change libcfs_log_* functions to inline
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0928e88c6c0a98d665883522d4a0e872d6a8f6e7

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/44309/
Subject: LU-9859 lnet: fold lprocfs_call_handler functionality into lnet_debugfs_*
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aa5d081237947263597c0a9d39463d101508adc9

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/44581/
Subject: LU-9859 libcfs: change libcfs_log_* functions to inline
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3769245cad0775816b653253e497e57b7500033c

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/45584
Subject: LU-9859 gss: replace cfs_size_roundXX macros.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3c915838e5138121bc4c93d984a9537b2e9b6891

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/45584/
Subject: LU-9859 gss: replace cfs_size_roundXX macros.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a43693fa7a3b21965f3f8fd25d120ae932c00d21

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/44580/
Subject: LU-9859 mdd: unwind md_capable()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 993808978803771748b2c4bb3982baf01482ce5e

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/46251
Subject: LU-9859 libcfs: add "default" keyword for debug mask
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8faa4543021ba1e41f745aa44dd603b98032ed44

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/47579
Subject: LU-9859 lfsck: use Linux bitmap API for ltd_tgts
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 030df283745ddce7c037a34a0ea86bcb433bc2a9

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/46251/
Subject: LU-9859 libcfs: add "default" keyword for debug mask
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4c9a5762413638cc630b1facfb565dcd765fce1e

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/47579/
Subject: LU-9859 lfsck: use Linux bitmap API
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d4ef65c41c3b1bd88f3e9be8b523175417a410ca

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/48222
Subject: LU-9859 libcfs: remove Lustre specific bitmap handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0aba09e889734b1eba03e81edcc5c62a81cf0f71

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/48222/
Subject: LU-9859 libcfs: remove Lustre specific bitmap handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 286924f8a0f6be740e8436943834cb904290e7ed

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49872
Subject: LU-9859 libcfs: add "default" keyword for debug mask
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: c451b4bf28f0ced46cdaa5ce2cfda28e39339768

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50376
Subject: LU-9859 libcfs: discard MKSTR() macro
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: dffac169b6756bbafe641a19368c63d1c4490bec

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50412
Subject: LU-9859 libcfs: move RESV_PORT definitions to lnet/lib-lnet.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 37cb416567e3114ac81265040d0ac9eb1a18e06c

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50462
Subject: LU-9859 libcfs: remove workitem.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 09efbecb1dd4e8784e1877dcad7be71d2261f0ac

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50376/
Subject: LU-9859 libcfs: discard MKSTR() macro
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 80d8eb2f45adc1b8c327c356be018c98922ba734

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50412/
Subject: LU-9859 libcfs: move RESV_PORT definitions to lnet/lib-lnet.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 974193b03a163c6046e2b5d3288b15d4aa887e17

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50545
Subject: LU-9859 libcfs: use round_up directly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 482ba1677ad25d2d77804c2d553c0b3dae4d8ede

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50832
Subject: LU-9859 libcfs: move percpt_lock into lnet
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a7af60c7cc02f4b3dfeca26cbb5391845e8be8b2

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50833
Subject: LU-9859 lnet: move ioctl device to lnet
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c97402ec3153c4d9270fbaf9e6cf8feab515c1e4

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50834
Subject: LU-9859 libcfs: move cfs_expr_list_print to nidstrings.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d05249ed07837f497778b1d457b9f84d30a07255

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50835
Subject: LU-9859 ptlrpc: begin simplifying parsing in nrs_tbf
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 18295177d28909bcf41c2121608c867970b8981d

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50836
Subject: LU-9859 ptlrpc: simplify nrs_tbf_check_id_value and callers
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2abe9e92853c431ddfcd1f68af21fda9f57be9dc

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50837
Subject: LU-9859 ptlrpc: simplify nrs_tbf_opcode_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 572598289178a53554d5f9c4e1e3fe729b1569ea

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50838
Subject: LU-9859 ptlrpc: simplify nrs_tbf_jobid_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6ab2f30bc3e37458ba5c22a4e5202ad91f9bdb6a

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50839
Subject: LU-9859 llite: simplify parsing in pcc_conds_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c4a005644112804fd661069e94f16c58734bcb92

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50840
Subject: LU-9859 llite: simplify pcc_fname_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7e954a7a8072ac84417820ed1bca7fdbfa050947

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50841
Subject: LU-9859 lnet: simplify cfs_parse_nidlist()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 26473d8aac5809c66dc351fcc14343ce4931ffdf

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50842
Subject: LU-9859 lnet: simplifiy cfs_ip_addr_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a8b93bb79ddebbf81a92df7d558a8be9a3a44248

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50843
Subject: LU-9859 lnet: simplify cfs_expr_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 279fec465f5e2554f72480e5bf88fb893414801b

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50844
Subject: LU-9859 libcfs: discard cfs_gettok and cfs_str2num_check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c25fa2893de4ee714ee6824a666f84a85b50019e

[Gerrit Updater]

"Neil Brown <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50845
Subject: LU-9859 lnet: move expr parsing from libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b6555d24a347f969d05e4dda8f1df45108e403d1

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51009
Subject: LU-9859 libcfs: remove cfs_size_round()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 834b0fe75965d323e76cb1bfed70e4576a7368ad

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/36991/
Subject: LU-9859 lnet: convert selftest to use workqueues
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 51dd6269c91dab7543cd9dfd1848c983efa6db36

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50462/
Subject: LU-9859 libcfs: remove workitem.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1782884fa247da0c1400ee6307596b64d6aaa440

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49872/
Subject: LU-9859 libcfs: add "default" keyword for debug mask
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 6d40d733e093a736ee40fb9fa281615b81f8c7be

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50545/
Subject: LU-9859 libcfs: use round_up directly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 20683c0d6c3e7d04293238d0a68e862c9bc46d40

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50834/
Subject: LU-9859 libcfs: move cfs_expr_list_print to nidstrings.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 531d7b630e962a33f7b910a600b6f5d30642f7be

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50832/
Subject: LU-9859 libcfs: move percpt_lock into lnet
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c4e2563ff3bfa84ab7558c2aced32445da543ef6

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50833/
Subject: LU-9859 lnet: move ioctl device to lnet
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2d4d7febb124686d4a268197dfb36c9a478f8960

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50835/
Subject: LU-9859 ptlrpc: simplifying expression parsing in nrs_tbf
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 44cc78222d51346899436dee01c252bf18ee3e77

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50836/
Subject: LU-9859 ptlrpc: simplify nrs_tbf_check_id_value and callers
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d5112af7369e3110ea52c9c05fb6179dd67c767d

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50838/
Subject: LU-9859 ptlrpc: simplify nrs_tbf_jobid_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7d27634fe0ea738ed825374088cead8ba060fbb3

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50839/
Subject: LU-9859 llite: simplify parsing in pcc_conds_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d6136c5df6267712f824db74415cd26b6d8f19ef

[Alex Zhuravlev]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50833/
Subject: LU-9859 lnet: move ioctl device to lnet

with this patch landed some debug marks seem to get lost.
I used to track test script's health using those, but now it's not possible. for example, in conf-sanity I get this only:

[   52.211151] Lustre: DEBUG MARKER: == conf-sanity test 0: single mount setup ================ 11:01:22 (1689850882)

while the script itself had reached test 9:

== conf-sanity test 9: test ptldebug and subsystem for mkfs ========================================================== 11:14:18 (1689851658)

[James A Simmons]

How is sanity 60d passing? Can we have a diff to the test suite so we can reproduce your issues.

[Alex Zhuravlev]

> How is sanity 60d passing? Can we have a diff to the test suite so we can reproduce your issues.
sanity/60d passes fine.

I used ONLY=0-10 conf-sanity for testing. clean master branch:

$ grep MARK.*== /tmp/tmp.NRheCxLFD3/serial.txt 
[   26.223048] Lustre: DEBUG MARKER: == conf-sanity test 0: single mount setup ================ 08:30:27 (1690446627)
[  671.513515] Lustre: DEBUG MARKER: == conf-sanity test 10a: find lctl param broken symlinks ========================================================== 08:41:12 (1690447272)
[  695.136877] Lustre: DEBUG MARKER: == conf-sanity test complete, duration 692 sec =========== 08:41:36 (1690447296)

the same conf-sanity with "LU-9859 lnet: move ioctl device to lnet" reverted:

[alexey@rz ~]$ grep MARK.*== /tmp/tmp.YdwzpYe8CE/serial.txt 
[   25.255193] Lustre: DEBUG MARKER: == conf-sanity test 0: single mount setup ================ 08:30:17 (1690446617)
[   42.532709] Lustre: DEBUG MARKER: == conf-sanity test 1: start up ost twice (should return errors) ========================================================== 08:30:34 (1690446634)
[   72.423932] Lustre: DEBUG MARKER: == conf-sanity test 2: start up mds twice (should return err) ========================================================== 08:31:04 (1690446664)
[   94.203070] Lustre: DEBUG MARKER: == conf-sanity test 3: mount client twice (should return err) ========================================================== 08:31:26 (1690446686)
[  116.883153] Lustre: DEBUG MARKER: == conf-sanity test 4: force cleanup ost, then cleanup === 08:31:48 (1690446708)
[  165.722055] Lustre: DEBUG MARKER: == conf-sanity test 5a: force cleanup mds, then cleanup == 08:32:37 (1690446757)
[  205.912471] Lustre: DEBUG MARKER: == conf-sanity test 5b: Try to start a client with no MGS (should return errs) ========================================================== 08:33:17 (1690446797)
[  299.191296] Lustre: DEBUG MARKER: == conf-sanity test 5c: cleanup after failed mount (bug 2712) (should return errs) ========================================================== 08:34:51 (1690446891)
[  305.612684] Lustre: DEBUG MARKER: == conf-sanity test 5d: mount with ost down ============== 08:34:57 (1690446897)
[  433.151871] Lustre: DEBUG MARKER: == conf-sanity test 5e: delayed connect, don't crash (bug 10268) ========================================================== 08:37:05 (1690447025)
[  456.989830] Lustre: DEBUG MARKER: == conf-sanity test 5f: mds down, cleanup after failed mount (bug 2712) ========================================================== 08:37:28 (1690447048)
[  457.045524] Lustre: DEBUG MARKER: == conf-sanity test 5g: handle missing debugfs =========== 08:37:29 (1690447049)
[  457.222051] Lustre: DEBUG MARKER: == conf-sanity test 5h: start mdt failure at mdt_fs_setup() ========================================================== 08:37:29 (1690447049)
[  485.312693] Lustre: DEBUG MARKER: == conf-sanity test 5i: start mdt failure at mdt_quota_init() ========================================================== 08:37:57 (1690447077)
[  521.562925] Lustre: DEBUG MARKER: == conf-sanity test 6: manual umount, then mount again === 08:38:33 (1690447113)
[  544.272564] Lustre: DEBUG MARKER: == conf-sanity test 7: manual umount, then cleanup ======= 08:38:56 (1690447136)
[  566.972597] Lustre: DEBUG MARKER: == conf-sanity test 8: double mount setup ================ 08:39:18 (1690447158)
[  590.723481] Lustre: DEBUG MARKER: == conf-sanity test 9: test ptldebug and subsystem for mkfs ========================================================== 08:39:42 (1690447182)
[  670.891275] Lustre: DEBUG MARKER: == conf-sanity test 10a: find lctl param broken symlinks ========================================================== 08:41:03 (1690447263)
[  695.687611] Lustre: DEBUG MARKER: == conf-sanity test complete, duration 693 sec =========== 08:41:28 (1690447288)

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50843/
Subject: LU-9859 lnet: simplify cfs_expr_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 22c8093c4e96039567f2d1f741d939c01f1a8cbd

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50837/
Subject: LU-9859 ptlrpc: simplify nrs_tbf_opcode_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a1dc44aef0382be712da7a9579876b6bbc48f815

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50840/
Subject: LU-9859 llite: simplify pcc_fname_list_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c0e881a8e10f4bf980b5b704c029c2bce74946ec

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50841/
Subject: LU-9859 lnet: simplify cfs_parse_nidlist()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c08795f9526e8904a45ea9a8517f2f3771a41d18

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51009/
Subject: LU-9859 libcfs: remove cfs_size_round()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6481328c1c996172aa3333fc27f1b0d046e99eb0

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52010
Subject: LU-9859 libcfs: move kernel specific code out of libcfs core
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 12579c8248b8e9039819ee6529e5dbd43a92e678

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50842/
Subject: LU-9859 lnet: simplifiy cfs_ip_addr_parse()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4df4ad20dea4c4c9e513d6e1e5384b974e380f65

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50844/
Subject: LU-9859 libcfs: discard cfs_gettok and cfs_str2num_check
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 88141538c475b99fe911c54a60e5c004c5296a55

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52700
Subject: LU-9859 libcfs: refactor libcfs initialization.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8eaa118d2e05a46994bccaec751d8cef0047f224

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52701
Subject: LU-9859 libcfs: migrate libcfs_mem.c to lnet/lib-mem.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1b4b9d5bbc315659e4c6bb2a1cb23a9cc4d910d6

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52010/
Subject: LU-9859 libcfs: move kernel specific code out of libcfs core
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8754693fe6ddac4b74e27800a05d5aea00bb0359

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52923
Subject: LU-9859 lnet: move CPT handling to LNet
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 012bbbb81cf9e8c77b2e2eeed611c59d1c4aa919

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52701/
Subject: LU-9859 libcfs: migrate libcfs_mem.c to lnet/lib-mem.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 24d515367f44de6b92b453cc9a1c8384e52b5e3f

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52700/
Subject: LU-9859 libcfs: refactor libcfs initialization.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f3494a6e9ffeb82bf1b34e557b4cfda1eaf8ef9d

[Vladimir Saveliev]

Subject: LU-9859 libcfs: refactor libcfs initialization.

With this patch bash /usr/lib64/lustre/tests/llmount.sh (single node setup, vmware virtual machine, CentOS Stream release 8) crashes:

[   41.240485] libcfs: loading out-of-tree module taints kernel.
[   41.247560] Key type ._llcrypt registered
[   41.249128] Key type .llcrypt registered
[   41.506114] BUG: unable to handle kernel NULL pointer dereference at 00000000000000cc
[   41.508996] PGD 8000000004bc1067 P4D 8000000004bc1067 PUD 1988d067 PMD 0
[   41.511787] Oops: 0000 [#1] SMP PTI
[   41.513298] CPU: 1 PID: 3744 Comm: lctl Tainted: G           O     --------- -  - 4.18.0-477.15.1.el8.x86_64 #2
[   41.516934] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 11/12/2020
[   41.521529] RIP: 0010:cfs_trace_lock_tcd+0x6/0x80 [libcfs]
[   41.523332] Code: e9 48 89 e7 49 c7 c0 c0 86 48 c0 be 00 00 04 00 e8 3f fd ff ff 48 c7 c7 a0 0b 49 c0 e8 7b e1 67 d9 0f 1f 00 0f 1f 44 00 00 53 <0f> b7 47 4c 66 83 f8 02 77 43 48 89 fb 74 1a 66 83 f8 01 74 28 85
[   41.529423] RSP: 0018:ffffa416c1157c60 EFLAGS: 00010202
[   41.530802] RAX: 0000000000000001 RBX: 0000000000000080 RCX: 0000000000000000
[   41.533363] RDX: 0000000080000000 RSI: 0000000000000000 RDI: 0000000000000080
[   41.536707] RBP: ffffa416c1157d90 R08: 00000000ffffffff R09: 00000000130e0580
[   41.540222] R10: ffffa416c1157da8 R11: 0000000000000001 R12: ffffffffc0498b00
[   41.543573] R13: 0000000000000000 R14: 0000000000000080 R15: 0000000000000000
[   41.546175] FS:  00007f28a90eb740(0000) GS:ffff93e76b040000(0000) knlGS:0000000000000000
[   41.549481] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   41.551648] CR2: 00000000000000cc CR3: 00000000235cc002 CR4: 00000000003706e0
[   41.555378] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   41.558481] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[   41.561120] Call Trace:
[   41.562149]  libcfs_debug_msg+0x100/0xb10 [libcfs]
[   41.564215]  ? terminate_walk+0xd0/0xf0
[   41.565779]  ? filename_lookup.part.64+0xe0/0x170
[   41.568254]  ? libcfs_debug_subsys2str+0x30/0x30 [libcfs]
[   41.571316]  ? libcfs_debug_subsys2str+0x30/0x30 [libcfs]
[   41.573735]  ? cfs_str2mask+0x332/0x340 [libcfs]
[   41.575703]  cfs_str2mask+0x332/0x340 [libcfs]
[   41.577523]  ? libcfs_debug_subsys2str+0x30/0x30 [libcfs]
[   41.580080]  libcfs_debug_str2mask+0xe8/0x190 [libcfs]
[   41.582512]  proc_dobitmasks+0x108/0x150 [libcfs]
[   41.584494]  lnet_debugfs_write+0x3f/0x70 [libcfs]
[   41.586557]  full_proxy_write+0x53/0x80
[   41.588260]  vfs_write+0xa5/0x1b0
[   41.589664]  ksys_write+0x4f/0xb0
[   41.591081]  do_syscall_64+0x5b/0x1b0

It looks like tcd is NULL in:

static inline struct cfs_trace_cpu_data *
cfs_trace_get_tcd(void)
{
        struct cfs_trace_cpu_data *tcd =
                &(*cfs_trace_data[cfs_trace_buf_idx_get()])[get_cpu()].tcd;

        cfs_trace_lock_tcd(tcd, 0);

        return tcd;
}

All is ok if this patch is reverted.

[James A Simmons]

I also test on a single node for Ubuntu and didn't see this. Did you change anything in your cfg/local.sh file to expose this bug? Sounds like someone is trying to print a debug message before libcfs debugging is setup.

[Vladimir Saveliev]

Did you change anything in your cfg/local.sh file to expose this bug?

It appeared after update from "New tag 2.15.59" to "Revert "LU-17131 ldiskfs: el9.2 encdata and filename-encode".

Somehow it eventually disappeared.
However, this has been also spotted on automated testing system:

[21171.870650] Lustre: Lustre: Build Version: 2.15.59_32_g1bb972b
[21171.928601] LNet: Using FastReg for registration
[21171.993601] LNet: Added LNI 192.168.102.20@o2ib [8/256/0/180]
[21172.240786] Lustre: Echo OBD driver; http://www.lustre.org/
[21186.068097] Lustre: DEBUG MARKER: fre0220: executing wait_import_state_mount FULL mdc.lustre-MDT0000-mdc-*.mds_server_uuid
[21186.993751] Lustre: DEBUG MARKER: fre0220: executing wait_import_state_mount FULL mdc.lustre-MDT0001-mdc-*.mds_server_uuid
[21187.929835] Lustre: DEBUG MARKER: fre0220: executing wait_import_state_mount FULL mdc.lustre-MDT0002-mdc-*.mds_server_uuid
[21188.850020] Lustre: DEBUG MARKER: fre0220: executing wait_import_state_mount FULL mdc.lustre-MDT0003-mdc-*.mds_server_uuid
[21194.566164] Lustre: DEBUG MARKER: fre0220: executing wait_import_state_mount (FULL|IDLE) osc.lustre-OST0000-osc-[-0-9a-f]*.ost_server_uuid
[21247.718136] Lustre: DEBUG MARKER: fre0220: executing unload_modules_local
[21248.017247] LNet: 277562:0:(lib-ptl.c:956:lnet_clear_lazy_portal()) Active lazy portal 0 on exit
[21249.101958] LNet: Removed LNI 192.168.102.20@o2ib
[21249.307129] Key type .llcrypt unregistered
[21249.317131] Key type ._llcrypt unregistered
[21301.274884] Key type ._llcrypt registered
[21301.278217] Key type .llcrypt registered
[30168.281419] BUG: unable to handle kernel NULL pointer dereference at 00000000000003cc
[30168.286373] PGD 0 P4D 0 
[30168.287238] Oops: 0000 [#1] SMP PTI
[30168.288290] CPU: 7 PID: 388777 Comm: modprobe Kdump: loaded Tainted: G           OE    ---------r-  - 4.18.0-348.20.1.el8_5.x86_64 #1
[30168.291221] Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
[30168.292748] RIP: 0010:cfs_trace_lock_tcd+0x6/0x70 [libcfs]
[30168.294199] Code: e9 48 89 e7 49 c7 c0 c0 d8 a5 c0 be 00 00 04 00 e8 5f fd ff ff 48 c7 c7 f0 5d a6 c0 e8 13 3b 4a ee 0f 1f 00 66 66 66 66 90 53 <0f> b7 47 4c 66 83 f8 02 77 37 48 89 fb 74 16 66 83 f8 01 74 20 85
[30168.298429] RSP: 0018:ffffb19a40ba3b60 EFLAGS: 00010202
[30168.299802] RAX: 0000000000000007 RBX: 0000000000000380 RCX: 0000000000000000
[30168.301508] RDX: 0000000080000000 RSI: 0000000000000000 RDI: 0000000000000380
[30168.303229] RBP: ffffb19a40ba3c90 R08: ffffb19a40ba3ce8 R09: ffff9a6dfffd2000
[30168.304929] R10: ffffb19a40ba3cb0 R11: fffff5fc84d55c08 R12: ffffffffc0b205c0
[30168.306741] R13: 0000000000000000 R14: 0000000000000380 R15: 0000000000000000
[30168.309129] FS:  00007f2de2fe5740(0000) GS:ffff9a6dfbdc0000(0000) knlGS:0000000000000000
[30168.311474] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[30168.313287] CR2: 00000000000003cc CR3: 0000000130abe000 CR4: 00000000000406e0
[30168.315421] Call Trace:
[30168.316564]  libcfs_debug_msg+0x100/0xb00 [libcfs]
[30168.318195]  ? __wake_up_common_lock+0x89/0xc0
[30168.319677]  ? netlink_broadcast_filtered+0x145/0x400
[30168.321298]  ? 0xffffffffc0b4a000
[30168.322538]  ? lnet_init+0x62/0x1000 [lnet]
[30168.323959]  lnet_init+0x62/0x1000 [lnet]
[30168.325348]  do_one_initcall+0x46/0x1d0
[30168.326447]  ? do_init_module+0x22/0x220
[30168.327550]  ? kmem_cache_alloc_trace+0x131/0x270
[30168.328781]  do_init_module+0x5a/0x220
[30168.329841]  load_module+0x14c5/0x17f0
[30168.330886]  ? __do_sys_finit_module+0xa8/0x110
[30168.332065]  __do_sys_finit_module+0xa8/0x110
[30168.333216]  do_syscall_64+0x5b/0x1a0
[30168.334263]  entry_SYSCALL_64_after_hwframe+0x65/0xca
[30168.335533] RIP: 0033:0x7f2de1fb852d
[30168.336540] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2b 79 2c 00 f7 d8 64 89 01 48
[30168.340556] RSP: 002b:00007ffe6a6ca438 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
[30168.342303] RAX: ffffffffffffffda RBX: 000056352b5e2420 RCX: 00007f2de1fb852d
[30168.343956] RDX: 0000000000000000 RSI: 000056352b5df8f0 RDI: 0000000000000000
[30168.345599] RBP: 000056352b5df8f0 R08: 0000000000000000 R09: 0000000000000050
[30168.347250] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
[30168.348885] R13: 000056352b5e23c0 R14: 0000000000040000 R15: 0000000000000000
[30168.350529] Modules linked in: lnet(OE+) libcfs(OE) rpcrdma ib_srpt ib_isert iscsi_target_mod target_core_mod ib_iser libiscsi scsi_transport_iscsi rdma_rxe ip6_udp_tunnel udp_tunnel rdma_ucm rdma_cm iw_cm ib_cm ib_uverbs ib_core rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace fscache intel_rapl_msr intel_rapl_common crct10dif_pclmul crc32_pclmul cirrus drm_kms_helper ghash_clmulni_intel syscopyarea sysfillrect sysimgblt fb_sys_fops drm virtio_balloon pcspkr joydev i2c_piix4 sunrpc binfmt_misc ext4 mbcache jbd2 ata_generic ata_piix libata crc32c_intel virtio_blk serio_raw e1000 [last unloaded: libcfs]
[30168.362036] CR2: 00000000000003cc

[Vladimir Saveliev]

Did you change anything in your cfg/local.sh file to expose this bug?

It seems that something got broken with libcfs module parameters.
I have libcfs_debug defined in /etc/modprobe.d/lustre.conf:

[root@vmcentos7-1 ~]# cat /etc/modprobe.d/lustre.conf
options lnet networks=tcp0(ens33)
options libcfs libcfs_debug=33965841

Then with

[root@vmcentos7-1 ~]# modprobe libcfs
[root@vmcentos7-1 ~]# rmmod libcfs

I get:

[   50.390835] BUG: unable to handle kernel NULL pointer dereference at 00000000000000cc
[   50.393177] IP: [<ffffffffc07933fa>] cfs_trace_lock_tcd+0xa/0x80 [libcfs]
...
[   50.422078] CPU: 1 PID: 2517 Comm: rmmod Kdump: loaded Tainted: G           OE  ------------   3.10.0-1160.88.1.el7.x86_64 #4
...
[   50.446143] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[   50.447885] Call Trace:
[   50.448517]  [<ffffffffc0793837>] libcfs_debug_msg+0xd7/0xa30 [libcfs]
[   50.449904]  [<ffffffff9d5621ed>] ? call_rcu_sched+0x1d/0x30
[   50.450999]  [<ffffffff9d680af1>] ? mnt_get_count+0x51/0x70
[   50.452449]  [<ffffffff9d688935>] ? simple_release_fs+0x45/0x50
[   50.453652]  [<ffffffffc07a1692>] ? libcfs_exit+0x27/0x995 [libcfs]
[   50.455271]  [<ffffffffc07a1706>] libcfs_exit+0x9b/0x995 [libcfs]
[   50.456848]  [<ffffffff9d52329e>] SyS_delete_module+0x19e/0x320

[James A Simmons]

Thanks. Let me try to reproduce this problem.

[James A Simmons]

Yes I can reproduce it. Also patch https://review.whamcloud.com/c/fs/lustre-release/+/41664 resolves this