[#LU-987] Fail to create ldisk rpms RHEL5

[LU-987] Fail to create ldisk rpms RHEL5 Created: 12/Jan/12 Updated: 09/May/12 Resolved: 10/Feb/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.2.0, Lustre 1.8.7
Fix Version/s:	Lustre 2.2.0, Lustre 2.1.1, Lustre 1.8.8

Type:

Bug

Priority:

Minor

Reporter:

James A Simmons

Assignee:

Minh Diep

Resolution:

Fixed

Votes:

Labels:

None

Environment:

RHEL5 server side systems

Severity:

Rank (Obsolete):

4767

Description

The current build system for lustre will compile ldiskfs but a make rpms will fail. This is due to the BUILD_SERVER variable not being set in the autoMakefile

Comments

Comment by Andreas Dilger [ 12/Jan/12 ]

James,
please note that RHEL5 will not be a supported server platform for the 2.2 release. RHEL5 is already 5 years old and will be dropping off Red Hat regular support soon, so it doesn't make sense to be deploying Lustre 2.2 systems with such an old kernel.

Comment by James A Simmons [ 12/Jan/12 ]

I have a feeling this is on other platforms too. I haven't tried it yet.

Comment by Peter Jones [ 13/Jan/12 ]

Minh

Could you please see whether this behaviour manifests itself for RHEL6.x? It probably makes sense to wait until the RHEL6.2 support has landed to master(which is imminent).

Thanks

Peter

Comment by James A Simmons [ 13/Jan/12 ]

Just tested on our RHEL6 build box. It also fails to build rpms for ldiskfs.

Comment by James A Simmons [ 13/Jan/12 ]

Posted a patch that fixed it.

http://review.whamcloud.com/#change,1964

Comment by Kent Engström (Inactive) [ 17/Jan/12 ]

I ran into this problem trying to build the Lustre 1.8 fix for ~~LU-974~~ on CentOS 5.7 (with kernel 2.6.18-274.3.1.el5).
The simple one-line fix in http://review.whamcloud.com/#change,1964 seems to work.

Comment by James A Simmons [ 18/Jan/12 ]

Since gerrit with the git commit hooks hates placing build errors in the comments section I placed them here. If you do make rpms in the ldiskfs directory the error you see is

CONFIGURE_ARGS=$(echo $(eval echo $CONFIGURE_ARGS) | sed -re
's/--with-release=[^ ][^ ]*//'); \
RPMARGS="$RPMARGS --define \"configure_args $CONFIGURE_ARGS\""; \
if ! false; then \
RPMARGS="$RPMARGS --define \"build_lustre_tests 0\""; \
fi; \
if ! ; then \
RPMARGS="$RPMARGS --define \"lustre_name lustre-client\""; \
fi; \
echo "Building Lustre RPM with $RPMARGS"; \
eval rpmbuild $RPMARGS -ta lustre-ldiskfs-3.3.0.tar.gz
/bin/sh: -c: line 14: syntax error near unexpected token `;'
/bin/sh: -c: line 14: `if ! ; then \'
make[1]: *** [rpms-real] Error 2

The autoMakefile.am in ldsikfs does not define the BUILD_SERVER flag.
This is from the autoMakefile in the real-rpms section coming out as

CONFIGURE_ARGS=$$(echo $$(eval echo $$CONFIGURE_ARGS) | sed -re
's/--with-release=[^ ][^ ]*//'); \
RPMARGS="$$RPMARGS --define \"configure_args $$CONFIGURE_ARGS\""; \
if ! $(BUILD_TESTS); then \
RPMARGS="$$RPMARGS --define \"build_lustre_tests 0\""; \
fi; \
if ! $(BUILD_SERVER); then \
RPMARGS="$$RPMARGS --define \"lustre_name lustre-client\""; \
fi; \
echo "Building Lustre RPM with $$RPMARGS"; \
eval rpmbuild $$RPMARGS -ta $(distdir).tar.gz

As you can sse no BUILD_SERVER define leads to the above error.