[LU-9890] osd-zfs: ZFS dmu_objset_own and dmu_objset_disown interface changes

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.10.1, Lustre 2.11.0
• Type: Improvement
• Priority: Minor
• Reporter: Giuseppe Di Natale (Inactive)
• Assignee: Giuseppe Di Natale (Inactive)
• Resolution: Fixed
• Labels: patch, zfs

Description

In zfs version 0.8.0, ZFS native encryption will be available. The feature changed the number of arguments provided to the dmu_objset_own and dmu_objset_disown functions. This ticket is to introduce config checks to determine which version of the those functions are available and ensures they are called correctly.

Issue Links

• is related to: LU-11845 Support encrypted ZFS volumes

Comments

[Gerrit Updater]

Giuseppe Di Natale ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28593
Subject: LU-9890 osd-zfs: dmu_objset_own/disown changes
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7ec8a15dcc4c10d27426217f6e8baea484e6736e

[Peter Jones]

Thanks Giuseppe. Are other changes expected to be able to support 0.8 or is it too early to say?

[Giuseppe Di Natale (Inactive)]

Peter,

The spl is slated to be moved into zfs in 0.8.0. That will definitely break lustre builds and the test infrastructure. There's a PR open on it here if you'd like to keep track of that.

The only other currently semi-planned interface changes are to remove unused functions from interfaces, fix the visibility of functions that should not be externally available (i.e. refcount_add, etc), and provide new functions to cover missing functionality. We'd like to work with you on figuring out how to best prune/expand the interfaces we provide.

We also have a new release builder in the zfs buildbot which builds lustre. We hope to use it to catch interface changes early and avoid unintentionally breaking lustre builds. Can the patch I submitted be backported to the lustre 2.10 stable branch so we can enable the lustre build step? 2.10 is currently what the lustre build step will build and we'd like to try and make sure master builds against it.

Thanks!

[Peter Jones]

Thanks - that is very informative. Yes, we'll be able to land this patch to b2_10 as soon as it has landed to master.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28593/
Subject: LU-9890 osd-zfs: dmu_objset_own/disown changes
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0fedb017c12629d145fa0577451d43adc757eb36

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28764
Subject: LU-9890 osd-zfs: dmu_objset_own/disown changes
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: ef09f8d6d4c179f8ef5403ee9368a10a3480d927

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/28764/
Subject: LU-9890 osd-zfs: dmu_objset_own/disown changes
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: be1b1fc67451b85f6a42919cd6aab0ad34b3c2fd