[LU-9980] save_lustre_params() defect Created: 13/Sep/17  Updated: 11/Oct/17  Resolved: 18/Sep/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.0
Fix Version/s: Lustre 2.11.0, Lustre 2.10.2

Type: Bug Priority: Minor
Reporter: Jian Yu Assignee: Jian Yu
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

There is a defect in save_lustre_params() in test-framework.sh.
replay-vbr calls save_lustre_params() with wildcard on parameter :

save_lustre_params $(get_facets MDS) "mdt.*.commit_on_sharing" > $cos_param_file

On the setup with facet_HOST != facetfailover_HOST we could have the following stored parameters :

[root@lm0117 ~]# cat /tmp/rvbr-cos-params
mds1 mdt.lustre-MDT0000.commit_on_sharing=0
mds1 mdt.lustre-MDT0001.commit_on_sharing=0  <<< 1st parameter
mds2 mdt.lustre-MDT0000.commit_on_sharing=0
mds2 mdt.lustre-MDT0001.commit_on_sharing=0  <<< 2nd parameter
mds3 mdt.lustre-MDT0002.commit_on_sharing=0
mds4 mdt.lustre-MDT0003.commit_on_sharing=0
[root@lm0117 ~]#

after facet_failover mds1 mds1 is mounted on other node, but mds2 are still on the the same node.

restore_lustre_params () is trying to restore "mdt.lustre-MDT0001.commit_on_sharing=0" on mds1, but it is missing because of mds2 was not failed and it is still on the same place.
I.e. save_lustre_params() duplicates the info, 1st parameter is not related to mds1, it is related to mds2.



 Comments   
Comment by Gerrit Updater [ 13/Sep/17 ]

Jian Yu (jian.yu@intel.com) uploaded a new patch: https://review.whamcloud.com/28963
Subject: LU-9980 tests: save specific facet in save_lustre_params()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ce48b8ae822405e701c97ae4e3708cff98022198

Comment by Gerrit Updater [ 18/Sep/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28963/
Subject: LU-9980 tests: save specific facet in save_lustre_params()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7921d0d8db942057eb10042291d6d90448e5c197

Comment by Jian Yu [ 18/Sep/17 ]

Landed to master branch for Lustre 2.11.0.

Comment by Gerrit Updater [ 21/Sep/17 ]

Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/29147
Subject: LU-9980 tests: save specific facet in save_lustre_params()
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: c31028cf1d7c46625666a50975b6d4f86be9630a

Comment by Gerrit Updater [ 11/Oct/17 ]

John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/29147/
Subject: LU-9980 tests: save specific facet in save_lustre_params()
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: fe3be466f72ca955ccec6a7e4ce5ac99a3275049

Generated at Sat Feb 10 02:30:59 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.