[LU-9995] lbuild error: 'LMV_HASH_FLAG_DEAD' undeclared (first use in this function) Created: 15/Sep/17  Updated: 09/Oct/17  Resolved: 09/Oct/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0

Type: Bug Priority: Blocker
Reporter: Emoly Liu Assignee: nasf (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The latest lustre code (New tag 2.10.53) commit 57fccbb3 is causing the following lbuild error:
https://build.hpdd.intel.com/job/lustre-reviews/50400/arch=x86_64,build_type=server,distro=el7,ib_stack=inkernel/console

/tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c: In function 'lfsck_read_stripe_lmv':
/tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c:855: error: 'LMV_HASH_FLAG_DEAD' undeclared (first use in this function)
/tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c:855: error: (Each undeclared identifier is reported only once
/tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c:855: error: for each function it appears in.)

Seems related to this definition:

#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 10, 53, 0)
/* Since lustre 2.8, this flag will not be needed, instead this DEAD
 * and orphan flags will be stored in LMA (see LMAI_ORPHAN)     
 * Keep this flag just for LFSCK, because it still might meet such
  flag when it checks the old FS /
#define LMV_HASH_FLAG_DEAD      0x40000000 
#endif


 Comments   
Comment by Oleg Drokin [ 15/Sep/17 ]

I pushed the check to take effect in 2.10.56, but we need to fix it by then.

I guess Fan Yong would be a good person to loook at this since the only remaining users are in lfsck?

Comment by Peter Jones [ 15/Sep/17 ]

Agreed. Fan Yong could you please advise on this?

Comment by Gerrit Updater [ 21/Sep/17 ]

Fan Yong (fan.yong@intel.com) uploaded a new patch: https://review.whamcloud.com/29130
Subject: LU-9995 lfsck: keep the LMV_HASH_FLAG_DEAD flag
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 527b9edd6b043778a3c586ee10d5cc0e71cf93ca

Comment by Gerrit Updater [ 09/Oct/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/29130/
Subject: LU-9995 lfsck: keep the LMV_HASH_FLAG_DEAD flag
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 51f4abfa40c0f47453a592a92185c17daae87bd8

Generated at Sat Feb 10 02:31:07 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.