[LU-9997] Suspicious assert check in ldlm_cli_cancel Created: 15/Sep/17  Updated: 19/Dec/17  Resolved: 01/Dec/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0, Lustre 2.10.3

Type: Bug Priority: Minor
Reporter: Jinshan Xiong (Inactive) Assignee: Jinshan Xiong (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-10293 racer test_1: ASSERTION( list_empty(&... Open
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The assert in ldlm_cli_cancel() seems to be problematic:

        /* Even if the lock is marked as LDLM_FL_BL_AST, this is a LDLM_CANCEL  
         * RPC which goes to canceld portal, so we can cancel other LRU locks   
         * here and send them all as one LDLM_CANCEL RPC. */                    
        LASSERT(list_empty(&lock->l_bl_ast));                                   
        list_add(&lock->l_bl_ast, &cancels);

because the lock may have been picked up LRU and added into canceling list.

 Comments   
Comment by Gerrit Updater [ 15/Sep/17 ]

Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29021
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5fc2e558da6302ce208c06d106b8e59bdf1d751a

Comment by Gerrit Updater [ 15/Sep/17 ]

Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29025
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-dev
Branch: flr2
Current Patch Set: 1
Commit: 863b971d39f210f8ac351e8928266c2075fae4ff

Comment by Gerrit Updater [ 20/Sep/17 ]

Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29080
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: flr
Current Patch Set: 1
Commit: c1f350527458584ab7181a5fae06d21ff00371cc

Comment by Gerrit Updater [ 15/Nov/17 ]

Jinshan Xiong (jinshan.xiong@intel.com) merged in patch https://review.whamcloud.com/29080/
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: flr
Current Patch Set:
Commit: f4ea4017b4d6a420146b2959f9feb11866858b4a

Comment by Gerrit Updater [ 01/Dec/17 ]

Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30339
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 79ca91495ca315ed2a955e60fad7eaf53fafc0f9

Comment by Minh Diep [ 01/Dec/17 ]

Landed in Lustre 2.11.0

Comment by Gerrit Updater [ 19/Dec/17 ]

John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30339/
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 5de61ac6736ed1bfd7425bab4b2c5f7319f65d8e

Generated at Sat Feb 10 02:31:08 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.