[LUDOC-321] Operations manual PDF does not build if 2+ chapters have condition fields

• Status: Closed
• Project: Lustre Documentation
• Type: Bug
• Priority: Blocker
• Reporter: Chris Hanna
• Assignee: Richard Henwood (Inactive)
• Resolution: Fixed

Environment

CentOS 6.7, fop-1.0-1.0.1.wc1.x86_64, xmlgraphics-commons-1.4-3.noarch, cloned copy of git://git.whamcloud.com/doc/manual

• Severity: 3

Description

When two or more chapters have a condition field in their XML chapter tag, the PDF version of the manual will not build. The error which results from make pdf (fop output) is:

org.apache.fop.apps.FOPException: org.apache.fop.fo.ValidationException: Property ID "$" (found on "fo:block-container") previously used; ID values must be unique within a document!

The reason for this error seems to be line 113 in style/customstyle_fo.xsl, which sets id to "${chunkid}" instead of "{$chunkid}". That results in a single "$" being inserted instead of the proper id. As long as only one chapter with a condition field exists, there is no conflict. Once the second chapter with a condition is added, the conflict over "$" results.

After making this fix, there still is some duplication because of a duplicate block ID. Removing the "id={$id}" on line 123 in style/customstyle_fo.xsl appears to fix this and permits the PDF to build cleanly, but I don't know if there are any side effects.

To duplicate this error, a condition must be added to another chapter in the manual. Currently, HSM (chapter 22) is the only chapter with a condition. This issue was discovered when creating a new chapter targeted at Lustre 2.9. An example of the error occurring in the build environment can be found at:

https://build.hpdd.intel.com/job/lustre-manual-reviews/628/console

Let me know if you need any more details.

Issue Links

• is blocking: LUDOC-197 Complete Lustre Manual updates for IU...

Comments

[Gerrit Updater]

Richard Henwood ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18007
Subject: LUDOC-321 style: ensure ID elements are unique.
Project: doc/manual
Branch: master
Current Patch Set: 1
Commit: 83d1c23242d6285913ef0f21a600339f88e2bdec

[Richard Henwood (Inactive)]

Chris: can you give me your Gerrit user name so I can add you as a reviewer?

Or, can you add yourself?

[Chris Hanna]

I don't have a Gerrit account, and it appears I can't create a new one through my OpenID provider (stackexchange). Can you assign [e-mail] as a reviewer?

[Richard Henwood (Inactive)]

[e-mail] does not identify a registered user or group

Do you get an error reported with your stackexchange OpenID provider?

[Kit Westneat]

if you have an Ubuntu launchpad account, you can use that. Also somewhat humorously, a Steam account will work.

[Chris Hanna]

I receive the following:

Not Found
The page you requested was not found, or you do not have permission to view this page.

Following this error, I am still not logged in. Both "Register" and "Sign In" cause the same behavior. The OpenID URL I'm using is:
https://openid.stackexchange.com

The resulting URL in the address bar is:
http://review.whamcloud.com/#SignInFailure,SIGN_IN,Discovered+information+verification+failed.

The StackExchange site shows "Authenticated to review.whamcloud.com" after this occurs.

[Richard Henwood (Inactive)]

I've googled around a bit and not found anything like a direct lead.

Do you have another openid provider you can use?

If not: can you review the patch and post a comment here?

[Chris Hanna]

Tried Yahoo's OpenID and it worked. I've added myself as a reviewer and will take a look.

[Gerrit Updater]

Richard Henwood ([e-mail]) merged in patch http://review.whamcloud.com/18007/
Subject: LUDOC-321 style: ensure ID attributes are unique.
Project: doc/manual
Branch: master
Current Patch Set:
Commit: b6cba0767fe81c43f2cfe0d25637a700e8f6eb3e