https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10030 Lustre <p> Currently, we are using chattr/lsattr for project quota<br/> interface, this have some problems:</p> <p> 1)Client side need patched e2fsprogs or latest upstream<br/> e2fsprogs.<br/> 2)Project quota will be no longer osd-ldiskfs based, ZFS<br/> too, zfs guys might dislike ldiskfs tool dependency for them.<br/> 3)customers argue chattr might be a little dangerous.</p> <p>So we'd better add native lfs tools for project quota.</p> LU-10030

add native lfs tools support for project quota

New Feature Minor Resolved Fixed Wang Shilong Wang Shilong patch Mon, 25 Sep 2017 14:04:31 +0000 Thu, 17 Oct 2019 07:58:45 +0000 Thu, 4 Jan 2018 13:24:14 +0000 Lustre 2.11.0 Lustre 2.12.0 Lustre 2.10.4 0 8 <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/29190" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/29190</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> utils: add lfs tool to change/list project of file<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a037f56081d7d1e4d4f263996a4621b1137d0df0</p> <p>Thanks</p> <p>Is this a client feature or server?</p> <p>This is only Client side.</p> <p>Currently this is kind of a mess - chattr -P depends on special build, sanity-quota silently disables project quota tests without it, the manual doesn't explain that a special chattr is needed. This patch is a good improvement, but it doesn't quite finish - i.e. remove chattr from sanity-quota, link in LUDOC ticket for the manual fixes.</p> <p>Hello Nathan Rutman,</p> <p> Thanks for good suggestion, link has been done, and will remove chattr from sanity-quota when refreshing patch.</p> <p>Thanks,<br/> Shilong</p> <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/30072" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30072</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> llite: extend inode flags into GET/SETXATTR ioctl<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 299b758caaf8c4710249ba9a28a9f84a7b055172</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30072/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30072/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> llite: extend inode flags into GET/SETXATTR ioctl<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 311e8d539b1932593462de428c46ea176b8905db</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/29190/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/29190/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> utils: add lfs tool to change/list project of file<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 022c5a9a77d4612dce28b76a7691b7af1cefd058</p> <p>Looks like this is all landed for 2.11</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32098" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32098</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> utils: add lfs tool to change/list project of file<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 4c4c6097eeeb9785c6be9892cad823b2c0e077f8</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32099" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32099</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> llite: extend inode flags into GET/SETXATTR ioctl<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: ae23eab7537a11e499d6e3747dfa8e03d2f01c60</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32106" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32106</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> llite: use MDS_ATTR_ATTR_FLAG for ia_valid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 7a076f2688c6fd30dd420b8829d359d1826835e4</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32107" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32107</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> idl: use proper ATTR/MDS_ATTR/MDS_OPEN flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a7e53750fb1fc117353c859785cd7cf379604968</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32112" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32112</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> hsm: make changelog flag argument __u32<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 920d58535e5dc467a753c8cc1a83fd988337d29b</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/32099/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32099/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> llite: extend inode flags into GET/SETXATTR ioctl<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: 9c79f3b17605e090e8d0c31d3f34021959aa05d7</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/32098/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32098/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> utils: add lfs tool to change/list project of file<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: d856eedc96e057698a11f063bd7cb3236d191121</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32825" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32825</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> clio: don't use spare bits in iattr.ia_valid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c588aa7cf5d4b02b06993a3a285441cc2765fc3c</p> <p>The wrong constant is used in the implementation of this feature.</p> <p>File: lustre/utils/lfs_project.c</p> <p>When process fsx.fsx_xflags bits the following functions use the wrong constant value to check the project inherit flag.</p> <ul> <li>project_check_one()</li> <li>project_set_one()</li> <li>project_clear_one()</li> </ul> <p>These functions are using FS_IOC_FSGETXATTR and FS_IOC_FSGETXATTR ioctl calls to get or set fsxattr structure.</p> <p>Currently, to process fsx_xflags field from the fsxattr structure these functions use the constant LL_PROJINHERIT_FL, which is defined as the following:</p> <p>#define LL_PROJINHERIT_FL 0x20000000</p> <p>However, when processing fsx_xflags from the fsxattr structure , the different constant should be used: FS_XFLAG_PROJINHERIT, which is defined in linux/fs.h file as following:</p> <p>#define FS_XFLAG_PROJINHERIT 0x00000200 /* create with parents projid */</p> <p>See the following </p> <p><a href="https://github.com/torvalds/linux/blob/master/include/uapi/linux/fs.h#L155" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/torvalds/linux/blob/master/include/uapi/linux/fs.h#L155</a></p> <p><a href="https://github.com/torvalds/linux/blob/master/include/uapi/linux/fs.h#L178" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/torvalds/linux/blob/master/include/uapi/linux/fs.h#L178</a></p> <p><a href="https://unix.stackexchange.com/questions/448637/file-system-inode-flags-difference-between-fs-ioc-getflags-and-fs-ioc-fsgetxatt/448639" class="external-link" target="_blank" rel="nofollow noopener">https://unix.stackexchange.com/questions/448637/file-system-inode-flags-difference-between-fs-ioc-getflags-and-fs-ioc-fsgetxatt/448639</a></p> <p> </p> <p> </p> <p>Hi Alexander Mitin,</p> <p> thanks for pointing this out, we should fix this.</p> <p>Thanks,<br/> Shilong</p> <p>Hi Alexander Mitin,</p> <p>I pushed a proposed patch for this problem:<br/> <a href="https://review.whamcloud.com/#/c/32828/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/32828/</a></p> <p>Thanks,<br/> Shilong</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32840" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32840</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> clio: don't use spare bits in iattr.ia_valid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: dc805c219826e3e729fafb77479052a52dd29b6a</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32825/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32825/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> clio: don't use spare bits in iattr.ia_valid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3a6bbda28826ec1eda59ecb9f442a31f87bb409c</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32107/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32107/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> idl: use proper ATTR/MDS_ATTR/MDS_OPEN flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9c2ffe39bd32f85dab4fbb13855112e57b1dbc5a</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/33512" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33512</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> mds: add enums for MDS_OPEN and MDS_ATTR flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a1ccd134fa30acf8c4e86ef8e600fa018c368890</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32112/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32112/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> hsm: make changelog flag argument an enum<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2496089a0017f5b0ff94a7a7994f4c62c8f30d94</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36469" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36469</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10030" title="add native lfs tools support for project quota" class="issue-link" data-issue-key="LU-10030"><del>LU-10030</del></a> mds: add enums for MDS_OPEN flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 7622048ecbd5ceab7fa72951a587769cac941da7</p> Blocker LUDOC-393 Related LU-11154 Development Rank 1|hzzkrr: Rank (Obsolete) 9223372036854775807