https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10257 Lustre <p>struct vvp_lock, lovsub_lock and lovsub_page can be removed. Nothing happens if these layers are omitted from the corresponding cl_lock or cl_page object. If lps_index is moved to cl_page (which makes some sense based on how it's used) then lov_page can be similarly removed.</p> <p>Removing struct lov_page and lovsub_page reduces the size of a cl_page object from 448 to 344 bytes on x86_64 and puts us in shouting distance from using slab-256 for cl_pages.</p> LU-10257

vvp_lock, lov_page, and lovsub_{lock,page} are (more or less) unused

Bug Minor Closed Fixed John Hammond John Hammond Fri, 17 Nov 2017 21:19:18 +0000 Tue, 4 Feb 2020 18:26:56 +0000 Thu, 3 May 2018 14:01:38 +0000 Lustre 2.11.0 0 7 <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/30161" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30161</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10257" title="vvp_lock, lov_page, and lovsub_{lock,page} are (more or less) unused" class="issue-link" data-issue-key="LU-10257"><del>LU-10257</del></a> clio: remove unused lock and page layers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 42c09d382730e4b773b886a2921fe7abc3807d4f</p> <p>Thank you for the cleanup. I had a discussion with Oleg some time ago about cleaning up CLIO since several parts of the API duplicates what the linux kernel already does. This is a good step in that direction.</p> <p>Jinshan, I recall at one time that this was needed for FLR client write redundancy? If not, then I'm happy to remove it, but it would be sad to take it out and then just add it back when FLR will use it. </p> <p>Andreas, yes you remember it right. lov_page is still needed by FLR.</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/30192" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30192</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10257" title="vvp_lock, lov_page, and lovsub_{lock,page} are (more or less) unused" class="issue-link" data-issue-key="LU-10257"><del>LU-10257</del></a> clio: remove unused cl_lock layers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 61698ec41264f8662e5c16fa29daba3a43d0f05a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30192/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30192/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10257" title="vvp_lock, lov_page, and lovsub_{lock,page} are (more or less) unused" class="issue-link" data-issue-key="LU-10257"><del>LU-10257</del></a> clio: remove unused cl_lock layers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f168371f40e1ebcbf380e655888530476e431421</p> <p>Do we still need any part of the original patch at  <a href="https://review.whamcloud.com/30161" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30161</a> or can we resolve this as fixed for 2.11.0?</p> Related LU-5880 LU-9679 LU-10994 LU-13134 Development Rank 1|hzzo1j: Rank (Obsolete) 9223372036854775807 Severity