Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-10260] ARCHIVE ID range https://jira.whamcloud.com/browse/LU-10260 Lustre <p>According to the lustre manual, ARCHIVE ID must be in the range of 1 to 32.<br/> On the other hand, the code limits ARCHIVE ID to less than 32.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lhsmtool_posix -A 32 1461110663.550681 lhsmtool_posix[5792]: archive number must be lessthan 32: Argument list too long (7) </pre> </div></div> <p>Which is correct?</p> LU-10260 ARCHIVE ID range Bug Minor Resolved Fixed Thomas Stibor Tatsushi Takamura Wed, 20 Apr 2016 00:49:35 +0000 Sat, 3 Mar 2018 14:06:19 +0000 Sat, 3 Mar 2018 14:06:19 +0000 Lustre 2.11.0 0 5 <p><tt>The maximum ARCHIVE ID is defined as</tt></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#define LL_HSM_MAX_ARCHIVE (sizeof(__u32) * 8) = 32 </pre> </div></div> <p>and checked for instance as follows</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-comment">/* Detect out-of range archive id */</span> <span class="code-keyword">if</span> (hss-&gt;hss_archive_id &gt; LL_HSM_MAX_ARCHIVE) { CDEBUG(D_HSM, <span class="code-quote">"archive id %u exceeds maximum %zu.\n"</span>, hss-&gt;hss_archive_id, LL_HSM_MAX_ARCHIVE); GOTO(out_unlock, rc = -EINVAL); } </pre> </div></div> <p>or</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">if</span> (archive_count &gt; LL_HSM_MAX_ARCHIVE) { llapi_err_noerrno(LLAPI_MSG_ERROR, <span class="code-quote">"%d requested when maximum "</span> <span class="code-quote">"of %zu archives supported"</span>, archive_count, LL_HSM_MAX_ARCHIVE); <span class="code-keyword">return</span> -EINVAL; } </pre> </div></div> <p>so the range is from 1 to 32. The archive ID = 0 is reserved to specify in low level calls that <em>no</em> archive identifier change is done.</p> <p>So if I understand correctly, there is no manual bug correct?</p> <p>It looks like the problem is in the lhsmtool_posix. I think one can fix that as follows: </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">diff --git a/lustre/utils/lhsmtool_posix.c b/lustre/utils/lhsmtool_posix.c index 804dbe7..fc078d5 100644 --- a/lustre/utils/lhsmtool_posix.c +++ b/lustre/utils/lhsmtool_posix.c @@ -88,7 +88,7 @@ struct options { <span class="code-object">int</span> o_verbose; <span class="code-object">int</span> o_copy_xattrs; <span class="code-object">int</span> o_archive_cnt; - <span class="code-object">int</span> o_archive_id[LL_HSM_MAX_ARCHIVE]; + <span class="code-object">int</span> o_archive_id[LL_HSM_MAX_ARCHIVE + 1]; <span class="code-object">int</span> o_report_int; unsigned <span class="code-object">long</span> <span class="code-object">long</span> o_bandwidth; size_t o_chunk_size; @@ -259,8 +259,8 @@ <span class="code-keyword">static</span> <span class="code-object">int</span> ct_parseopts(<span class="code-object">int</span> argc, <span class="code-object">char</span> * <span class="code-keyword">const</span> *argv) long_opts, NULL)) != -1) { <span class="code-keyword">switch</span> (c) { <span class="code-keyword">case</span> <span class="code-quote">'A'</span>: - <span class="code-keyword">if</span> ((opt.o_archive_cnt &gt;= LL_HSM_MAX_ARCHIVE) || - (atoi(optarg) &gt;= LL_HSM_MAX_ARCHIVE)) { + <span class="code-keyword">if</span> ((opt.o_archive_cnt &gt; LL_HSM_MAX_ARCHIVE) || + (atoi(optarg) &gt; LL_HSM_MAX_ARCHIVE)) { rc = -E2BIG; CT_ERROR(rc, <span class="code-quote">"archive number must be less"</span> <span class="code-quote">"than %zu"</span>, LL_HSM_MAX_ARCHIVE); </pre> </div></div> <p>I will submit a patch and let's see what the others are thinking about it. Just did a quick check and archive_id=32 seems to work:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">lrh=[type=10680000 len=136 idx=1/15] fid=[0x200000401:0x16:0x0] dfid=[0x200000401:0x16:0x0] compound/cookie=0x5a0ee 145/0x5a0ee13d action=ARCHIVE archive#=32 flags=0x0 extent=0x0-0xffffffffffffffff gid=0x0 datalen=0 status=SUCCEED data=[] 3600 uuid=31732ace-8312-ea22-3423-9d06294ce647 archive_id=32 requests=[current:0 ok:2 errors:0] </pre> </div></div> <p>Cheers<br/> Thomas</p> <p>Thanks Thomas. Based on that, let's move this ticket over to the LU project instead of LUDOC, which is for the manual only.</p> <p>Thomas Stibor (t.stibor@gsi.de) uploaded a new patch: <a href="https://review.whamcloud.com/30171" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30171</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10260" title="ARCHIVE ID range" class="issue-link" data-issue-key="LU-10260"><del>LU-10260</del></a> hsm: enable max archive_id posix copytool<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 24ddf1454ab01db540f96a4dc85fe95b57433a34</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30171/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30171/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10260" title="ARCHIVE ID range" class="issue-link" data-issue-key="LU-10260"><del>LU-10260</del></a> hsm: enable max archive_id posix copytool<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: c98a51f2cebd3417956f5823a0531311e2895028</p> <p>Landed for 2.11</p> Development Project Rank 1|hzy8nj: Rank (Obsolete) 9223372036854775807 Severity