https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10454 Lustre <p><tt>mdd_changelog_data_store_by_fid()</tt> uses <tt>lu_ucred()</tt> but only part of the function is aware that the return value may be NULL.This issue is more or less a duplicate of <a href="https://jira.whamcloud.com/browse/LU-5938" title="sanity-hsm test_52 MDS OOPS: mdd_changelog_data_store" class="issue-link" data-issue-key="LU-5938"><del>LU-5938</del></a> (at least the fix is similar).</p> <p><a href="https://testing.hpdd.intel.com/test_sets/d363f02c-e717-11e7-a066-52540065bddc" class="external-link" target="_blank" rel="nofollow noopener">Here</a> is a failed test run that ran into the issue (and more precisely, <a href="https://testing.hpdd.intel.com/test_logs/d3820698-e717-11e7-a066-52540065bddc/show_text" class="external-link" target="_blank" rel="nofollow noopener">here</a> is thelog file that highlights the issue).</p> LU-10454

mdd: NULL pointer dereference in mdd_changelog_data_store_by_fid()

Bug Major Resolved Fixed Quentin Bouget CEA patch Thu, 4 Jan 2018 09:44:37 +0000 Wed, 5 Aug 2020 13:50:23 +0000 Sat, 20 Jan 2018 16:27:24 +0000 Lustre 2.11.0 Lustre 2.11.0 0 5 <p>Quentin Bouget (quentin.bouget@cea.fr) uploaded a new patch: <a href="https://review.whamcloud.com/30707" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30707</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10454" title="mdd: NULL pointer dereference in mdd_changelog_data_store_by_fid()" class="issue-link" data-issue-key="LU-10454"><del>LU-10454</del></a> mdd: check return value of lu_ucred()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: befe4f4ed9bdc94a76d4bb564a3c11e5f6b8088d</p> <p>Hello Quentin, this problem had just been reported by Oleg in <a href="https://jira.whamcloud.com/browse/LU-10450" title="NULL pointer deref in mdd_changelog_data_store_by_fid+0xfa" class="issue-link" data-issue-key="LU-10450"><del>LU-10450</del></a> !!<br/> BTW, your fix proposal looks ok to address the Oops but as per Oleg's comments there, code from suspected <a href="https://jira.whamcloud.com/browse/LU-9727" title="Lustre Audit with Changelogs" class="issue-link" data-issue-key="LU-9727"><del>LU-9727</del></a> patch at <a href="https://review.whamcloud.com/28114" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28114</a> may also need more adjustments.</p> <p>My bad (that's twice now =/).</p> <p>This is one reason why I've been asking for the llog_reader functionality in <a href="https://review.whamcloud.com/30315" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30315</a> to be included into each of the patches adding functionality, and then testing that functionality in the patch that adds it...</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30707/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30707/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10454" title="mdd: NULL pointer dereference in mdd_changelog_data_store_by_fid()" class="issue-link" data-issue-key="LU-10454"><del>LU-10454</del></a> mdd: check return value of lu_ucred()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 45b3c7a05aac591b6b339bece4ff48306b29f00f</p> <p>Landed for 2.11. Is this needed on b2_10?</p> Duplicate LU-10450 Related LU-5938 Development Rank 1|hzzqcv: Rank (Obsolete) 9223372036854775807 Severity