https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10515 Lustre <p><tt>lustre_rsync</tt> does not use <tt>/dev/obd</tt> and therefore does not need to call <tt>register_ioc_dev()</tt>.</p> LU-10515

lustre_rsync should not call register_ioc_dev()

Bug Minor Resolved Fixed John Hammond John Hammond Mon, 15 Jan 2018 19:14:41 +0000 Thu, 25 Jan 2018 05:13:15 +0000 Thu, 25 Jan 2018 05:13:15 +0000 Lustre 2.11.0 0 4 <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/30870" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30870</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10515" title="lustre_rsync should not call register_ioc_dev()" class="issue-link" data-issue-key="LU-10515"><del>LU-10515</del></a> utils: remove /dev/obd setup from lustre_rsync<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 37565fdcb646dbb27e150559e71bc0ff5af2dfb5</p> <p>It should also not depend on libcfs/util/parser.h or linux/lnet/libcfs_debug.h. In fact it's mixing use of locally defined DTRACE with <tt>D_TRACE</tt> from libcfs_debug.h which is a bug.</p> <p>The libcfs_debug.h is the UAPI header not the core header. See lustre-2.10.56/lnet/include/uapi/linux/lnet/libcfs_debug.h. It contains the defines for lctl set_param debug to work. As for parser.h that is for libreadline support. That is most likely safe to remove.</p> <p>&gt; The libcfs_debug.h is the UAPI header not the core header. See lustre-2.10.56/lnet/include/uapi/linux/lnet/libcfs_debug.h. It contains the defines for lctl set_param debug to work</p> <p>lustre_rsync does not depend on any of this functionality and therefore should not be including libcfs_debug.h.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30870/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30870/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10515" title="lustre_rsync should not call register_ioc_dev()" class="issue-link" data-issue-key="LU-10515"><del>LU-10515</del></a> utils: remove obd.c dependencies from lustre_rsync<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b0094482bba79f198f1fe37af3627694428fc6c6</p> <p>Landed for 2.11</p> Development Rank 1|hzzr53: Rank (Obsolete) 9223372036854775807 Severity