https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10560 Lustre <p>While Mike Marciniszyn was testing the TID-RDMA he tried to build Lustre against upstream. And ran into this build error:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">make[3]: Entering directory `/nfs/sc/disks/fabric_work/mmarciniszyn/repos/wfr/wf r-linux-devel' CC [M] /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-tracefile.o CC [M] /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-debug.o In file included from /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-debug.c:50:0: ./arch/x86/include/asm/uaccess.h: In function ‘set_fs’: ./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to incomplete type current-&gt;thread.addr_limit = fs; </pre> </div></div> LU-10560

Fixes for 4.14 kernel

Bug Minor Resolved Fixed James A Simmons Amir Shehata llnl Wed, 24 Jan 2018 22:49:22 +0000 Wed, 1 May 2019 20:18:54 +0000 Sat, 12 May 2018 05:45:48 +0000 Lustre 2.12.0 0 10 <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31007" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31007</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: remove extra headers from linux-debug.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a8aeb8cfb5e074530e044a1315de1e151061fa0e</p> <p>Some more identified issue with Lustre compile against upstream kernel:</p> <p>Some additional portability issues:</p> <ul class="alternate" type="square"> <li>GFP_TEMPORARY went away</li> <li>wait_queue_t changes to wait_queue_entry_t</li> <li>gss underpinnings changes (disabled gss)</li> <li>asm/uaccess deleted (as with abvoe patch)<br/> o lustre/llite/llite_mmap.c<br/> o lustre/llite/rw26.c</li> </ul> <p>I have a patch for the wait_queue_t changes. Just haven't pushed them yet. How new of a kernel do you need?</p> <p>I have patches for all the above issues as well.</p> <p>An additional issue is with libcfs. vfs_write() is not exported in some cases.</p> <p>I have a patch for that probes for kernel_write()</p> <p>Mike Marciniszyn (mike.marciniszyn@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31153" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31153</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> lustre_compat: handle rename to wait_queue_entry_t<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c947398bd9bdc0dc676ac6296f02545379050cc5</p> <p>Mike Marciniszyn (mike.marciniszyn@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31154" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31154</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> lustre_compat: Use kernel_write when no vfs_write<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 258b5a7e3b55eafac66d94d11aed97aba59d5807</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31007/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31007/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: remove extra headers from linux-debug.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a4ac52a7d08540802f899b115c74f7b9cdd0c5d7</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31150/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31150/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove extra headers from llite_mmap.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: aae9a90ce7c967c208c482e0ef500c5115017388</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31151/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31151/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove extra headers from rw26.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b8e87b5a1c17048a760ce9809fde904ca6dc449d</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31152/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31152/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f01bed03905d424fab81bee84a7b622f141e4f79</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31153/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31153/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: handle rename to wait_queue_entry_t<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9b7ca14430edf84f8c031b1489b3c0d2fb617535</p> <p>I see the LTS label.  Will this ticket also be used to track the backports?</p> <p>I added the llnl label because we have an aarch64 cluster for testing and are attempting to build and use the Lustre 2.10 client there.  Some weeks ago RHEL for arm used a 4.11-based kernel, and Lustre 2.10 client built with minor adjustments.   Since then, RHEL moved to a 4.14-based kernel and much more change is required.</p> <p>Seriously. I will be seeing this update soon. I guess I need to resolve the last patch.</p> <p>Any chance to land the last patch to make this work complete?</p> <p> </p> <p>Li Dongyang (dongyangli@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/31746" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31746</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> mdt: remove extra headers from mdt_identity.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c129c4882f210050db8e9a57fbb96c9a917fb8d7</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31154/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31154/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: Use kernel_write when appropriate<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b9a32054600a8d63948cced361191aa6ae7ea8f2</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31746/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31746/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> mdt: remove extra headers from mdt_identity.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9ade609b73d9b8ac750dec874a7209b07bcb86cb</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31923" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31923</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: remove extra headers from linux-debug.c<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 19158ff6d97668830353388b334eb23da986f8fb</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31924" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31924</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove extra headers from llite_mmap.c<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 480ba0e10974d1e6a6037c67069fe8f528598b1b</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31925" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31925</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove extra headers from rw26.c<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: ff9ab6a368ce3bf2187b047051b7eefc7a997ae0</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31926" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31926</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: e22e1cd2631e3c4a85577d001d5b0571fe8f77eb</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31927" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31927</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: handle rename to wait_queue_entry_t<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 13e2315bf370f67845770a34c658a83ab26a9720</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31928" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31928</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: Use kernel_write when appropriate<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 94d96caa0986d6ff539d75496f3443f159f32313</p> <p>Mike Marciniszyn (mike.marciniszyn@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31948" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31948</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: Fix inconsistent const for cfg_kernel_write()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 874d454c7aeafb849862778dc6f163cc9c1938d7</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=mmarcini" class="user-hover" rel="mmarcini">mmarcini</a> is this now the last patch or are there still more to come?</p> <p>I noted that that the error in the backport in <a href="https://review.whamcloud.com/#/c/31928" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/31928</a> and that is probably due to the const discrepancy.</p> <p>This is the only issue I have with 4.14.x kernel and it as it is working fine for our testing.</p> <p>There are issues with 4.15.x, but i haven't gotten to those yet.   Some notables:</p> <ul> <li>timer API changes</li> <li>const nits</li> </ul> <p>My objective here is to do some Lustre testing with our upstream work for OPA (lnet_selftest, lnet_ping)</p> <p>Ok. 4.15 work is happening under <a href="https://jira.whamcloud.com/browse/LU-10805" title="fixes for 4.15 kernel" class="issue-link" data-issue-key="LU-10805"><del>LU-10805</del></a> but it sounds like this last change should be enough to support 4.14 - thanks!</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31948/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31948/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: Fix inconsistent declaration for cfs_kernel_write()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f19699186d29ba8561d67b4457e98c018ea26317</p> <p>We have a patch for ldiskfs under this ticket so don't close.</p> <p>Yang Sheng (yang.sheng@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32268" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32268</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove assigning f_version in ll_readir.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1de9c46e2dbb64cf788f40e52bf829b334b9da0c</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/31923/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31923/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> libcfs: remove extra headers from linux-debug.c<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: 9892581f02a9602edf345edb12370d92207ffc87</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/31924/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31924/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove extra headers from llite_mmap.c<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: 8e718fde2f35312c624828c375462bddf67854a3</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/31925/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31925/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove extra headers from rw26.c<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: 2639e47aef9dfa60a9003841d1fe771f1acf900a</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/31926/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31926/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: 44af4b737ca4dba3bb93cfe6d43f4bab276f5404</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31975/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31975/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> osd: bi_bdev is replaced by bi_disk<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8036c167789ec84488430f8ddeb726b5b11b373c</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/32268/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32268/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> llite: remove assigning f_version in ll_readir.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: afd9e3c298ec0149c908026617b06bae075f5760</p> <p>Landed for 2.12</p> <p>Li Dongyang (dongyangli@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/32621" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32621</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> osd: bio_integrity_enabled was removed<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d4dc2c9ee0b6260c00e241b6d373b3d98285cd45</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/32621/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32621/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10560" title="Fixes for 4.14 kernel" class="issue-link" data-issue-key="LU-10560"><del>LU-10560</del></a> osd: bio_integrity_enabled was removed<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: eee33ef0f07f3f2f5953953416d5d505088ae9a9</p> Related LU-10805 LU-10997 LU-10934 LU-11132 LU-9558 LU-11310 Development Rank 1|hzzrof: Rank (Obsolete) 9223372036854775807 Severity