https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10728 Lustre <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">static</span> <span class="code-object">int</span> lustre_lnet_resolve_ip2nets_rule(struct lustre_lnet_ip2nets *ip2nets, lnet_nid_t **nids, __u32 *nnids, <span class="code-object">char</span> *err_str, size_t str_len) { ... rc = lustre_lnet_intf2nids(&amp;ip2nets-&gt;ip2nets_net, nids, nnids, err_str, sizeof(err_str)); ... } </pre> </div></div> LU-10728

lnet/utils/lnetconfig/liblnetconfig.c uses sizeof on pointers

Bug Minor Resolved Fixed Cyril Bordage John Hammond Tue, 27 Feb 2018 14:04:50 +0000 Tue, 3 Nov 2020 05:13:06 +0000 Tue, 3 Nov 2020 05:13:06 +0000 Lustre 2.14.0 0 2 <p>There are also several places where we do</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-object">char</span> err_str[LNET_MAX_STR_LEN]; snprintf(err_str, sizeof(err_str), <span class="code-quote">"\"</span>success\""); </pre> </div></div> <p>instead of just</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-object">char</span> err_str[LNET_MAX_STR_LEN] = <span class="code-quote">"\"</span>success\""; </pre> </div></div> <p>and where we explicitly '\0' terminate a buffer after calling snprintf():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">snprintf(err_str, str_len, <span class="code-quote">"\"</span>failed to get <span class="code-keyword">interface</span> addresses: %d\"", -errno); err_str[str_len - 1] = <span class="code-quote">'\0'</span>; </pre> </div></div> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=cbordage" class="user-hover" rel="cbordage">cbordage</a>, could you take a look?</p> <p>Cyril Bordage (cbordage@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/40268" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40268</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10728" title="lnet/utils/lnetconfig/liblnetconfig.c uses sizeof on pointers" class="issue-link" data-issue-key="LU-10728"><del>LU-10728</del></a> utils: fix str length in error string<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 598822099fa8aa747fb65a274387c5909703dc61</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/40268/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40268/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10728" title="lnet/utils/lnetconfig/liblnetconfig.c uses sizeof on pointers" class="issue-link" data-issue-key="LU-10728"><del>LU-10728</del></a> utils: fix str length in error string<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4b2a760fc4747c748ce460289854b76ed17b9ca2</p> <p>Landed for 2.14</p> Development Rank 1|hzzten: Rank (Obsolete) 9223372036854775807 Severity