https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-10772 Lustre <p>Found 2 new static analysis issues in v2_10_58_0-102-g1a5fdde:</p> <ol> <li><b>Suspicious dereference of pointer before NULL check</b> <ul> <li><tt>lnet/utils/lnetconfig/cyaml.c</tt>: in <em>free_node</em>, Suspicious dereference of pointer 'node' before NULL check at line 686</li> </ul> </li> <li><b>Pointer may be dereferenced after it was positively checked for NULL</b> <ul> <li><tt>lustre/utils/lfs.c</tt>: in <em>build_layout_from_yaml_node</em>, Pointer 'string' checked for NULL at line 2192 may be dereferenced at line 2196. Also there is one similar error on line 2207.</li> </ul> </li> </ol> <p>The list of commits since the previous build v2_10_58_0-73-gda79fe8:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1a5fdde76ed95743f2d7df5159b075b3ef5af68a" class="external-link" target="_blank" rel="nofollow noopener">1a5fdde</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10653" title="kernel update [SLES12 SP2 4.4.114-92.64]" class="issue-link" data-issue-key="LU-10653"><del>LU-10653</del></a> kernel: kernel update <span class="error">&#91;SLES12 SP2 4.4.114-92.64&#93;</span></td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=243189198481c9d261a383ae24de5060c82a02ab" class="external-link" target="_blank" rel="nofollow noopener">2431891</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10655" title="llmout.sh and llmountcleanup.sh generates meaningless output: ssh exited with exit code 1" class="issue-link" data-issue-key="LU-10655"><del>LU-10655</del></a> tests: eliminate 'ssh exited with exit code 1'</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=eb8e82dede79552be895bc25b206b0da4a5adcbc" class="external-link" target="_blank" rel="nofollow noopener">eb8e82d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10716" title="interop: sanity test_56xb: FAIL: cannot create hard links" class="issue-link" data-issue-key="LU-10716"><del>LU-10716</del></a> tests: skip sanity 56xb for old server</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=d24d2f94cabfc030c06ec01462fde5f33d134eb4" class="external-link" target="_blank" rel="nofollow noopener">d24d2f9</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10712" title="conf-sanity test_108b: @@@@@@ FAIL: failed to untar image for mdt1 " class="issue-link" data-issue-key="LU-10712"><del>LU-10712</del></a> tests: skip conf-sanity 108<span class="error">&#91;a,b&#93;</span> for old server</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c716c764fe4a6fe5db3ef46f0218217fdd65bd95" class="external-link" target="_blank" rel="nofollow noopener">c716c76</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10684" title="recovery-small test_110[h,i,j] defect: need to be skipped for old servers" class="issue-link" data-issue-key="LU-10684"><del>LU-10684</del></a> tests: skip recovery-small 110<span class="error">&#91;h-j&#93;</span></td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=5b5538e9e728292f1cb5501228a13b8f4787dd97" class="external-link" target="_blank" rel="nofollow noopener">5b5538e</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10672" title="lnet_notify() called incorrectly" class="issue-link" data-issue-key="LU-10672"><del>LU-10672</del></a> lnet: pass in only time64_t to lnet_notify</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=6a07b73d5cdc8b688eebdbf15fa5002a680e3e34" class="external-link" target="_blank" rel="nofollow noopener">6a07b73</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10604" title="osd-ldiskfs can save 8 bytes/object" class="issue-link" data-issue-key="LU-10604"><del>LU-10604</del></a> osd: define couple fields as bitfield</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=473a4adc4ec2bea393c5b438b38b86f2ada19288" class="external-link" target="_blank" rel="nofollow noopener">473a4ad</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7787" title="There is space in the middle of filename under PENDING" class="issue-link" data-issue-key="LU-7787"><del>LU-7787</del></a> mdd: clean up orphan object handling</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=860e20e42ddc45bf5521cbd5f53d35a310b34ded" class="external-link" target="_blank" rel="nofollow noopener">860e20e</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obd: replace lprocfs_str_to_s64</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c98a51f2cebd3417956f5823a0531311e2895028" class="external-link" target="_blank" rel="nofollow noopener">c98a51f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10260" title="ARCHIVE ID range" class="issue-link" data-issue-key="LU-10260"><del>LU-10260</del></a> hsm: enable max archive_id posix copytool</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ed91ee6bd642e031dab781ab4ebf6524476beddd" class="external-link" target="_blank" rel="nofollow noopener">ed91ee6</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10244" title="LustreError: 201288:0:(osc_page.c:336:osc_page_delete()) ASSERTION( (!(value != ((void *)0)) || (value == opg)) ) failed:" class="issue-link" data-issue-key="LU-10244"><del>LU-10244</del></a> osc: add a bit to indicate osc_page in cache tree</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9d6285695745b0a1289a2827d112bd18a687ab34" class="external-link" target="_blank" rel="nofollow noopener">9d62856</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9669" title="sanityn test_77e: @@@@@@ FAIL: failed to set TBF policy " class="issue-link" data-issue-key="LU-9669"><del>LU-9669</del></a> tests: check required nrs availability on a facet</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a37134d398801c10922c32eb03c52b2d46bb6c18" class="external-link" target="_blank" rel="nofollow noopener">a37134d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9624" title="enable sanity.sh test_160a failures for DNE" class="issue-link" data-issue-key="LU-9624"><del>LU-9624</del></a> tests: fix pre-DNE test exceptions/llog usage</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=eac95a6587af4061b36b35051e191ca27bc6b1a3" class="external-link" target="_blank" rel="nofollow noopener">eac95a6</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8912" title="nodemap: error: nodemap_add_range: nodemap ranges must be contiguous" class="issue-link" data-issue-key="LU-8912"><del>LU-8912</del></a> nodemap: fix contiguous range support</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=5446b9b6246c9721394ab3aefb94779c899927de" class="external-link" target="_blank" rel="nofollow noopener">5446b9b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8672" title="missing error handling in replay-single test_89" class="issue-link" data-issue-key="LU-8672"><del>LU-8672</del></a> tests: Fix error handling in replay-single test_89</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9ef9906d70d784d4e9e62e4d77143fc2bd427980" class="external-link" target="_blank" rel="nofollow noopener">9ef9906</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6863" title="change obdfilter-survey to support CLIENTONLY mode" class="issue-link" data-issue-key="LU-6863"><del>LU-6863</del></a> tests: change obdfilter-survey.sh for CLIENTONLY mode</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c593dd0b3c758f58a0845e850a7b986e00c80af2" class="external-link" target="_blank" rel="nofollow noopener">c593dd0</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10657" title="New static analysis issues in v2_10_58_0-16-g21e3977" class="issue-link" data-issue-key="LU-10657"><del>LU-10657</del></a> utils: fd leak in mirror_split()</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=f5c6228f0351787aefb76cb8f807eede3371ea2e" class="external-link" target="_blank" rel="nofollow noopener">f5c6228</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10682" title="o2iblnd txs can be dropped silently" class="issue-link" data-issue-key="LU-10682"><del>LU-10682</del></a> lnd: pending transmits dropped silently</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=feedd8f9c9402ae4de9940b0e606d1f636af262e" class="external-link" target="_blank" rel="nofollow noopener">feedd8f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9019" title="Migrate lustre to standard 64 bit time kernel API" class="issue-link" data-issue-key="LU-9019"><del>LU-9019</del></a> selftest: remove remaining cfs_time wrappers</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1e7fc14bbf48f7e89876cbaa609972981e343944" class="external-link" target="_blank" rel="nofollow noopener">1e7fc14</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10318" title="DoM: HSM support" class="issue-link" data-issue-key="LU-10318"><del>LU-10318</del></a> dom: support DATA_VERSION IO type</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a74b2b5bce71367506e59f1bdba163eb21235a29" class="external-link" target="_blank" rel="nofollow noopener">a74b2b5</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9431" title="class_process_proc_param can&#39;t handle sysfs" class="issue-link" data-issue-key="LU-9431"><del>LU-9431</del></a> obd: resolve config log sysfs issues</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=dfd3542803ea8761c6c824feb761dacec11600ea" class="external-link" target="_blank" rel="nofollow noopener">dfd3542</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10676" title="lustre-zfs-dkms rpm should Provide lustre-dkms for easy upgrades" class="issue-link" data-issue-key="LU-10676"><del>LU-10676</del></a> dkms: Provide lustre-dkms for lustre-zfs-dkms</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=64a49a1d42b44dfdbc2f951177be3cbb9cd368f9" class="external-link" target="_blank" rel="nofollow noopener">64a49a1</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9761" title="Add ldiskfs support to dkms for patchless kernel" class="issue-link" data-issue-key="LU-9761"><del>LU-9761</del></a> dkms: Add ldiskfs dkms support</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1a3cce7bb6c657454f87c33ef794805f651e5395" class="external-link" target="_blank" rel="nofollow noopener">1a3cce7</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9324" title="sanity-pfl test 10 needs to reset the file system default layout" class="issue-link" data-issue-key="LU-9324"><del>LU-9324</del></a> lfs: add setstripe --yaml=template parameter</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2a9518b1f820f833cbfcff42c6606413a1f5d3e7" class="external-link" target="_blank" rel="nofollow noopener">2a9518b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8727" title="Remove skip records from config file" class="issue-link" data-issue-key="LU-8727"><del>LU-8727</del></a> mgs: remove skip records from config file</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=05cfe91c2714a77f5ad3de4a7e58e20b6df17b83" class="external-link" target="_blank" rel="nofollow noopener">05cfe91</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9437" title="sanity-lfsck test_33: only 0 of 4 MDTs are in completed" class="issue-link" data-issue-key="LU-9437"><del>LU-9437</del></a> lfsck: handle LMV EA for migrating directory</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=54fc9a642d90f102bacd0d79e4b81fd534eb26b5" class="external-link" target="_blank" rel="nofollow noopener">54fc9a6</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-10615" title="sanity-scrub: test_10a time out, MDs crashed" class="issue-link" data-issue-key="LU-10615"><del>LU-10615</del></a> osd: stop OI scrub before FLDB closed</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c2caa40bd38e7645dc4ac90552e12e3fb7fde476" class="external-link" target="_blank" rel="nofollow noopener">c2caa40</a></td> <td class='confluenceTd'>Revert "<a href="https://jira.whamcloud.com/browse/LU-8856" title="ZFS-MDT 100% full. Cannot delete files." class="issue-link" data-issue-key="LU-8856"><del>LU-8856</del></a> osd: mark specific transactions netfree"</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a042ad45e40c367a4092fcd9a0507c7cc26ca2b2" class="external-link" target="_blank" rel="nofollow noopener">a042ad4</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8878" title="sanity-hsm test_301: @@@@@@ FAIL: Restart of mds1 failed!" class="issue-link" data-issue-key="LU-8878"><del>LU-8878</del></a> tests: skip several tests for CLIENTONLY mode</td> </tr> </tbody></table> </div> LU-10772

New static analysis issues in v2_10_58_0-102-g1a5fdde

Bug Major Resolved Fixed Sonia Sharma Dmitry Eremin kw Mon, 5 Mar 2018 14:18:52 +0000 Wed, 30 Aug 2023 21:35:09 +0000 Sat, 6 Oct 2018 13:38:34 +0000 Lustre 2.11.0 Lustre 2.12.0 0 5 <p>The first issue is just a warning about redundant "<b>if (node)</b>" operator.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">static</span> bool free_node(struct cYAML *node, void *user_data, void **out) { <span class="code-keyword">if</span> (node-&gt;cy_type == CYAML_TYPE_STRING) free(node-&gt;cy_valuestring); <span class="code-keyword">if</span> (node-&gt;cy_string) free(node-&gt;cy_string); <span class="code-keyword">if</span> (node) free(node); <span class="code-keyword">return</span> <span class="code-keyword">true</span>; } </pre> </div></div> <p>Sonia</p> <p>Could you please investigate</p> <p>Thanks</p> <p>Peter</p> <p>I think it's better to move the check to the function start. Something like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">if</span> (!node) <span class="code-keyword">return</span> <span class="code-keyword">true</span>; <span class="code-keyword">rest</span> of stuff </pre> </div></div> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31537" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31537</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10772" title="New static analysis issues in v2_10_58_0-102-g1a5fdde" class="issue-link" data-issue-key="LU-10772"><del>LU-10772</del></a> utils: static analysis issues<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 76908c5ced2a3979af8c398eb745c33ac67da065</p> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31551" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31551</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10772" title="New static analysis issues in v2_10_58_0-102-g1a5fdde" class="issue-link" data-issue-key="LU-10772"><del>LU-10772</del></a> utils: incorrect NULL check in free_node()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 34f15a85cbd03f007ade66652bb0a5aa0bccf004</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31551/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31551/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10772" title="New static analysis issues in v2_10_58_0-102-g1a5fdde" class="issue-link" data-issue-key="LU-10772"><del>LU-10772</del></a> utils: incorrect NULL check in free_node()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 782736f7c5cf96ae72bf6ee8791764130e2447d8</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/31537/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31537/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-10772" title="New static analysis issues in v2_10_58_0-102-g1a5fdde" class="issue-link" data-issue-key="LU-10772"><del>LU-10772</del></a> utils: incorrect check in build_layout_from_yaml_node<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 13bee727125202ff8519163fc72581f359532b90</p> <p>Landed for 2.12</p> Related LU-4629 Development Rank 1|hzztt3: Rank (Obsolete) 9223372036854775807 Severity