Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-1096] Test failure on test suite lfsck,Segmentation fault https://jira.whamcloud.com/browse/LU-1096 Lustre <p>This issue was created by maloo for sarah <sarah@whamcloud.com></p> <p>This issue relates to the following test suite run: <a href="https://maloo.whamcloud.com/test_sets/1bfcbe72-553d-11e1-9aa8-5254004bbbd3" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/1bfcbe72-553d-11e1-9aa8-5254004bbbd3</a>.</p> LU-1096

Test failure on test suite lfsck,Segmentation fault

Bug Blocker Resolved Fixed Yang Sheng Maloo Sun, 12 Feb 2012 02:47:32 +0000 Wed, 30 May 2012 21:48:49 +0000 Wed, 30 May 2012 21:48:48 +0000 0 3 <p>Andreas will look into this one</p> <p>Niu</p> <p>Andreas is out on vacation for the next two weeks so could you please make an initial assessment of this issue?</p> <p>Thanks</p> <p>Peter</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">lfsck -c -l --mdsdb /scratch/mdsdb --ostdb /scratch/ostdb-0 /scratch/ostdb-1 /scratch/ostdb-2 /scratch/ostdb-3 /scratch/ostdb-4 /scratch/ostdb-5 /mnt/lustre lfsck 1.41.90.wc4 (01-Sep-2011) /scratch/mdsdb:mdshdr : Invalid argument /usr/lib64/lustre/tests/test-framework.sh: line 2679: 19558 Segmentation fault lfsck -c -l --mdsdb /scratch/mdsdb --ostdb /scratch/ostdb-0 /scratch/ostdb-1 /scratch/ostdb-2 /scratch/ostdb-3 /scratch/ostdb-4 /scratch/ostdb-5 /mnt/lustre </pre> </div></div> <p>Looks like open mdsdb failed, and it caused segment fault.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">+ <span class="code-keyword">if</span> ((rc = dbp->open(dbp, NULL, fname, dbname, DB_HASH, + DB_CREATE | DB_THREAD, 0664)) != 0) + { + dbp->err(dbp, rc, <span class="code-quote">"%s:%s\n"</span>, fname, dbname); + dbp->close(dbp, 0); + <span class="code-keyword">return</span> (EIO); </pre> </div></div> <p>I suspect this failure is similar to the <a href="https://jira.whamcloud.com/browse/LU-367" title="lfsck 1.41.90.wc2: illegal flag specified to DB->open" class="issue-link" data-issue-key="LU-367"><del>LU-367</del></a>: the db4 version of the server which generating MDSDB is different with the db4 version of client which open the MDSDB.</p> <p>The maloo shows that test server and client have different system, server is CentOS release 6.2, but client is CentOS release 5.7, so I think the db4 version should be different.</p> <p>I think we may need to improve the test script to make sure that using same db4 to generate & check the db file, and lfsck also needs be improved to handle the db4 version mismatch gracefully. But I don't think this should be a blocker.</p> <p>Yangsheng</p> <p>Could you please look into how to address this problem. Andreas had some ideas about how to deal with this situation more gracefully</p> <p>Thanks</p> <p>Peter</p> <p>This issue isn't relate to db4 library. Just wrong invoke log_write(...) after lfsck_opendb():</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> rc = lfsck_opendb(mds_file, MDS_HDR, &mds_hdrdb, 0, 0, 0); if (rc != 0) { >>>>>>> log_write("%s: error opening mds_hdr in %s: rc %d\n", mds_file, rc); return(-EINVAL); </pre> </div></div> <p>Have a guidance for commit patch to e2fsprog? </p> <p>For record:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>int log_close(int status) { time_t tm; if (logfile == NULL) return(0); time(&tm); if (status < 0) { fprintf(logfile, "ERROR: lfsck aborted\n"); } else { fprintf(logfile, "lfsck run completed: %s\n",ctime(&tm)); } fprintf(logfile, "===============================================\n\n"); fclose(logfile); >>>>>>>>logfile = NULL; return(0); } </pre> </div></div> <p>Else may cause a double free in some failure case.</p> <p>YS, you can submit patches to Gerrit with the tools/e2fsprogs repo, on the master-lustre branch. I'm just in the middle of rebasing this tree, so any patch would need to be rebased again before it could land. </p> <p>Patch landed. close bug.</p> Development Rank 1|hzvhcn: Rank (Obsolete) 6460 Severity