https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11052 Lustre <p>Stats maintained via the obd operations wrappers are less and less interesting. We should remove them.</p> LU-11052

remove obd ops based stats

Improvement Minor Resolved Fixed WC Triage John Hammond Wed, 23 May 2018 21:54:09 +0000 Wed, 18 Jul 2018 12:45:30 +0000 Wed, 18 Jul 2018 12:45:30 +0000 Lustre 2.12.0 0 4 <p>You are my hero. I was just looking at tackling that work but have lacked the cycles to start it. Please be aware that some sites do collect this data to study it so remove with care.</p> <p>I'll preparing a comment to post here and in the commit message about what differences we'll see in the proc files.</p> <p>The only stats files affected here would be <tt>obdfilter.&#42;.stats</tt>, <tt>obdfilter.&#42;.exports.*.stats</tt> and <tt>obdecho.&#42;.stats</tt>. For obdfilter here is a comparison for two racer runs. With the current obd ops based stats:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lctl get_param obdfilter.lustre-OST0000.stats obdfilter.lustre-OST0000.stats= snapshot_time 1527267354.328068245 secs.nsecs read_bytes 610 samples [bytes] 4096 4194304 800043008 write_bytes 2196 samples [bytes] 5 4194304 3410224606 setattr 13545 samples [reqs] punch 7682 samples [reqs] destroy 2281 samples [reqs] create 74 samples [reqs] statfs 234 samples [reqs] get_info 1 samples [reqs] connect 3 samples [reqs] disconnect 1 samples [reqs] preprw 2806 samples [reqs] commitrw 2806 samples [reqs] ping 422 samples [reqs] # lctl get_param obdfilter.lustre-OST0000.exports.*.stats obdfilter.lustre-OST0000.exports.0@lo.stats= snapshot_time 1527267369.060990116 secs.nsecs read_bytes 610 samples [bytes] 4096 4194304 800043008 write_bytes 2196 samples [bytes] 5 4194304 3410224606 setattr 13545 samples [reqs] punch 7682 samples [reqs] destroy 2281 samples [reqs] create 74 samples [reqs] statfs 237 samples [reqs] get_info 1 samples [reqs] disconnect 1 samples [reqs] preprw 2806 samples [reqs] commitrw 2806 samples [reqs] ping 428 samples [reqs] </pre> </div></div> <p>And after the OBD ops bases stats have been removed:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lctl get_param obdfilter.lustre-OST0000.stats obdfilter.lustre-OST0000.stats= snapshot_time 1527168813.867472974 secs.nsecs read_bytes 200 samples [bytes] 4096 4194304 231366656 write_bytes 1703 samples [bytes] 5 4194304 1220864892 getattr 337 samples [reqs] setattr 6358 samples [reqs] punch 2880 samples [reqs] destroy 2000 samples [reqs] create 71 samples [reqs] statfs 2148 samples [reqs] get_info 4 samples [reqs] # lctl get_param obdfilter.lustre-OST0000.exports.*.stats obdfilter.lustre-OST0000.exports.0@lo.stats= snapshot_time 1527168830.966629150 secs.nsecs read_bytes 182 samples [bytes] 4096 4194304 134897664 write_bytes 1710 samples [bytes] 5 4194304 1198540888 getattr 335 samples [reqs] setattr 6703 samples [reqs] punch 3017 samples [reqs] destroy 2000 samples [reqs] create 71 samples [reqs] statfs 2160 samples [reqs] get_info 4 samples [reqs] </pre> </div></div> <p>So the difference it that after we drop connect, disconnect, preprw, commitrw, and ping.</p> <p>I did not try to create and use a target of type obdecho. So I don't have any comparison to show.</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/32602" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32602</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11052" title="remove obd ops based stats" class="issue-link" data-issue-key="LU-11052"><del>LU-11052</del></a> obd: remove OBD ops based stats<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3b9fe7e0f33d42525ecc604ceb6d066dd09c0586</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32602/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32602/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11052" title="remove obd ops based stats" class="issue-link" data-issue-key="LU-11052"><del>LU-11052</del></a> obd: remove OBD ops based stats<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 711eff3a50003b5c617955bae50fba7bfcb9c43d</p> <p>Landed for 2.12</p> Development Rank 1|hzzxpr: Rank (Obsolete) 9223372036854775807