https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11112 Lustre <p>The kernel_bind() call in lnet_sock_create() may fail either due to<br/> problem with the local port, or the local IP address, but the error message currently only includes the port. It would be helpful if the message included both items when indicating a fatal error.</p> <p>Background: We've encoutered an issue where LNET had picked a virtual IP address (used for non-Lustre services) for its <tt>local_ip</tt>, and lnet_sock_create would fail once the IP address was migrated to another node. The error message only included the port, but not the IP address, and so it took a while to correlate the events. Why LNET chose to pick this particular source address is a separate question we need to investigate, but for starters, improving the error message to include all relevant content seems to be a good idea to me.</p> LU-11112

lnet: improve error msg in lnet_sock_create()

Improvement Minor Open Unresolved Sonia Sharma Daniel Kobras Mon, 2 Jul 2018 13:59:38 +0000 Tue, 3 Jul 2018 15:19:47 +0000 0 6 <p>Sonia</p> <p>Could you please investigate?</p> <p>Thanks</p> <p>Peter</p> <p>Daniel</p> <p>Could you please push your proposed patch into Gerrit so it can be reviewed/landed?</p> <p>Peter</p> <p>It seems Gerrit has moved to a different IP address, and I cannot access it due to local firewall restrictions. Attaching the patch here while I try to sort things out.</p> <p>FWIW: This is the original lnet error message:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>LNetError: 2099:0:(lib-socket.c:455:lnet_sock_create()) Error trying to bind to port 1023: -99 LNetError: 2099:0:(lib-socket.c:455:lnet_sock_create()) Skipped 8 previous similar messages LNetError: 11e-e: Unexpected error -99 connecting to 192.168.10.6@tcp at host 192.168.10.6 on port 988 </pre> </div></div> <p>Hi Daniel</p> <p>In the lnet_sock_connect function, I see "INADDR_ANY" is assigned if the local_ip == 0. With "INDDR_ANY" in the bind call, the socket will be bound to all the local interfaces.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 439         <span class="code-keyword">if</span> (local_ip != 0 || local_port != 0) { 440                 memset(&amp;locaddr, 0, sizeof(locaddr)); 441                 locaddr.sin_family = AF_INET; 442                 locaddr.sin_port = htons(local_port); 443                 locaddr.sin_addr.s_addr = (local_ip == 0) ? 444                                           INADDR_ANY : htonl(local_ip);</pre> </div></div> <p>Was this virtual address assigned to one of the interface on the node? It would help to understand if you know what particular action/command execution is resulting in this error.</p> <p>Thanks<br/> Sonia</p> <p>Hi Sonia!</p> <p>For the scope of this LU, my line of argument just goes:</p> <ul> <li>lnet_sock_connect() can fail due to either of two arguments (local_ip and local_port);</li> <li>the resulting error message just includes one of the arguments (local_port);</li> <li>there exists at least one real-world case where it fails due to the other argument (local_ip);</li> <li>hence the error message should be improved to include both arguments.</li> </ul> <p>The case given was only meant as an example to show that having the full information in the error output occasionally really matters.</p> <p> </p> <p>Why LNET chose to open a connection with a fixed source IP address rather than just using INADDR_ANY isn't clear to me, yet. One should be able to reproduce it with</p> <ul> <li>assign IP alias to interface;</li> <li>start LNET/Lustre;</li> <li>remove IP alias from interface;</li> </ul> <p>but that's a topic probably more suited to a separate LU (once we've collected more information about it).</p> <p>Daniel Kobras (d.kobras@science-computing.de) uploaded a new patch: <a href="https://review.whamcloud.com/32758" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32758</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11112" title="lnet: improve error msg in lnet_sock_create()" class="issue-link" data-issue-key="LU-11112">LU-11112</a> lnet: improve error msg in lnet_sock_create()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a0b382caf10e590f112030cc528e1c5fdd470390</p> Development Rank 1|hzzyp3: Rank (Obsolete) 9223372036854775807