https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11157 Lustre <p>This issue was created by maloo for John Hammond &lt;jhammond@whamcloud.com&gt;</p> <p>This issue relates to the following test suite run: <a href="https://testing.whamcloud.com/test_sets/f2a78f4c-8aa6-11e8-808e-52540065bddc" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/test_sets/f2a78f4c-8aa6-11e8-808e-52540065bddc</a></p> <p>test_42e failed with the following error:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>test_42e returned 1 </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>== sanity test 42e: verify sub-RPC writes are not done synchronously ================================= 14:42:04 (1531924924) total: 3500 open/close in 6.19 seconds: 565.32 ops/second /usr/lib64/lustre/tests/sanity.sh: line 3978: 209.9: syntax error: invalid arithmetic operator (error token is ".9") </pre> </div></div> <p>Some proc/sys/... files are returning decimal values. This one is from max_dirty_mb.</p> <p>Looks like 14 instances of this failure today.</p> <p>VVVVVVV DO NOT REMOVE LINES BELOW, Added by Maloo for auto-association VVVVVVV<br/> sanity test_42e - test_42e returned 1</p> LU-11157

sanity test_42e: invalid arithmetic operator (error token is ".9")

Bug Minor Resolved Fixed James A Simmons Maloo Wed, 18 Jul 2018 19:32:44 +0000 Thu, 21 Nov 2019 21:37:52 +0000 Fri, 10 May 2019 12:50:32 +0000 Lustre 2.12.0 Lustre 2.13.0 Lustre 2.12.4 0 6 <p>John L. Hammond (jhammond@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/32831" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32831</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11157" title="sanity test_42e: invalid arithmetic operator (error token is &quot;.9&quot;)" class="issue-link" data-issue-key="LU-11157"><del>LU-11157</del></a> obd: keep dirty_max_pages a round number of MB<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2c46819ed70b222a8b762d1b2e7e1f4226de89e8</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>LU-8066 obdclass: move lustre sysctl to sysfs Backport from upstream the changes to port lustre systctl to sysfs. Needed to re-export the function lprocfs_read_frac_helper for later work. The following patches were backported: Linux-commit: e2424a1265f2772b66f068c205256e2aef5f74a0 Move max_dirty_mb from sysctl to sysfs. max_dirty_mb is now a parameter in /sys/fs/lustre. </pre> </div></div> <p>Ouch, it been broken upstream for some time.</p> <p>&gt; Ouch, it been broken upstream for some time.</p> <p>It was only when <a href="https://jira.whamcloud.com/browse/LU-10990" title="Get rid of per-osc max_dirty_mb setting" class="issue-link" data-issue-key="LU-10990"><del>LU-10990</del></a> and <a href="https://jira.whamcloud.com/browse/LU-8066" title="Move lustre procfs handling to sysfs and debugfs." class="issue-link" data-issue-key="LU-8066">LU-8066</a> were combined that this started failing.</p> <p>I am really not a fan of displaying decimal fractional values in these files. Generally it means that we cannot faithfully save and restore the parameter values.</p> <p>However if we do keep fractional values then I think there is more to do here. There are substantial differences between <tt>lprocfs_seq_read_frac_helper()</tt> and <tt>lprocfs_read_frac_helper()</tt>. I don't know why the second function is so complicated. But this is bad. Switching from proc to sys shouldn't be changing the format used to display the values.</p> <p>Andreas Dilger (adilger@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32831/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32831/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11157" title="sanity test_42e: invalid arithmetic operator (error token is &quot;.9&quot;)" class="issue-link" data-issue-key="LU-11157"><del>LU-11157</del></a> obd: keep dirty_max_pages a round number of MB<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d3f88d376c49e4520a0d695a4b4e9b0c2dbebaaf</p> <p>In addition to sanity test 42e failing, we also see the following tests fail:<br/> sanity 64d with the same error message; '209.9: syntax error: invalid arithmetic operator (error token is ".9")'<br/> conf-sanity test 76a with error message ''209.9: syntax error: invalid arithmetic operator (error token is ".9")'<br/> recovery-small test 55 with error 'error: set_param: setting /sys/fs/lustre/osc/lustre-OST0001-osc-ffff9b4353f50800/max_dirty_mb=209.9: Invalid argument'<br/> sanity-dom test 42e, which is running sanity test 42e</p> <p>So I started to look into this and see the reason as John pointed out for the failures Nunez posted is due to the test treating the values returned by say "max_dirty_mb" as a real integer and not a float point string. We could update the test to feed this result into bc since bash can't do floating point math. The question to ask is do we want to make sites do the same kind of crazy? If we don't that means we end implementing round_up() handling like we did for dirty_max_pages. Is that okay with people?</p> <p>I'm fine with rounding the output to a whole number of MB. This is the only code that is using <tt>lprocfs_read_frac_helper()</tt> so it could just be removed. There are other places that are using <tt>lprocfs_seq_read_frac_helper()</tt> that will have the same issues. Back when this code was written, a few MB was a lot of memory, but now it is a rounding error for a client.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/34317" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34317</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11157" title="sanity test_42e: invalid arithmetic operator (error token is &quot;.9&quot;)" class="issue-link" data-issue-key="LU-11157"><del>LU-11157</del></a> obd: round values to nearest MiB for *_mb sysfs files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3e9d90e56042d5ff9076ae057c1ff117c348b2fa</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34317/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34317/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11157" title="sanity test_42e: invalid arithmetic operator (error token is &quot;.9&quot;)" class="issue-link" data-issue-key="LU-11157"><del>LU-11157</del></a> obd: round values to nearest MiB for *_mb syfs files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ba2817fe3ead1b8e32be6d6c6ce25b490626118a</p> <p>Landed for 2.13</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36393" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36393</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11157" title="sanity test_42e: invalid arithmetic operator (error token is &quot;.9&quot;)" class="issue-link" data-issue-key="LU-11157"><del>LU-11157</del></a> obd: round values to nearest MiB for *_mb syfs files<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 350b4ee688585c034f0c0e520e2587aa4d389eda</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36393/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36393/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11157" title="sanity test_42e: invalid arithmetic operator (error token is &quot;.9&quot;)" class="issue-link" data-issue-key="LU-11157"><del>LU-11157</del></a> obd: round values to nearest MiB for *_mb syfs files<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 72c2d383c3e77206b0d169d894a18b5e43b7b72b</p> Related LU-8066 LU-10990 LU-9091 Development Rank 1|hzzzdr: Rank (Obsolete) 9223372036854775807 Severity