https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11188 Lustre <p>Adding the capability to "<tt>lfs find</tt>" to search/locate on permission of file, matching the <tt>find -perm</tt> behaviour of <tt>find(1)</tt>.</p> CentOS 7.3 Lustre 2.9 and 2.10.4 clients LU-11188

Add to "lfs find" the ability to check on permissions

Improvement Minor Resolved Fixed Guillaume Courrier Megan Larko easy lfs Fri, 27 Jul 2018 19:39:00 +0000 Wed, 30 Jun 2021 14:09:46 +0000 Wed, 2 Jun 2021 23:34:10 +0000 Lustre 2.12.0 Lustre 2.15.0 0 4 <p>This should just be a matter of copying the code that handles "<tt>-type</tt>" or similar (with new <tt>params.fp_mode</tt> and <tt>params.fp_mode_sign</tt> fields), and then modifying it to compare the mode. The tricky part is getting the semantics correct with +/-mode, and converting symbolic modes to octal (the <tt>find(1)</tt> man page goes into depth on this issue). Starting with only "<tt><span class="error">&#91;+-&#93;</span>octal</tt>" may be enough for initial usefulness. The OSX <tt>find(1)</tt> man page summarizes the desired semantics nicely:</p> <blockquote> <p>If the mode is preceded by a dash ('<tt>-</tt>'), this primary evaluates to true if at least <b>all</b> of the bits in the mode are set in the file's mode bits. If the mode is preceded by a plus ('<tt>+</tt>'), this primary evaluates to true if <b>any</b> of the bits in the mode are set in the file's mode bits. Otherwise, this primary evaluates to true if the bits in the mode exactly match the file's mode bits.</p></blockquote> <p>This appears to equate to <tt>st_mode &amp; fp_mode == fp_mode</tt> and <tt>st_mode &amp; fp_mode != 0</tt> for '<tt>-</tt>' and '<tt>+</tt>' respectively.</p> <p>Newer versions of find also accept the '<tt>/</tt>' modifier as equivalent to the '<tt>+</tt>' modifier, since it avoids ambiguity with symbolic mode parsing.</p> <p>Hi <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=courrier" class="user-hover" rel="courrier">courrier</a>, thanks for taking on this work. Please let me know if you have any questions. </p> <p>For a change like this it should typically include a new sanity test as well as an update to the <tt>lustre/doc/lfs-find.1</tt> man page.</p> <p>The <a href="https://jira.whamcloud.com/browse/LU-7495" title="lfs find is missing &quot;-links&quot; support" class="issue-link" data-issue-key="LU-7495"><del>LU-7495</del></a> ticket is very similar (possibly a bit easier than this one), while <a href="https://jira.whamcloud.com/browse/LU-10378" title="&quot;lfs find&quot; is missing &quot;-printf&quot; support" class="issue-link" data-issue-key="LU-10378"><del>LU-10378</del></a> would be somewhat more complex.</p> <p>Hi, thanks for your help. As I'm new on this project, I'll be discovering the code as I'm working on this patch.</p> <p>I'll come back to you if I have questions.</p> <p>Guillaume Courrier (guillaume.courrier@cea.fr) uploaded a new patch: <a href="https://review.whamcloud.com/43715" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43715</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11188" title="Add to &quot;lfs find&quot; the ability to check on permissions" class="issue-link" data-issue-key="LU-11188"><del>LU-11188</del></a> lfs: add "--perm" option to "lfs find"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 964b32570787f96cc615fae17049211f591bc4eb</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/43715/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43715/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11188" title="Add to &quot;lfs find&quot; the ability to check on permissions" class="issue-link" data-issue-key="LU-11188"><del>LU-11188</del></a> lfs: add "--perm" option to "lfs find"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 06588e4a22b0ff037eafa1eee5e22521b1626904</p> <p>Landed for 2.15. Congratulations <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=courrier" class="user-hover" rel="courrier">courrier</a> <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> Blocker LU-14801 Related LU-5170 LU-7495 Development Rank 1|hzzzyn: Rank (Obsolete) 9223372036854775807