https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11218 Lustre <p>mdd_is_parent() brings link xattrs of not locked objects into osp cache.<br/> If that cache becomes stale a directory rename includes an outdated link xattr into object xattr table. That makes a directory to have more than one link. That also confuses lfsck.</p> LU-11218

osp xattr cache brought by mdd_is_parent needs to be invalidated

Bug Major Closed Fixed Vladimir Saveliev Vladimir Saveliev Mon, 6 Aug 2018 12:42:23 +0000 Tue, 4 Dec 2018 16:15:30 +0000 Tue, 4 Dec 2018 16:15:30 +0000 0 4 <p>Vladimir Saveliev (c17830@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/32942" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32942</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11218" title="osp xattr cache brought by mdd_is_parent needs to be invalidated" class="issue-link" data-issue-key="LU-11218"><del>LU-11218</del></a> mdd: do not cache atributes on mdd_parent_fid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 092ac85e6d522c5d797686f3be785c778c2d7cbc</p> <p>probably <a href="https://review.whamcloud.com/#/c/31194/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/31194/</a> can help</p> <p> </p> <blockquote> <p>probably <a href="https://review.whamcloud.com/#/c/31194/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/31194/</a> can help</p></blockquote> <p>Yes, it helps: the sanity.sh:807 from <a href="https://review.whamcloud.com/32942" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32942</a> does not fail with it.</p> <p>Alex, however, that patch seems to get stuck since march. Do you have plans to move it forward?</p> <p>Alex, Vladimir, do you have a preference of which of these two patches to land?</p> <p>Is one "more complete" than the other? It seems like Alex's <a href="https://jira.whamcloud.com/browse/LU-10406" title="sanity-lfsck test_31c: (4) Fail to re-generate master LMV EA: 2" class="issue-link" data-issue-key="LU-10406"><del>LU-10406</del></a> patch will also fix the bug with LFSCK, while the patch here will only fix the one MDD case?</p> <p>I've rebased Alex's patch to verify that it is still working correctly with master (there can be bad interactions if a very old patch is landed without retesting), so if this is the better one to land then it should be ready in a few hours (barring some intermittent failure).</p> <p>I think we should land the old (<a href="https://jira.whamcloud.com/browse/LU-10406" title="sanity-lfsck test_31c: (4) Fail to re-generate master LMV EA: 2" class="issue-link" data-issue-key="LU-10406"><del>LU-10406</del></a>) patch as it improves locking/invalidation schema in general.</p> <p> </p> <p><a href="https://review.whamcloud.com/31194" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31194</a> at <a href="https://jira.whamcloud.com/browse/LU-10406" title="sanity-lfsck test_31c: (4) Fail to re-generate master LMV EA: 2" class="issue-link" data-issue-key="LU-10406"><del>LU-10406</del></a> fixes this.</p> Related LU-10406 Development Rank 1|i000cf: Rank (Obsolete) 9223372036854775807 Severity