Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-11233] gcc8 support https://jira.whamcloud.com/browse/LU-11233 Lustre <p>gcc8 introduces number of new checks (especially in string manipulation area) preventing builds</p> <p> </p> LU-11233 gcc8 support Improvement Trivial Resolved Fixed Alex Zhuravlev Alex Zhuravlev Fri, 10 Aug 2018 15:19:36 +0000 Sat, 8 Jun 2019 12:24:16 +0000 Wed, 29 May 2019 13:06:34 +0000 Lustre 2.13.0 Lustre 2.12.3 0 5 <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/32978" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32978</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: gcc8 support<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 94f34bfcde638b7d3535154c04907544ca4b6fce</p> <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/34660" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34660</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: support for gcc8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 76e3fc7e99538ce73708514863e63467066dced8</p> <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/34661" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34661</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: support for gcc8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 973f4ffb776303c8caddbc6e507d0d5c7c75f4ee</p> <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/34662" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34662</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: support for gcc8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ae3e0118240849c89ac3b222ef38ddc7184bd29a</p> <p>Alex, please add something like this below to <a href="https://review.whamcloud.com/#/c/34662/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/34662/</a> to make server utils build with gcc8:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> diff --git a/lustre/utils/mount_lustre.c b/lustre/utils/mount_lustre.c index 1acd6353a0..c3dcf5e62c 100644 --- a/lustre/utils/mount_lustre.c +++ b/lustre/utils/mount_lustre.c @@ -348,7 +348,7 @@ <span class="code-object">int</span> parse_options(struct mount_opts *mop, <span class="code-object">char</span> *orig_options, free(options); <span class="code-keyword">return</span> EINVAL; } - strncpy(mop-&gt;mo_skpath, val + 1, strlen(val + 1)); + strncpy(mop-&gt;mo_skpath, val + 1, strlen(mop-&gt;mo_skpath) - 1); #endif } <span class="code-keyword">else</span> <span class="code-keyword">if</span> (parse_one_option(opt, flagp) == 0) { <span class="code-comment">/* pass <span class="code-keyword">this</span> on as an option */</span> </pre> </div></div> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=dongyang" class="user-hover" rel="dongyang">dongyang</a> please tell what exact gcc you are using</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [root@rhel8 ~]# gcc --version gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3) Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source <span class="code-keyword">for</span> copying conditions. There is NO warranty; not even <span class="code-keyword">for</span> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. </pre> </div></div> <p>gcc version 8.3.1 20190223 (Red Hat 8.3.1-2) (GCC) </p> <p>ah, GSS support is disabled in my case..<br/> but I gues you really meant not strlen(mop-&gt;mo_skpath), but rather sizeof(mop-&gt;mo_skpath) ?</p> <p>Yes it should be sizeof(mop-&gt;mo_skpath) here, my bad.</p> <p>with the above patches and the change I mentioned, I was able to build all the modules/utils with gcc8 on rhel8.</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/34711" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34711</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix double-free of params fields<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 01eb91f826be2531f707540e57266fc04f7d2c67</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34660/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34660/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: support for gcc8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6601661f96325b4971d0d1cb0be0fa01cc2ddc97</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34711/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34711/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix double-free of params fields<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7c7c39d84c98df3c6fe33c04c9e391529a86db53</p> <p>Hi Alex,<br/> I'm working on RHEL 8.0 Lustre client support (<a href="https://jira.whamcloud.com/browse/LU-12269" title="Support RHEL 8.0" class="issue-link" data-issue-key="LU-12269"><del>LU-12269</del></a>). With a bunch of patches applied, the build in <a href="https://review.whamcloud.com/34908" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34908</a> failed as follows:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>00:35:12 liblnetconfig.c: In function 'yaml_copy_peer_nids': 00:35:12 liblnetconfig.c:4321:3: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] 00:35:12 strncpy(nids[num], entry-&gt;cy_valuestring, 00:35:12 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 00:35:12 strlen(entry-&gt;cy_valuestring)); 00:35:12 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 00:35:12 liblnetconfig.c: In function 'lnet_expr2ips': 00:35:12 liblnetconfig.c:722:30: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size 104 [-Werror=format-truncation=] 00:35:12 "\"cannot parse ip_range '%s'\"", ip_range); 00:35:12 ^~ ~~~~~~~~ 00:35:12 liblnetconfig.c:720:3: note: 'snprintf' output between 27 and 154 bytes into a destination of size 128 00:35:12 snprintf(err_str, 00:35:12 ^~~~~~~~~~~~~~~~~ 00:35:12 LNET_MAX_STR_LEN, 00:35:12 ~~~~~~~~~~~~~~~~~ 00:35:12 "\"cannot parse ip_range '%s'\"", ip_range); 00:35:12 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 00:35:12 cc1: all warnings being treated as errors </pre> </div></div> <p>However, the output of configure was:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>00:21:24 checking for -Wno-format-truncation support... yes 00:21:24 checking for -Wno-stringop-truncation support... yes 00:21:24 checking for -Wno-stringop-overflow support... yes &lt;~snip~&gt; 00:21:28 EXTRA_KCFLAGS: -include /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/undef.h -include /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/config.h -g -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/libcfs/include -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/lnet/include -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/lustre/include -Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow </pre> </div></div> <p>"-Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow" were specified in EXTRA_KCFLAGS but they didn't work. gcc version is 8.2.1.</p> <p>Could you please advise?</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34662/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34662/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix build warnings for gcc8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5e0ad2afa62e9eb7cf4f48c394c6a84c74a02f2f</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34661/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34661/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> tests: fix gcc8 build warnings<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6733fbff9a682bcec5fdca6f7062c24f0fe27cfe</p> <p>Landed for 2.13</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35002" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35002</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: support for gcc8<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: ea462e2422153901f9b7115ca567911911768f67</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35003" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35003</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix double-free of params fields<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: e1432f444904fc016f173690ad0ab3683df753c6</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35004" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35004</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix build warnings for gcc8<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: f457cdc4ec5bc51f9491890b81e78e62dba20950</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35005" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35005</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> tests: fix gcc8 build warnings<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 72949fed0b1c17b5a1e57dc955c6ea2ae56400dc</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35003/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35003/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix double-free of params fields<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 0b86b935a16171120036260f4a0850e2e1245f46</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35004/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35004/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> utils: fix build warnings for gcc8<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 67533bcad5e937126c6e1da8fc13003816431858</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35005/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35005/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> tests: fix gcc8 build warnings<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 097c911244b53a044c4d4dfd33fdf12fd9a9cdd3</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35002/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35002/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11233" title="gcc8 support" class="issue-link" data-issue-key="LU-11233"><del>LU-11233</del></a> build: support for gcc8<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 2059acdcaee186256ce0eeae2f28b090058b0b39</p> Related LU-12269 LU-11838 Development Rank 1|i000jz: Rank (Obsolete) 9223372036854775807