https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11456 Lustre <p>mdt_object_sync() can skip sync if the version stored in the object is declared committed</p> LU-11456

MDT can skip sync if the object is synced yet

Improvement Minor Resolved Fixed Alex Zhuravlev Alex Zhuravlev Tue, 2 Oct 2018 14:08:32 +0000 Fri, 9 Aug 2019 15:09:28 +0000 Fri, 9 Aug 2019 15:09:28 +0000 Upstream Lustre 2.13.0 0 4 <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/33266" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33266</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11456" title="MDT can skip sync if the object is synced yet" class="issue-link" data-issue-key="LU-11456"><del>LU-11456</del></a> mdt: mdt_object_sync() can skip sync<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 03d8b8f3eb66c839041176e4f3149de4811f88c1</p> <p>I also see in the osd-zfs code:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">static</span> <span class="code-object">int</span> osd_object_sync(<span class="code-keyword">const</span> struct lu_env *env, struct dt_object *dt, __u64 start, __u64 end) { struct osd_device *osd = osd_obj2dev(osd_dt_obj(dt)); ENTRY; /* XXX: no other option than syncing the whole filesystem until we * support ZIL. If the object tracked the txg that it was last * modified in, it could pass that txg here instead of <span class="code-quote">"0"</span>. Maybe * the changes are already committed, so no wait is needed at all? */ <span class="code-keyword">if</span> (!osd-&gt;od_dt_dev.dd_rdonly) { <span class="code-keyword">if</span> (osd_object_sync_delay_us &lt; 0) txg_wait_synced(dmu_objset_pool(osd-&gt;od_os), 0ULL); <span class="code-keyword">else</span> udelay(osd_object_sync_delay_us); } RETURN(0); } </pre> </div></div> <p>yes, I think we can improve this a bit more as each OSD could check whether specific state has been already sent to disk and skip another skip just waiting for the previous one to complete.<br/> at least for ZFS this is relatively easy, need to think about ldiskfs..</p> <p>created <a href="https://jira.whamcloud.com/browse/LU-11462" title="osd-zfs can skip object sync if it&#39;s not dirty" class="issue-link" data-issue-key="LU-11462"><del>LU-11462</del></a> to track ZFS-specific solution.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33266/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33266/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11456" title="MDT can skip sync if the object is synced yet" class="issue-link" data-issue-key="LU-11456"><del>LU-11456</del></a> mdt: mdt_object_sync() can skip sync<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2291c21d174ac0a88f2c3b0551362079c963df16</p> <p>Landed for 2.13</p> Development Rank 1|i003dz: Rank (Obsolete) 9223372036854775807