https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11545 Lustre <p>I noticed when investigating <a href="https://jira.whamcloud.com/browse/LU-11446" title="ldiskfs inodes nlink mismatch with DNE" class="issue-link" data-issue-key="LU-11446">LU-11446</a> that debugfs is unhappy about the file type stored in the directory (verified if the "<tt>-c</tt>" option is used):</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>debugfs -c /dev/loop0 debugfs 1.44.3.wc1 debugfs: ncheck -c 164 Inode Pathname 164 /REMOTE_PARENT_DIR/0x200000204:0x1:0x0 &lt;--- BAD FILETYPE debugfs: ls -l /REMOTE_PARENT_DIR : : 164 100644 (17) 0 0 0 </pre> </div></div> <p>However, it appears the same problem is true for other directories, so it is not an issue with <tt>REMOTE_PARENT_DIR</tt>. I suspect it is instead a problem that <tt>ncheck -c</tt> is not masking off the <tt>dirdata</tt> flags from the filetype.</p> <p>Also, it looks like the usage message for "<tt>ls</tt>" is not including the "<tt>-D</tt>" option to print the dirdata fields.</p> LU-11545

debugfs: "ncheck -c" does not work correctly

Bug Minor Resolved Fixed Dongyang Li Andreas Dilger e2fsprogs Thu, 18 Oct 2018 21:15:25 +0000 Thu, 24 Feb 2022 03:18:01 +0000 Fri, 9 Apr 2021 20:07:28 +0000 Lustre 2.12.0 0 3 <p>There is a separate problem that "ncheck" does not return all of the links to a file, but that will be fixed in e2fsprogs-1.44.4 via commit:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>commit 4a30e2ae7ced039189ee438065b2f656d83e7e44 Author: Jaco Kroon &lt;jaco@uls.co.za&gt; AuthorDate: Thu Aug 2 20:06:46 2018 +0200 debugfs: fix ncheck so it handles hard links correctly Due to hard links inodes can have multiple names (except for folders), ncheck should find all of the names (equal to the number of links to the inodes, directories excepted), not names to the count of the provided inodes. Signed-off-by: Jaco Kroon &lt;jaco@uls.co.za&gt; Signed-off-by: Theodore Ts'o &lt;tytso@mit.edu&gt; </pre> </div></div> <p>I just tested with the old 1.42.13-wc6 seems the problem is worse:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> debugfs 1.42.13.wc6 (05-Feb-2017) debugfs:  ncheck -c 1048587 Inode Pathname1048587 /ROOT/testdir/1  &lt;--- BAD FILETYPE Segmentation fault </pre> </div></div> <p>ideally the fix and ls -D option along with man page changes should be part of the dirdata patch,</p> <p>should we rebase to 1.44.4 to include 4a30e2ae7ced039189ee438065b2f656d83e7e44 also we can drop</p> <p>fddc423dc6353552772969d70cec08e8378d8e57 Fix compile error and warnings for old gcc versions which got into 1.44.4? The dirdata patch can be fixed during the rebase.</p> <p>Rebasing to 1.44.4 would also be good, and including the fix into the dirdata patch would also be good.</p> <p>Just created master-lustre-test branch again, it's the 1.44.4 with the fixed up dirdata patch and everything else.</p> <p>make fullcheck looks good.</p> <p>Li Dongyang (dongyangli@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/33574" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33574</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11545" title="debugfs: &quot;ncheck -c&quot; does not work correctly" class="issue-link" data-issue-key="LU-11545"><del>LU-11545</del></a> debugfs: mask off dir_data flags for ncheck<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre<br/> Current Patch Set: 1<br/> Commit: b3c19d01c64ab6046d28a671d33d7e2ddb40387c</p> <p>I've noticed a bunch of patches on gerrit for master-lustre, so let's also track the patches for master-lustre branch. I will note which patches are needed when we move the 1.44.4 or when 1.44.5 is released.</p> <p>Andreas Dilger (adilger@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33574/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33574/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11545" title="debugfs: &quot;ncheck -c&quot; does not work correctly" class="issue-link" data-issue-key="LU-11545"><del>LU-11545</del></a> debugfs: mask off dir_data flags for ncheck<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre<br/> Current Patch Set: <br/> Commit: 97a5284dec2336fef87482ba3509c7ba6353c678</p> <p>This was fixed in 1.44.3-wc1</p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/44388/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/44388/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11545" title="debugfs: &quot;ncheck -c&quot; does not work correctly" class="issue-link" data-issue-key="LU-11545"><del>LU-11545</del></a> debugfs: allow &lt;inode&gt; for ncheck<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre<br/> Current Patch Set: <br/> Commit: b15a0ad2fb8703c87dedcf0b2af26e3e750bcb76</p> Related LU-11446 LU-11440 Development Rank 1|i004j3: Rank (Obsolete) 9223372036854775807 Severity