https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11614 Lustre <p>Modify checkpatch.pl to ignore 80 Character warning for CERROR, CWARN and CDEBUG. </p> <p> </p> <p> </p> LU-11614

Modify checkpatch.pl to ignore 80 Character warning for CERROR, CWARN and CDEBUG

Improvement Minor Open Unresolved Arshad Hussain Arshad Hussain Sun, 4 Nov 2018 07:12:10 +0000 Wed, 9 Mar 2022 21:06:22 +0000 0 4 <p>It would appear that the following patch is supposed to fix this, but it doesn't seem to be effective?</p> <p>Is it possible that the checkpatch.pl script being run against patches in Gerrit is not actually the <tt>contrib/scripts/checkpatch.pl</tt>, but another copy that is not being updated? At least some quick testing shows that CDEBUG does not generate an error locally.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Author: Andreas Dilger &lt;andreas.dilger@intel.com&gt; AuthorDate: Fri Jul 14 23:57:23 2017 -0600 LU-7589 build: update checkpatch to ~4.13-rc1 kernel Update checkpatch.pl to v4.12-11743-g96d0d83 kernel version. This version includes new functionality that allows us to replace the Lustre specific dep_functions and dep_includes checks added in our local version with the "spelling.txt" file. Allow CDEBUG/CERROR/LCONSOLE/DEBUG_REQ text strings to exceed 80 columns, as with upstream printk messages. Test-Parameters: trivial Signed-off-by: Andreas Dilger &lt;andreas.dilger@intel.com&gt; Change-Id: I2a16bbd85722b15eb9188eb504bac3a2f63ebbe5 Reviewed-on: https://review.whamcloud.com/28055 </pre> </div></div> <p>Thanks Andreas. Ok, I see. And this is what I see on my dev environment. There is definitely some difference in what checkpatch.pl reports on my local and on gerrit.</p> <p>Thanks</p> <p>On latest master.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [lustre-release]# git log --format=oneline -2 715b3dac37748daeeecb44b8e7f4da96f6e7cc6f LU-6142 lod: Fix style issues <span class="code-keyword">for</span> lod_dev.c ccf3674c9ca3ed8918c49163007708d1ae5db6f5 LU-10472 osd-ldiskfs: T10PI between RPC and BIO [lustre-release]# </pre> </div></div> <p>The checksum of checkpatch.pl is</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [lustre-release]# md5sum ./contrib/scripts/checkpatch.pl 4db6466fb2029443b024740597bbce87 ./contrib/scripts/checkpatch.pl [lustre-release]# </pre> </div></div> <p>On local dev environment it throws single 80 char warning</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> git show | ./contrib/scripts/checkpatch.pl &lt;SNIP&gt; WARNING: line over 80 characters #78: FILE: lustre/lod/lod_dev.c:323: + CERROR(<span class="code-quote">"%s broken update record! index %u "</span>DFID<span class="code-quote">".%u : rc = %d\n"</span>, &lt;SNIP&gt; </pre> </div></div> <p>However on the gerrit it throws 3 80 char warnings. Here is the gerrit review link : <a href="https://review.whamcloud.com/#/c/33594/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/33594/</a></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &lt;snip&gt; 3 style warning(s). For more details please see [https:<span class="code-comment">//wiki.hpdd.intel.com/display/PUB/Coding+Guidelines] </span> lustre/lod/lod_dev.c Line 265: (style) line over 80 characters Line 323: (style) line over 80 characters Line 1148: (style) line over 80 characters &lt;snip&gt; </pre> </div></div> Related LU-7589 Development Rank 1|i005o7: Rank (Obsolete) 9223372036854775807