[LU-11735] o2iblnd - bad check for fmr

Related — Thu, 24 Sep 2020 14:00:08 +0000

9b790ba0f5606c0a91563828fa43f5e4ae210425 LU-11152 lnd: test fpo_fmr_poool pointer instead of special bool

Introduced an issue.

You can't perform the following check:

if (!IS_ERR_OR_NULL(fpo->fmr.fpo_fmr_pool))

because

 340 »·······union {                                           
 341 »·······»·······struct {  
 342 »·······»·······»·······struct ib_fmr_pool *fpo_fmr_pool; /* IB FMR pool */
 343 »·······»·······} fmr;                                                          
 344 »·······»·······struct { /* For fast registration */
 345 »·······»·······»·······struct list_head  fpo_pool_list;
 346 »·······»·······»·······int»····»·······  fpo_pool_size;
 347 »·······»·······} fast_reg;                                       
 348 »·······};

It's part of a union so if we have fast reg enabled, then it's possible that the check is successful even though we don't have fmr enabled.

Whamcloud Community JIRA

[LU-11735] o2iblnd - bad check for fmr