https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11755 Lustre <p>In ns_is_{client,server}(), (ns-&gt;ns_client == LDLM_NAMESPACE_CLIENT || ns-&gt;ns_client == LDLM_NAMESPACE_SERVER) implies that (!(ns-&gt;ns_client &amp; ~(LDLM_NAMESPACE_CLIENT |<br/> LDLM_NAMESPACE_SERVER))) is also true, so the latter LASSERT() could be removed from ns_is_{client,server}().</p> <p> </p> <p>This might be an inconsequential issue. I have not checked if gcc optimizes-out one of the LASSERT()s.</p> LU-11755

Remove redundant LASSERT() in ns_is_{client,server}()

Bug Trivial Resolved Fixed Nikitas Angelinas Nikitas Angelinas patch Tue, 11 Dec 2018 04:42:09 +0000 Thu, 20 Jun 2019 22:30:23 +0000 Fri, 4 Jan 2019 05:35:12 +0000 Lustre 2.11.0 Lustre 2.13.0 Lustre 2.12.3 0 4 <p>Sorry, I meant to say "if gcc optimizes-out the first LASSERT()", in the description.</p> <p>Nikitas Angelinas (nangelinas@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/33822" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33822</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11755" title="Remove redundant LASSERT() in ns_is_{client,server}()" class="issue-link" data-issue-key="LU-11755"><del>LU-11755</del></a> ldlm: remove LASSERT() in ns_is_</p> {client,server} <p>()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2fff402f6bd8234f4598ba05b7323939afbd52d0</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33822/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33822/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11755" title="Remove redundant LASSERT() in ns_is_{client,server}()" class="issue-link" data-issue-key="LU-11755"><del>LU-11755</del></a> ldlm: remove LASSERT() in ns_is_</p> {client,server} <p>()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0af247b17619f586702b0ad37f0796bdf783b11c</p> <p>Landed for 2.13</p> <p>Hi  Nikitas Angelinas,</p> <p>This ticket was opened as a <b>BUG</b>, and patch has link to Cray-bug-id: LUS-6762 (Sorry that I can't access it),  so did you really hit similar bugs? or patch is only a cleanup.</p> <p>Hi Gu Zheng,</p> <p>Sorry, I may have opened this as the wrong type of ticket. We did not hit any bugs related to this; it is only a cleanup. Should it be an improvement instead of a bug ticket?</p> <p>Hi  @Nikitas,</p> <p>I see.</p> <p>The ticket is closed, just let it go.</p> <p>I pinged you for that, because we hit a bug on this LASSERT(you patch removed), it's really strange, you know ns-&gt;ns_client is only used for namespace type check, and it'll never be changed once inited (new ldlm_namespace), we never hit similar problem before.</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35193" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35193</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11755" title="Remove redundant LASSERT() in ns_is_{client,server}()" class="issue-link" data-issue-key="LU-11755"><del>LU-11755</del></a> ldlm: remove LASSERT() in ns_is_</p> {client,server} <p>()<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: d31110348f4f264cc3c04a7ada972b35cb01c5d8</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35193/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35193/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11755" title="Remove redundant LASSERT() in ns_is_{client,server}()" class="issue-link" data-issue-key="LU-11755"><del>LU-11755</del></a> ldlm: remove LASSERT() in ns_is_</p> {client,server} <p>()<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 19aefacda4623fb34b09f499ecf087fcb7b968f5</p> Related Development Rank 1|i007qn: Rank (Obsolete) 9223372036854775807 Severity