Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-11807] ext4: fix race when setting the bitmap corrupted flag https://jira.whamcloud.com/browse/LU-11807 Lustre <p>A patch landed upstream to fix an ext4 issue, but this has not been landed for ldiskfs. </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>commit 9af0b3d1257756394ebbd06b14937b557e3a756b Author: Wang Shilong &lt;wshilong@ddn.com&gt; Date: Sun Jul 29 17:27:45 2018 -0400 ext4: fix race when setting the bitmap corrupted flag </pre> </div></div> LU-11807 ext4: fix race when setting the bitmap corrupted flag Bug Minor Open Unresolved WC Triage Andreas Dilger Tue, 18 Dec 2018 16:31:16 +0000 Fri, 21 Jan 2022 00:03:34 +0000 0 4 <p>There is also a new patch posted to linux-ext4 that fixes a bug in the above patch:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Commit 9af0b3d12577 "ext4: fix race when setting the bitmap corrupted flag" want to fix race between setting inode/block bitmap corrupted flag and reducing free group inodes/clusters counter to prevent multiple frees. But ext4_test_and_set_bit() will invoke __test_and_set_bit() which is non-atomic, so the race is still there. Fix this by invoke test_and_set_bit() instead. Fixes: 9af0b3d12577 ("ext4: fix race when setting the bitmap corrupted flag") Signed-off-by: zhangyi (F) &lt;yi.zhang@huawei.com&gt; --- fs/ext4/ext4.h | 6 ++++++ fs/ext4/super.c | 6 ++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 3f89d0a..755ba14 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2888,6 +2888,12 @@ struct ext4_group_info { (test_bit(EXT4_GROUP_INFO_BBITMAP_CORRUPT_BIT, &amp;((grp)-&gt;bb_state))) #define EXT4_MB_GRP_IBITMAP_CORRUPT(grp) \ (test_bit(EXT4_GROUP_INFO_IBITMAP_CORRUPT_BIT, &amp;((grp)-&gt;bb_state))) +#define EXT4_MB_GRP_TEST_AND_SET_BBITMAP_CORRUPT(grp) \ + (test_and_set_bit(EXT4_GROUP_INFO_BBITMAP_CORRUPT_BIT, \ + &amp;((grp)-&gt;bb_state))) +#define EXT4_MB_GRP_TEST_AND_SET_IBITMAP_CORRUPT(grp) \ + (test_and_set_bit(EXT4_GROUP_INFO_IBITMAP_CORRUPT_BIT, \ + &amp;((grp)-&gt;bb_state))) </pre> </div></div> <p>Andreas, thanks for opening this ticket, will work on this.</p> <p>This is fixed in RHEL8, but not RHEL7.x.</p> Development Rank 1|i008c7: Rank (Obsolete) 9223372036854775807 Severity