https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11828 Lustre <p>For my linux lustre client I always test with invariant checking enabled. With the addition of PFL this exposed an old bug when running the sanity-pfl.sh test. </p> <p>2018-12-25T21:12:38.969914-05:00 ninja84.ccs.ornl.gov kernel: Lustre: DEBUG MARKER: == sanity-pfl test 0: Create full components f</p> <p>ile, no reused OSTs ==================================== 21:12:38 (1545790358)</p> <p>2018-12-25T21:12:39.107708-05:00 ninja84.ccs.ornl.gov kernel: LustreError: 16009:0:(cl_io.c:439:cl_io_iter_fini()) ASSERTION( io-&gt;</p> <p>ci_state == CIS_UNLOCKED ) failed:</p> <p>2018-12-25T21:12:39.107772-05:00 ninja84.ccs.ornl.gov kernel: LustreError: 16009:0:(cl_io.c:439:cl_io_iter_fini()) LBUG</p> <p>2018-12-25T21:12:39.107804-05:00 ninja84.ccs.ornl.gov kernel: Pid: 16009, comm: dd 4.20.0-rc6+ #1 SMP PREEMPT Sat Dec 15 11:22:06</p> <p>EST 2018</p> <p>2018-12-25T21:12:39.116789-05:00 ninja84.ccs.ornl.gov kernel: Call Trace:</p> <p>2018-12-25T21:12:39.120246-05:00 ninja84.ccs.ornl.gov kernel: libcfs_call_trace+0x8b/0xc0 <span class="error">&#91;libcfs&#93;</span></p> <p>2018-12-25T21:12:39.125936-05:00 ninja84.ccs.ornl.gov kernel: lbug_with_loc+0x41/0x90 <span class="error">&#91;libcfs&#93;</span></p> <p>2018-12-25T21:12:39.131287-05:00 ninja84.ccs.ornl.gov kernel: cl_io_iter_fini+0x10c/0x110 <span class="error">&#91;obdclass&#93;</span></p> <p>2018-12-25T21:12:39.137161-05:00 ninja84.ccs.ornl.gov kernel: cl_io_loop+0x46/0x220 <span class="error">&#91;obdclass&#93;</span></p> <p>2018-12-25T21:12:39.142525-05:00 ninja84.ccs.ornl.gov kernel: cl_setattr_ost+0x1ed/0x2a0 <span class="error">&#91;lustre&#93;</span></p> <p>2018-12-25T21:12:39.148135-05:00 ninja84.ccs.ornl.gov kernel: ll_setattr_raw+0x7b0/0x9a0 <span class="error">&#91;lustre&#93;</span></p> <p>2018-12-25T21:12:39.153767-05:00 ninja84.ccs.ornl.gov kernel: notify_change+0x1dc/0x430</p> <p>2018-12-25T21:12:39.158523-05:00 ninja84.ccs.ornl.gov kernel: do_truncate+0x72/0xc0</p> <p>2018-12-25T21:12:39.162910-05:00 ninja84.ccs.ornl.gov kernel: do_sys_ftruncate+0xf5/0x160</p> <p>2018-12-25T21:12:39.167853-05:00 ninja84.ccs.ornl.gov kernel: do_syscall_64+0x68/0x38f</p> <p>2018-12-25T21:12:39.172474-05:00 ninja84.ccs.ornl.gov kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9</p> <p>2018-12-25T21:12:39.178480-05:00 ninja84.ccs.ornl.gov kernel: 0xffffffffffffffff</p> <p>2018-12-25T21:12:39.182552-05:00 ninja84.ccs.ornl.gov kernel: Kernel panic - not syncing: LBUG</p> Any lustre client using PFL with lustre build with invariants enabled LU-11828

PFL crashes when invariant checking is enabled

Bug Minor Resolved Fixed James A Simmons James A Simmons Wed, 26 Dec 2018 14:26:23 +0000 Wed, 30 Jan 2019 19:26:17 +0000 Wed, 30 Jan 2019 19:26:17 +0000 Upstream Lustre 2.12.0 Lustre 2.10.6 Lustre 2.13.0 0 4 <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/33915" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33915</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11828" title="PFL crashes when invariant checking is enabled" class="issue-link" data-issue-key="LU-11828"><del>LU-11828</del></a> clio: fix incorrect invariant in cl_io_iter_fini()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 514cc090ebe76baf0d29966df46ab1f6c033de24</p> <p>During review of 33915 there was confusion about the state names used by <tt>cl_io_loop()</tt> because the state namess don't match with the method names. Currently, it looks like:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>cl_io_iter_init() -&gt; CIS_IT_STARTED cl_io_start() -&gt; CIS_IO_GOING, but that is unrelated to "CIS_IT_STARTED" cl_io_end() -&gt; CIS_IO_FINISHED, also unrelated to CIS_IT_STARTED cl_io_iter_fini() -&gt; CIS_IT_ENDED, unrelated to cl_io_end() </pre> </div></div> <p>This whole state machine could use some renaming to be a bit more sane. For example, it would be better to use:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>cl_io_iter_init() -&gt; CIS_IT_INITALIZED cl_io_start() -&gt; cl_io_begin() and use CIS_IO_BEGUN for the state cl_io_end() -&gt; CIS_IO_ENDED cl_io_iter_fini() -&gt; CIS_IT_FINALIZED </pre> </div></div> <p>Should we open a new ticket or continue here?</p> <p>Either is probably ok if the second patch is available soon. Otherwise it should be separated. </p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33915/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33915/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11828" title="PFL crashes when invariant checking is enabled" class="issue-link" data-issue-key="LU-11828"><del>LU-11828</del></a> clio: fix incorrect invariant in cl_io_iter_fini()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8160b9bdf16cc8ed887216b0a9a83932b86d5705</p> <p>Landed for 2.13</p> Development Epic/Theme patch upstream Rank 1|i008p3: Rank (Obsolete) 9223372036854775807 Severity