<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 02:47:45 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-11882] OST recreated objects gets badness mark from e2fsck</title>
                <link>https://jira.whamcloud.com/browse/LU-11882</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;e2fsck spends 72 hours to check&#160;~113T OST. Most time in phase 2.&lt;/p&gt;

&lt;p&gt;Profiler shows that most expensive path is:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
e2fsck_run -&amp;gt; e2fsck_pass2 -&amp;gt;  check_dir_block -&amp;gt; e2fsck_process_bad_inode -&amp;gt; e2fsck_read_inode
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;After adding -d option we get millions of such messages:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
e2fsck_pass1:1543: increase inode 12485987 badness 0 to 2
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Which correspond to this piece of code:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (EXT4_XTIME_ANCIENT(ctx, sb, inode-&amp;gt;i_ctime,
                                            ctx-&amp;gt;time_fudge))
                        e2fsck_mark_inode_bad(ctx, ino, BADNESS_HIGH);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Code check if ctime is too old. But Lustre FS adds precreated object with zeroed time. So every such object assumed as bad by e2fsck. By some reasons (this is other issue topic) we get millions of precreated files and e2fsck spends a lot of time to process this file during phase 2.&lt;/p&gt;

&lt;p&gt;After removing check above e2fsck completes its work after 20 minutes.&lt;/p&gt;

&lt;p&gt;Two possible solutions are suggested: 1) remove this check, because having zeroed chime is possible situation  for Lustre FS 2) remove inode badness patches. Does it give enough advantages for such overhead.&lt;/p&gt;</description>
                <environment></environment>
        <key id="54626">LU-11882</key>
            <summary>OST recreated objects gets badness mark from e2fsck</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.whamcloud.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.whamcloud.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="artem_blagodarenko">Artem Blagodarenko</assignee>
                                    <reporter username="artem_blagodarenko">Artem Blagodarenko</reporter>
                        <labels>
                    </labels>
                <created>Tue, 22 Jan 2019 14:58:23 +0000</created>
                <updated>Thu, 30 May 2019 12:09:45 +0000</updated>
                            <resolved>Thu, 30 May 2019 12:09:31 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>5</watches>
                                                                            <comments>
                            <comment id="240547" author="adilger" created="Tue, 22 Jan 2019 17:43:15 +0000"  >&lt;p&gt;The other question is why you have millions of precreated objects?  I guess they are stripes for files that were never used?&lt;/p&gt;

&lt;p&gt;In any case, rather than disable this case completely, it would be trivial to make a special case for ctime == 0 if SUID/SGID are also set. That would catch the specific case of Lustre precreated objects without disabling the inode badness completely. &lt;/p&gt;</comment>
                            <comment id="240548" author="adilger" created="Tue, 22 Jan 2019 17:46:27 +0000"  >&lt;p&gt;Note that &quot;badness = 2&quot; is not enough for e2fsck to consider the inode corrupt, just one part of the possibility that there is something wrong with it. It needs &quot;badness &amp;gt; 7&quot; to be considered corrupt. &lt;/p&gt;</comment>
                            <comment id="240720" author="gerrit" created="Fri, 25 Jan 2019 16:47:57 +0000"  >&lt;p&gt;Artem Blagodarenko (c17828@cray.com) uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/34113&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/34113&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-11882&quot; title=&quot;OST recreated objects gets badness mark from e2fsck&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-11882&quot;&gt;&lt;del&gt;LU-11882&lt;/del&gt;&lt;/a&gt; e2fsck: zero date is not inode badness&lt;br/&gt;
Project: tools/e2fsprogs&lt;br/&gt;
Branch: master-lustre&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: b15477ef0bd382c9c349a94e089c696fa59c5acf&lt;/p&gt;</comment>
                            <comment id="247823" author="gerrit" created="Tue, 28 May 2019 06:25:31 +0000"  >&lt;p&gt;Andreas Dilger (adilger@whamcloud.com) merged in patch &lt;a href=&quot;https://review.whamcloud.com/34113/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/34113/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-11882&quot; title=&quot;OST recreated objects gets badness mark from e2fsck&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-11882&quot;&gt;&lt;del&gt;LU-11882&lt;/del&gt;&lt;/a&gt; e2fsck: zero date is not inode badness&lt;br/&gt;
Project: tools/e2fsprogs&lt;br/&gt;
Branch: master-lustre&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: c478288dddf485459115e14c57470c4466740e8d&lt;/p&gt;</comment>
                            <comment id="248043" author="artem_blagodarenko" created="Thu, 30 May 2019 12:09:31 +0000"  >&lt;p&gt;Change has been successfully cherry-picked as c478288dddf485459115e14c57470c4466740e8d&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10322">
                    <name>Gantt End to Start</name>
                                                                <inwardlinks description="has to be done after">
                                        <issuelink>
            <issuekey id="54751">LU-11915</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="38564">LU-8465</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i00a27:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>