https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11889 Lustre <p>because osd-zfs doesn't maintain cache hit/miss stats, there is just no regular API for this at the moment.</p> zfs LU-11889

sanity test 156 fails on ZFS: roc_hit not safe to use

Bug Trivial Open Unresolved Alex Zhuravlev Alex Zhuravlev Sat, 26 Jan 2019 10:39:10 +0000 Thu, 21 Mar 2019 15:52:00 +0000 Lustre 2.10.7 Lustre 2.12.1 0 4 <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/34114" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34114</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11889" title="sanity test 156 fails on ZFS: roc_hit not safe to use" class="issue-link" data-issue-key="LU-11889">LU-11889</a> tests: disable sanity/156 for ZFS OST<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e138216b361324b2fb4da7384b07f6f086d29649</p> <p>Are there examples of this failing in autotest?</p> <p>yes, I found number of failures like this:<br/> <a href="https://testing.whamcloud.com/test_sets/f337b3f4-20cb-11e9-af70-52540065bddc" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/test_sets/f337b3f4-20cb-11e9-af70-52540065bddc</a></p> <p>It looks like this bug originated in <a href="https://jira.whamcloud.com/browse/LU-2261" title="Add cache stats to zfs osd" class="issue-link" data-issue-key="LU-2261"><del>LU-2261</del></a>, which enabled sanity test_156 for ZFS when <tt>brw_stats</tt> was enabled for ZFS, even though the <tt>cache_hits</tt> tunable is not actually being tracked for ZFS. The error went unnoticed because there was a syntax error in the "skip" logic until patch "<tt><a href="https://jira.whamcloud.com/browse/LU-11607" title="Reduce repeated function calls in Lustre test suites" class="issue-link" data-issue-key="LU-11607"><del>LU-11607</del></a> tests: create routine to get Lustre env</tt>" landed, which properly enabled the test for ZFS and proceeded to cause all the ZFS tests to fail.</p> <p>Andreas Dilger (adilger@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34114/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34114/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11889" title="sanity test 156 fails on ZFS: roc_hit not safe to use" class="issue-link" data-issue-key="LU-11889">LU-11889</a> tests: disable sanity/156 for ZFS OST<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 42c4dab3c817f9f03efe457fd33e946ed68fab14</p> <p>Alex, is it possible to easily implement the <tt>cache_hits</tt> tracking for ZFS?</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=adilger" class="user-hover" rel="adilger">adilger</a> I checked ZFS sources and it looks that there is no easy way to get stats for Lustre-related dbufs - all stats ZFS collects are global. We could pre-lookup dbufs and check its status, but that would be +1 lookup for every dbuf which isn't free. not sure we want to pay that price.</p> Related LU-2261 LU-11607 LU-5375 Development Rank 1|i00abb: Rank (Obsolete) 9223372036854775807 Severity