https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-11924 Lustre <p>osp_sync_process_committed() takes list of osp_job_req_args and cancels llog records one by one. In most cases these records belongs to the same llog file, so they can be canceled together at single call to open/transaction/changing bitmap/disk write...<br/> It could increase a performance.</p> LU-11924

Combine cancellation of llog records at osp_sync_process_committed

Improvement Minor Resolved Fixed Alexander Boyko Alexander Boyko patch Tue, 5 Feb 2019 11:48:47 +0000 Mon, 12 Dec 2022 17:05:26 +0000 Tue, 19 Feb 2019 06:15:23 +0000 Lustre 2.13.0 0 4 <p>Alexandr Boyko (c17825@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/34179" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34179</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11924" title="Combine cancellation of llog records at osp_sync_process_committed" class="issue-link" data-issue-key="LU-11924"><del>LU-11924</del></a> osp: combine llog cancel operations<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1c827535c555683fd6237c8750e0c15a20dcadf2</p> <p>I've tested the difference of osp_sync_process_commit time locally  with ftrace using test 106 conf-sanity which do createmany/unlinkmany operations. </p> <p>echo osp_sync_process_committed &gt; set_ftrace_filter<br/> echo 1 &gt; function_profile_enabled</p> <p>Without patch</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 119433 320932.0 us 2.687 us 46349.58 us Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 113400 289397.6 us 2.552 us 44790.63 us Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 106545 447368.3 us 4.198 us 102860.1 us Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 65637 235872.5 us 3.593 us 61195.10 us </pre> </div></div> <p>And with patch</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 98916 143369.9 us 1.449 us 28541.24 us Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 103008 214585.1 us 2.083 us 26861.06 us Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 88466 145561.5 us 1.645 us 11074.07 us Function Hit Time Avg s^2 -------- --- ---- --- --- osp_sync_process_committed 81857 85347.70 us 1.042 us 11470.52 us </pre> </div></div> <p>The testing shows that average time is less for the patched version.</p> <p> </p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34179/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34179/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-11924" title="Combine cancellation of llog records at osp_sync_process_committed" class="issue-link" data-issue-key="LU-11924"><del>LU-11924</del></a> osp: combine llog cancel operations<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6d733210206561f73b5c29126b4012cd7a8c0d18</p> <p>Landed for 2.13</p> Duplicate Gantt End to Start Related LU-11896 Development Rank 1|i00ayv: Rank (Obsolete) 9223372036854775807