https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1229 Lustre <p>Loading modules from /Users/shadow/work/lustre/work/BUGS/CLSTR-136/lustre/lustre/tests/..<br/> ../libcfs/libcfs/libcfs options: 'libcfs_debug_mb=100 options libcfs libcfs_debug=-1 options libcfs libcfs_subsystem_debug=-1 options libcfs libcfs_panic_on_lbug=0'<br/> insmod: error inserting '/Users/shadow/work/lustre/work/BUGS/CLSTR-136/lustre/lustre/tests/../../libcfs/libcfs/libcfs.ko': -1 Unknown symbol in module</p> <p>that is result more then one parameter in modprobe.conf</p> <ol> <li>cat /etc/modprobe.d/Lustre<br/> options libcfs libcfs_debug_mb=100<br/> options libcfs libcfs_debug=-1<br/> options libcfs libcfs_subsystem_debug=-1<br/> options libcfs libcfs_panic_on_lbug=0</li> </ol> <p>options mdt mdt_num_threads=5</p> LU-1229

test-framework not able to set module parameters from modprobe.conf

Bug Minor Resolved Fixed Keith Mannthey Alexey Lyashkov patch Fri, 16 Mar 2012 23:32:19 +0000 Tue, 16 Apr 2013 22:32:49 +0000 Tue, 16 Apr 2013 22:32:49 +0000 Lustre 2.1.0 Lustre 2.2.0 Lustre 2.1.1 Lustre 2.4.0 0 5 <p>Looks like this should be straightforward to fix. The current code in load_module() does:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> set -- $(grep -P "^options\\s+${BASE}" $MODPROBECONF) # Get rid of "options $module" (($# &gt; 0)) &amp;&amp; shift 2 </pre> </div></div> <p>but it could do something like the following to handle multi-line options:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> set -- $(grep "^options[ \t]*$BASE" | sed -e 's/.*$BASE//') </pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">--- a/lustre/tests/test-framework.sh +++ b/lustre/tests/test-framework.sh @@ -278,6 +278,8 @@ module_loaded () { # load_module() { local optvar + local opt + EXT=<span class="code-quote">".ko"</span> module=$1 shift @@ -294,18 +296,18 @@ load_module() { eval set -- \$$optvar <span class="code-keyword">if</span> [ $# -eq 0 -a -n <span class="code-quote">"$MODPROBECONF"</span> ]; then # Nothing in $MODOPTS_&lt;MODULE&gt;; <span class="code-keyword">try</span> modprobe.conf - set -- $(grep -P <span class="code-quote">"^options\\s+${BASE}"</span> $MODPROBECONF) + opt=$(grep -P <span class="code-quote">"^options\\s+${BASE}"</span> $MODPROBECONF | sed -e <span class="code-quote">"s/options\(\\s\)\+${BASE}/ /g"</span>) # Get rid of <span class="code-quote">"options $module"</span> - (($# &gt; 0)) &amp;&amp; shift 2 + #(($# &gt; 0)) &amp;&amp; shift 2 # Ensure we have accept=all <span class="code-keyword">for</span> lnet <span class="code-keyword">if</span> [ $(basename $module) = lnet ]; then # OK, <span class="code-keyword">this</span> is a bit wordy... local arg accept_all_present=<span class="code-keyword">false</span> - <span class="code-keyword">for</span> arg in <span class="code-quote">"$@"</span>; <span class="code-keyword">do</span> + <span class="code-keyword">for</span> arg in <span class="code-quote">"$opt"</span>; <span class="code-keyword">do</span> [ <span class="code-quote">"$arg"</span> = accept=all ] &amp;&amp; accept_all_present=<span class="code-keyword">true</span> done - $accept_all_present || set -- <span class="code-quote">"$@"</span> accept=all + $accept_all_present || set -- <span class="code-quote">"$opt"</span> accept=all fi fi fi @@ -318,14 +320,14 @@ load_module() { [ -f ${LUSTRE}/../lnet/selftest/${module}${EXT} ]; then insmod ${LUSTRE}/../lnet/selftest/${module}${EXT} elif [ -f ${LUSTRE}/${module}${EXT} ]; then - insmod ${LUSTRE}/${module}${EXT} <span class="code-quote">"$@"</span> + insmod ${LUSTRE}/${module}${EXT} <span class="code-quote">"$opt"</span> <span class="code-keyword">else</span> # must be testing a <span class="code-quote">"make install"</span> or <span class="code-quote">"rpm"</span> installation # note failed to load ptlrpc_gss is considered not fatal <span class="code-keyword">if</span> [ <span class="code-quote">"$BASE"</span> == <span class="code-quote">"ptlrpc_gss"</span> ]; then - modprobe $BASE <span class="code-quote">"$@"</span> 2&gt;/dev/<span class="code-keyword">null</span> || echo <span class="code-quote">"gss/krb5 is not supported"</span> + modprobe $BASE <span class="code-quote">"$opt"</span> 2&gt;/dev/<span class="code-keyword">null</span> || echo <span class="code-quote">"gss/krb5 is not supported"</span> <span class="code-keyword">else</span> - modprobe $BASE <span class="code-quote">"$@"</span> + modprobe $BASE <span class="code-quote">"$opt"</span> fi fi } </pre> </div></div> <p>i didn't like plays with "$@" <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>remote: New Changes:<br/> remote: <a href="http://review.whamcloud.com/2342" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2342</a><br/> remote: </p> <p>Alexey, Are you going to peruse acceptance of this code? </p> <p>Seeing some problem with this code. A shell debug run shows this:</p> <p>load_module ptlrpc/gss/ptlrpc_gss<br/> + local optvar<br/> + EXT=.ko<br/> + module=ptlrpc/gss/ptlrpc_gss<br/> + shift<br/> ++ basename ptlrpc/gss/ptlrpc_gss .ko<br/> + BASE=ptlrpc_gss<br/> + module_loaded ptlrpc_gss<br/> + /sbin/lsmod<br/> + grep -q '^\&lt;ptlrpc_gss\&gt;'<br/> + '<span class="error">&#91;&#39; 0 -eq 0 &#39;&#93;</span>'<br/> ++ basename ptlrpc/gss/ptlrpc_gss<br/> ++ tr a-z A-Z<br/> + optvar=MODOPTS_PTLRPC_GSS<br/> ++ set &#8211;<br/> + '<span class="error">&#91;&#39; 0 -eq 0 -a -n /etc/modprobe.d/lustre.conf &#39;&#93;</span>'<br/> + local opt<br/> ++ grep -P '^options\s+ptlrpc_gss' /etc/modprobe.d/lustre.conf<br/> + opt=</p> <p>Then its stops running</p> <p>My system really doesn't like that grep. What I found that does work is </p> <p>local opt<br/> opt=$(awk '/^\option.*BASE/</p> {print substr($3, index($3,$N))} <p>' $MODPROBECONF)<br/> set &#8211; $(echo $opt | sed -e "s/\n/ /g")</p> <p>As a side note I tested this with conf-sanity 53 to see if it fixed it, Nope <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/><br/> That set of test uses it own functions to manage the modprobe options. I'm hoping<br/> we can cleanup this up with this patch.</p> <p>James, </p> <p>did you system is debian based?<br/> but anyway that for finding solution - i will repost a patch.</p> <p>No its a RHEL6 image. Mind you its a stripped down image. Besides this fix I'm investigation why config-sanity 53 fails dues to modprobe options. I hope to have fix for that as well.</p> <p>Xyratex-bug-id: <a href="http://jira-nss.xy01.xyratex.com:8080/browse/MRP-657" class="external-link" target="_blank" rel="nofollow noopener">MRP-657</a></p> <p>Found the problem Alexey. My bash environment was turning off globing. Anyways I have a patch at</p> <p>Patch at <a href="http://review.whamcloud.com/#change,2342" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,2342</a></p> <p>Patch is landed to master.</p> Development Rank 1|hzvh6f: Rank (Obsolete) 6432 Severity Story Points 1.0