https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12324 Lustre <p>It was observed that when we have changelogs enabled there's a getxattr path that can create a transaction even if getxattr itself only wants the xattr size and there's no reply buffer</p> <p>This results in a NULL pointer deref in lustre_msg_set_transno because rq_rep is NULL like this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[ 1826.910143] RIP: 0010:[&lt;ffffffffc0e5012c&gt;] [&lt;ffffffffc0e5012c&gt;] lustre_msg_set_transno+0xc/0xa0 [ptlrpc] [ 1826.922696] RSP: 0018:ffff8e7d974df940 EFLAGS: 00010282 [ 1826.930429] RAX: 0000002700000008 RBX: ffff8e5d4c5bb000 RCX: ffff8e5d4e9280b0 [ 1826.940192] RDX: 0000000000000000 RSI: 0000002700000008 RDI: 0000000000000000 [ 1826.949927] RBP: ffff8e7d974df950 R08: ffff8e7d913d8a40 R09: 0000000000000030 [ 1826.959650] R10: 0000000000000000 R11: ffff8e7d974df72e R12: ffff8e7d97477000 [ 1826.969402] R13: ffff8e7d913d8a40 R14: ffff8e7db37c1c80 R15: 0000000000000000 [ 1826.979089] FS: 0000000000000000(0000) GS:ffff8e7dbdfc0000(0000) knlGS:0000000000000000 [ 1826.989827] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1826.997935] CR2: 0000000000000008 CR3: 0000001ffc266000 CR4: 00000000003607e0 [ 1827.007585] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1827.017224] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1827.026817] Call Trace: [ 1827.031220] [&lt;ffffffffc0eaaeba&gt;] tgt_last_rcvd_update+0x21a/0xc90 [ptlrpc] [ 1827.040631] [&lt;ffffffffc0ae4d07&gt;] ? libcfs_debug_msg+0x57/0x80 [libcfs] [ 1827.049674] [&lt;ffffffffc0eb011d&gt;] tgt_txn_stop_cb+0x19d/0x490 [ptlrpc] [ 1827.058593] [&lt;ffffffffc0c25071&gt;] dt_txn_hook_stop+0x81/0xd0 [obdclass] [ 1827.067570] [&lt;ffffffffc1269854&gt;] osd_trans_stop+0x134/0x850 [osd_ldiskfs] [ 1827.076823] [&lt;ffffffffc0bdc283&gt;] ? llog_cat_add_rec+0x233/0x8b0 [obdclass] [ 1827.086182] [&lt;ffffffffc0eca602&gt;] top_trans_stop+0x92/0x930 [ptlrpc] [ 1827.094806] [&lt;ffffffff9d0f944f&gt;] ? __getnstimeofday64+0x3f/0xd0 [ 1827.103028] [&lt;ffffffffc147c5e9&gt;] lod_trans_stop+0x259/0x340 [lod] [ 1827.111424] [&lt;ffffffffc151b7ba&gt;] mdd_trans_stop+0x2a/0x46 [mdd] [ 1827.119589] [&lt;ffffffffc150f340&gt;] mdd_xattr_get+0x2f0/0x5c0 [mdd] [ 1827.127864] [&lt;ffffffffc13caf71&gt;] mdt_getxattr+0x951/0x12c0 [mdt] [ 1827.136094] [&lt;ffffffffc0c22f7f&gt;] ? lu_object_find_at+0x20f/0x2b0 [obdclass] [ 1827.145358] [&lt;ffffffffc13b477c&gt;] mdt_tgt_getxattr+0x1c/0x30 [mdt] [ 1827.153671] [&lt;ffffffffc0eb741a&gt;] tgt_request_handle+0x92a/0x1370 [ptlrpc] [ 1827.162737] [&lt;ffffffffc0e5cfeb&gt;] ptlrpc_server_handle_request+0x23b/0xaa0 [ptlrpc] [ 1827.172666] [&lt;ffffffffc0e59618&gt;] ? ptlrpc_wait_event+0x98/0x340 [ptlrpc] [ 1827.181578] [&lt;ffffffff9d0cf682&gt;] ? default_wake_function+0x12/0x20 [ 1827.189891] [&lt;ffffffff9d0c52ab&gt;] ? __wake_up_common+0x5b/0x90 [ 1827.197740] [&lt;ffffffffc0e60732&gt;] ptlrpc_main+0xa92/0x1e40 [ptlrpc] [ 1827.206078] [&lt;ffffffffc0e5fca0&gt;] ? ptlrpc_register_service+0xe30/0xe30 [ptlrpc] [ 1827.215631] [&lt;ffffffff9d0bb621&gt;] kthread+0xd1/0xe0 [ 1827.222337] [&lt;ffffffff9d0bb550&gt;] ? insert_kthread_work+0x40/0x40 [ 1827.230379] [&lt;ffffffff9d7205f7&gt;] ret_from_fork_nospec_begin+0x21/0x21 [ 1827.238877] [&lt;ffffffff9d0bb550&gt;] ? insert_kthread_work+0x40/0x40 </pre> </div></div> LU-12324

zero transno on transaction commit

Bug Critical Resolved Fixed Oleg Drokin Oleg Drokin Wed, 22 May 2019 05:21:12 +0000 Tue, 8 Oct 2019 17:04:26 +0000 Sat, 25 May 2019 05:31:54 +0000 Lustre 2.13.0 Lustre 2.12.1 Lustre 2.13.0 Lustre 2.12.3 0 4 <p>Oleg Drokin (green@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/34936" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34936</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12324" title="zero transno on transaction commit" class="issue-link" data-issue-key="LU-12324"><del>LU-12324</del></a> mdd: Do not record xattr size get in changelogs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 978a35803fb1d683bd827b056c2b6b2ee808387b</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34936/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34936/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12324" title="zero transno on transaction commit" class="issue-link" data-issue-key="LU-12324"><del>LU-12324</del></a> mdd: Do not record xattr size get in changelogs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8f2599c599011a50549cdc79f0b3379239cf4f0c</p> <p>Landed for 2.13</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35010" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35010</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12324" title="zero transno on transaction commit" class="issue-link" data-issue-key="LU-12324"><del>LU-12324</del></a> mdd: Do not record xattr size get in changelogs<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 234dfa5cdefc631b14de3db6030fb7823c680732</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35010/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35010/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12324" title="zero transno on transaction commit" class="issue-link" data-issue-key="LU-12324"><del>LU-12324</del></a> mdd: Do not record xattr size get in changelogs<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: f94aecf16859e2e0dcd999eb8862227e50671ee8</p> Related Development Rank 1|i00gpj: Rank (Obsolete) 9223372036854775807 Severity