https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12352 Lustre <p>Due to a bug in the code, libcfs will crash if the number of online cpus does not divide by the number of cpu partitions. Based on the checks in cfs_cpt_table_create(), it appears that the original intent was to push the remaining cpus into the initial partitions. </p> <p>A simple reproducer for a system with cpus number that is not a multiple of 3 is:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> insmod libcfs.ko cpu_pattern="" cpu_npartitions=3 </pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [112628.427628] LNetError: 14786:0:(libcfs_cpu.c:770:cfs_cpt_choose_ncpus()) ASSERTION( number &gt; 0 ) failed: [112628.427862] LNetError: 14786:0:(libcfs_cpu.c:770:cfs_cpt_choose_ncpus()) LBUG [112628.428073] Pid: 14786, comm: insmod 3.10.0-693.21.1.x3.1.10.x86_64 #1 SMP Wed Nov 14 12:16:53 CST 2018 [112628.428082] Call Trace: [112628.428180] [&lt;ffffffff8103a212&gt;] save_stack_trace_tsk+0x22/0x40 [112628.428198] [&lt;ffffffffc067d7cc&gt;] libcfs_call_trace+0x8c/0xc0 [libcfs] [112628.428231] [&lt;ffffffffc067d87c&gt;] lbug_with_loc+0x4c/0xa0 [libcfs] [112628.428261] [&lt;ffffffffc069137a&gt;] cfs_cpt_choose_ncpus+0x81a/0x820 [libcfs] [112628.428294] [&lt;ffffffffc06915ba&gt;] cfs_cpt_table_create+0x23a/0x8d0 [libcfs] [112628.428325] [&lt;ffffffffc0691d4b&gt;] cfs_cpu_init+0xbb/0xb70 [libcfs] [112628.428356] [&lt;ffffffffc06df031&gt;] libcfs_init+0x31/0x1000 [libcfs] [112628.428388] [&lt;ffffffff810020ea&gt;] do_one_initcall+0xba/0x240 [112628.428400] [&lt;ffffffff81104424&gt;] load_module+0x1f84/0x2a10 [112628.428413] [&lt;ffffffff81105066&gt;] SyS_finit_module+0xa6/0xd0 [112628.428423] [&lt;ffffffff816c1715&gt;] system_call_fastpath+0x1c/0x21 [112628.428436] [&lt;ffffffffffffffff&gt;] 0xffffffffffffffff [112628.428469] Kernel panic - not syncing: LBUG [112628.428572] CPU: 3 PID: 14786 Comm: insmod Tainted: G OE ------------ 3.10.0-693.21.1.x3.1.10.x86_64 #1 [112628.428782] Hardware name: /D525MWV, BIOS MWPNT10N.86A.0083.2011.0524.1600 05/24/2011 [112628.428970] Call Trace: [112628.429046] [&lt;ffffffff816ae7c8&gt;] dump_stack+0x19/0x1b [112628.429049] [&lt;ffffffff816a8634&gt;] panic+0xe8/0x21f [112628.429049] [&lt;ffffffffc067d8cb&gt;] lbug_with_loc+0x9b/0xa0 [libcfs] [112628.429049] [&lt;ffffffffc069137a&gt;] cfs_cpt_choose_ncpus+0x81a/0x820 [libcfs] [112628.429049] [&lt;ffffffffc06915ba&gt;] cfs_cpt_table_create+0x23a/0x8d0 [libcfs] [112628.429049] [&lt;ffffffffc06df000&gt;] ? 0xffffffffc06defff [112628.429049] [&lt;ffffffffc0691d4b&gt;] cfs_cpu_init+0xbb/0xb70 [libcfs] [112628.429049] [&lt;ffffffffc06df000&gt;] ? 0xffffffffc06defff [112628.429049] [&lt;ffffffffc06df031&gt;] libcfs_init+0x31/0x1000 [libcfs] [112628.429049] [&lt;ffffffff810020ea&gt;] do_one_initcall+0xba/0x240 [112628.429049] [&lt;ffffffff81104424&gt;] load_module+0x1f84/0x2a10 [112628.429049] [&lt;ffffffff813523e0&gt;] ? ddebug_proc_write+0xf0/0xf0 [112628.429049] [&lt;ffffffff816c514a&gt;] ? ftrace_graph_caller+0x5a/0x85 [112628.429049] [&lt;ffffffff81100a83&gt;] ? copy_module_from_fd.isra.42+0x53/0x150 [112628.429049] [&lt;ffffffff81105066&gt;] SyS_finit_module+0xa6/0xd0 [112628.429049] [&lt;ffffffff816c1715&gt;] system_call_fastpath+0x1c/0x21 [112628.429049] [&lt;ffffffff816c1661&gt;] ? system_call_after_swapgs+0xae/0x146 </pre> </div></div> <p>A fix will be uploaded shortly.</p> LU-12352

libcfs crashes with certain cpu_npartitions values

Bug Minor Resolved Fixed Andrew Perepechko Andrew Perepechko patch Wed, 29 May 2019 15:19:36 +0000 Thu, 22 Oct 2020 13:46:02 +0000 Tue, 4 Jun 2019 12:07:59 +0000 Lustre 2.13.0 Lustre 2.12.6 0 2 <p>Andrew Perepechko (c17827@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/34991" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34991</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12352" title="libcfs crashes with certain cpu_npartitions values" class="issue-link" data-issue-key="LU-12352"><del>LU-12352</del></a> libcfs: crashes with certain cpu part numbers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 481632a1ff40201998fd564fbf811303c2535b93</p> <p>With the fix:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [root@panda-testbox libcfs]# insmod libcfs.ko cpu_pattern="" cpu_npartitions=3 [root@panda-testbox libcfs]# cat /sys/kernel/debug/lnet/cpu_partition_table 0 : 0 1 1 : 2 2 : 3 </pre> </div></div> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34991/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34991/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12352" title="libcfs crashes with certain cpu_npartitions values" class="issue-link" data-issue-key="LU-12352"><del>LU-12352</del></a> libcfs: crashes with certain cpu part numbers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e33e3da58972a811e6eafc479f95f6df2baf4b9b</p> <p>Landed for 2.13</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/37994" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37994</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12352" title="libcfs crashes with certain cpu_npartitions values" class="issue-link" data-issue-key="LU-12352"><del>LU-12352</del></a> libcfs: crashes with certain cpu part numbers<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 4583a0b67d198cf53c6b715e5decd31944fd66b0</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37994/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37994/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12352" title="libcfs crashes with certain cpu_npartitions values" class="issue-link" data-issue-key="LU-12352"><del>LU-12352</del></a> libcfs: crashes with certain cpu part numbers<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 6677b0ad0db9d4b826d77a768bf561bfe6533ffe</p> Related Development Rank 1|i00h53: Rank (Obsolete) 9223372036854775807 Severity