https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12383 Lustre <p>Regular files inherit the Project Inherit flag in ldiskfs, zfs they do not.</p> <p>Given the following commands:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>mkdir proj lfs project -sp 1000 proj touch proj/test lfs project proj </pre> </div></div> <p>ldiskfs output:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> 1000 P proj/test </pre> </div></div> <p>ZFS 0.8.0 output:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> 1000 - proj/test </pre> </div></div> <p> Both correctly set inherit on sub-directories. </p> <p> </p> <p>This difference in behavior causes sanity-quota test_54 to fail for ZFS 0.8.0</p> <p><a href="https://testing.whamcloud.com/test_sets/afa8f438-81b8-11e9-869c-52540065bddc" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/test_sets/afa8f438-81b8-11e9-869c-52540065bddc</a></p> LU-12383

lfs project inhert difference between ldiskfs and zfs

Bug Critical Resolved Fixed Wang Shilong Nathaniel Clark quota Tue, 4 Jun 2019 14:22:22 +0000 Fri, 12 Jul 2019 14:18:13 +0000 Sun, 16 Jun 2019 03:58:45 +0000 Lustre 2.13.0 Lustre 2.13.0 Lustre 2.12.3 0 7 <p>Is there a specification for behavior of the INHERIT bit on regular files?  It seems that it doesn't make sense for the inherit bit to be set on a regular file, just on sub-directories.</p> <p>There would be three ways to fix this. </p> <ol> <li>Alter ZFS (or osd-zfs) to set inherit bit on files created under directory with it set</li> <li>Change sanity-quota/test_54 to not care if bit is set on those files ("c1")</li> <li>Alter <tt>lfs project -c</tt> to not complain if inherit bit is "missing" from regular files</li> </ol> <p>My initial impression is that, I'm not sure #1 is "correct".  #2 seems like a hack, so I think #3 is best option, since I don't feel like it makes sense for a regular file to have this bit set.</p> <p>How does the inheritance of this flag work on native ext4 and XFS? To my thinking, it doesn't make sense to inherit this flag on regular files, only directories. That would imply the correct fix is a fourth option - not to inherit the flag in ldiskfs, and match the behavior of ZFS, but let's first see how other filesystems handle it. </p> <p>I just checked Upstream ext4 and xfs:</p> <p>XFS only inherit inherit flag for Directory, but ext4 always inherit it for dirs/regular files.<br/> To fix this problem, I'd prefer:</p> <p>1) Alter lfs project -c to only complain if inherit bit is "missing" from Directory.<br/> 2) send a patch to upstream ext4 to keep consistent behavior with ext4 with xfs/zfs.</p> <p>Notice, even we have inherit flag for regular files, it dose no harm as well.</p> <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/35076" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35076</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12383" title="lfs project inhert difference between ldiskfs and zfs" class="issue-link" data-issue-key="LU-12383"><del>LU-12383</del></a> utils: only check project inherit bit for dir<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 745050395fdb431e24b4cc7c07f8cefa360bf6a4</p> <p>Following simple ext4 patch shall fix the problem:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 1cb67859e051..ceb74093e138 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -421,7 +421,8 @@ struct flex_groups { EXT4_PROJINHERIT_FL | EXT4_CASEFOLD_FL) /* Flags that are appropriate for regular files (all but dir-specific ones). */ -#define EXT4_REG_FLMASK (~(EXT4_DIRSYNC_FL | EXT4_TOPDIR_FL | EXT4_CASEFOLD_FL)) +#define EXT4_REG_FLMASK (~(EXT4_DIRSYNC_FL | EXT4_TOPDIR_FL | EXT4_CASEFOLD_FL |\ + EXT4_PROJINHERIT_FL)) /* Flags that are appropriate for non-directories/regular files. */ #define EXT4_OTHER_FLMASK (EXT4_NODUMP_FL | EXT4_NOATIME_FL) </pre> </div></div> <p>FYI, I sent two Linux upstream patches to fix ext4 and f2fs:</p> <p><a href="http://patchwork.ozlabs.org/patch/1110877/" class="external-link" target="_blank" rel="nofollow noopener">http://patchwork.ozlabs.org/patch/1110877/</a><br/> <a href="http://patchwork.ozlabs.org/patch/1110878/" class="external-link" target="_blank" rel="nofollow noopener">http://patchwork.ozlabs.org/patch/1110878/</a></p> <p>Please also submit an ldiskfs patch for this, I have also reviewed the ext4 patch on the list.</p> <p>Andreas,</p> <p>Since there won't be obvious errors with <a href="https://jira.whamcloud.com/browse/LU-12383" title="lfs project inhert difference between ldiskfs and zfs" class="issue-link" data-issue-key="LU-12383"><del>LU-12383</del></a> utils: only check project inherit bit for dir<br/> Do you think we'd better include ldiskfs fix parts too?</p> <p>I think it makes sense to include ldiskfs-side patches, so that we get fewer "corrupt" inodes on a filesystem, and hopefully they can mostly be aged out of the filesystem after the ldsiskfs patch has been around for some time. </p> <p>We will also want a patch for e2fsck to detect and repair these errors on non-directory inodes without complaining too much.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35076/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35076/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12383" title="lfs project inhert difference between ldiskfs and zfs" class="issue-link" data-issue-key="LU-12383"><del>LU-12383</del></a> utils: only check project inherit bit for dir<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e4ad5c17c99e7ede5deabffe0bacdd851240eb86</p> <p>Landed for 2.13</p> <p>Should we create another ticket to track the ldiskfs patch?</p> <p>We can reopen this one if it seems likely to complete this work during the 2.13 cycle. If that is in doubt then, sure, let's have a new ticket linked to this one</p> <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/35393" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35393</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12383" title="lfs project inhert difference between ldiskfs and zfs" class="issue-link" data-issue-key="LU-12383"><del>LU-12383</del></a> utils: only check project inherit bit for dir<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: b84e222d7075acc702a239ee4ece3c71e22576a0</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35393/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35393/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12383" title="lfs project inhert difference between ldiskfs and zfs" class="issue-link" data-issue-key="LU-12383"><del>LU-12383</del></a> utils: only check project inherit bit for dir<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 1299c5d5f92a7086b48b721d35bfce9ded177b94</p> Blocker LU-12336 Development Rank 1|i00hj3: Rank (Obsolete) 9223372036854775807 Severity